You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2017/12/20 20:35:45 UTC

[kudu-CR] KUDU-2236: fix flake in TestKuduClient

Hello Kudu Jenkins, Hao Hao, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/8892

to look at the new patch set (#3).

Change subject: KUDU-2236: fix flake in TestKuduClient
......................................................................

KUDU-2236: fix flake in TestKuduClient

TestKuduClient.testCloseShortlyAfterOpen would expect 0 log spew, and
ensure that no unexpected exceptions were caught. It noted that
"connection disconnected" errors were possible, but added a wait to make
them less likely. This turned out to be extremely flaky.

This patch replaces the wait with logic to catch the appropriate error
message.

Without this patch, the test only passed 57/100 runs. With the patch, it
passes 100/100.

Change-Id: Ice5b404107dd425eab5ea3f382090b2304ef8a5e
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
1 file changed, 6 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/92/8892/3
-- 
To view, visit http://gerrit.cloudera.org:8080/8892
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ice5b404107dd425eab5ea3f382090b2304ef8a5e
Gerrit-Change-Number: 8892
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins