You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Kevin Klues <kl...@gmail.com> on 2017/05/02 22:51:06 UTC

Re: Review Request 58719: CLI: Added utility functions related to HTTP.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58719/#review173667
-----------------------------------------------------------


Ship it!




I think some of this will be superceded by the work that Eric Chung is doing to provide a more sophisticated HTTP library for the CLI. But this should work for now until that work lands.

- Kevin Klues


On April 25, 2017, 10:18 p.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58719/
> -----------------------------------------------------------
> 
> (Updated April 25, 2017, 10:18 p.m.)
> 
> 
> Review request for mesos and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This will be used by future plugins and tests.
> 
> 
> Diffs
> -----
> 
>   src/cli_new/lib/cli/http.py PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/58719/diff/1/
> 
> 
> Testing
> -------
> 
> Tested manually, PEP8 and Pylint used to make sure that the code style is correct.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>