[GitHub] [iceberg] nastra commented on a diff in pull request #8147: Core: Add metadata updates for Views

["nastra (via GitHub)" <gi...@apache.org>]

nastra commented on code in PR #8147:
URL: https://github.com/apache/iceberg/pull/8147#discussion_r1280345169


##########
core/src/main/java/org/apache/iceberg/MetadataUpdate.java:
##########
@@ -60,6 +66,11 @@ public int formatVersion() {
     public void applyTo(TableMetadata.Builder metadataBuilder) {
       metadataBuilder.upgradeFormatVersion(formatVersion);
     }
+
+    @Override
+    public void applyTo(ViewMetadata.Builder viewMetadataBuilder) {
+      viewMetadataBuilder.formatVersion(formatVersion);

Review Comment:
   done



##########
core/src/main/java/org/apache/iceberg/MetadataUpdate.java:
##########
@@ -100,6 +116,11 @@ public int schemaId() {
     public void applyTo(TableMetadata.Builder metadataBuilder) {
       metadataBuilder.setCurrentSchema(schemaId);
     }
+
+    @Override
+    public void applyTo(ViewMetadata.Builder viewMetadataBuilder) {
+      viewMetadataBuilder.currentSchemaId(schemaId);

Review Comment:
   done



##########
core/src/main/java/org/apache/iceberg/MetadataUpdate.java:
##########
@@ -343,6 +364,11 @@ public Map<String, String> updated() {
     public void applyTo(TableMetadata.Builder metadataBuilder) {
       metadataBuilder.setProperties(updated);
     }
+
+    @Override
+    public void applyTo(ViewMetadata.Builder viewMetadataBuilder) {
+      viewMetadataBuilder.properties(updated);

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org