You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2020/01/13 13:12:14 UTC

[GitHub] [kylin] wangxiaojing123 opened a new pull request #1058: KYLIN-4338 Web page modification to support global domain dict

wangxiaojing123 opened a new pull request #1058: KYLIN-4338 Web page modification to support global domain dict
URL: https://github.com/apache/kylin/pull/1058
 
 
   issue link : https://issues.apache.org/jira/browse/KYLIN-4338

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] coveralls commented on issue #1058: KYLIN-4338 Web page modification to support global domain dict

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #1058: KYLIN-4338 Web page modification to support global domain dict
URL: https://github.com/apache/kylin/pull/1058#issuecomment-573699498
 
 
   ## Pull Request Test Coverage Report for [Build 5517](https://coveralls.io/builds/28070826)
   
   * **19** of **113**   **(16.81%)**  changed or added relevant lines in **9** files are covered.
   * **3** unchanged lines in **2** files lost coverage.
   * Overall coverage decreased (**-0.02%**) to **27.506%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [core-cube/src/main/java/org/apache/kylin/cube/CubeManager.java](https://coveralls.io/builds/28070826/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2FCubeManager.java#L1196) | 5 | 6 | 83.33%
   | [core-cube/src/main/java/org/apache/kylin/cube/model/validation/rule/DictionaryRule.java](https://coveralls.io/builds/28070826/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fmodel%2Fvalidation%2Frule%2FDictionaryRule.java#L88) | 4 | 5 | 80.0%
   | [engine-mr/src/main/java/org/apache/kylin/engine/mr/common/AbstractHadoopJob.java](https://coveralls.io/builds/28070826/source?filename=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2Fcommon%2FAbstractHadoopJob.java#L591) | 0 | 1 | 0.0%
   | [engine-spark/src/main/java/org/apache/kylin/engine/spark/SparkExecutable.java](https://coveralls.io/builds/28070826/source?filename=engine-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fspark%2FSparkExecutable.java#L508) | 0 | 2 | 0.0%
   | [core-metadata/src/main/java/org/apache/kylin/metadata/model/DataModelDesc.java](https://coveralls.io/builds/28070826/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Fmodel%2FDataModelDesc.java#L296) | 5 | 8 | 62.5%
   | [core-metadata/src/main/java/org/apache/kylin/measure/bitmap/BitmapMeasureType.java](https://coveralls.io/builds/28070826/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmeasure%2Fbitmap%2FBitmapMeasureType.java#L112) | 0 | 4 | 0.0%
   | [core-cube/src/main/java/org/apache/kylin/cube/model/CubeDesc.java](https://coveralls.io/builds/28070826/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fmodel%2FCubeDesc.java#L1381) | 3 | 10 | 30.0%
   | [core-cube/src/main/java/org/apache/kylin/cube/model/DictionaryDesc.java](https://coveralls.io/builds/28070826/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fmodel%2FDictionaryDesc.java#L82) | 2 | 10 | 20.0%
   | [core-cube/src/main/java/org/apache/kylin/cube/model/CubeDescTiretreeGlobalDomainDictUtil.java](https://coveralls.io/builds/28070826/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fmodel%2FCubeDescTiretreeGlobalDomainDictUtil.java#L41) | 0 | 67 | 0.0%
   <!-- | **Total:** | **19** | **113** | **16.81%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [core-cube/src/main/java/org/apache/kylin/cube/model/CubeDesc.java](https://coveralls.io/builds/28070826/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fmodel%2FCubeDesc.java#L1386) | 1 | 69.81% |
   | [engine-spark/src/main/java/org/apache/kylin/engine/spark/SparkExecutable.java](https://coveralls.io/builds/28070826/source?filename=engine-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fspark%2FSparkExecutable.java#L525) | 2 | 0.0% |
   <!-- | **Total:** | **3** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/28070826/badge)](https://coveralls.io/builds/28070826) |
   | :-- | --: |
   | Change from base [Build 5512](https://coveralls.io/builds/28061631): |  -0.02% |
   | Covered Lines: | 24143 |
   | Relevant Lines: | 87773 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] codecov-io commented on issue #1058: KYLIN-4338 Web page modification to support global domain dict

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1058: KYLIN-4338 Web page modification to support global domain dict
URL: https://github.com/apache/kylin/pull/1058#issuecomment-573696380
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/1058?src=pr&el=h1) Report
   > Merging [#1058](https://codecov.io/gh/apache/kylin/pull/1058?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/37770217b2a9d7a62a40acae74fe77ea1d170b2a?src=pr&el=desc) will **increase** coverage by `0.03%`.
   > The diff coverage is `9.73%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/kylin/pull/1058/graphs/tree.svg?width=650&token=JawVgbgsVo&height=150&src=pr)](https://codecov.io/gh/apache/kylin/pull/1058?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1058      +/-   ##
   ============================================
   + Coverage        25%   25.04%   +0.03%     
   - Complexity     6180     6222      +42     
   ============================================
     Files          1438     1439       +1     
     Lines         87669    87773     +104     
     Branches      12256    12272      +16     
   ============================================
   + Hits          21926    21985      +59     
   - Misses        63593    63633      +40     
   - Partials       2150     2155       +5
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1058?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...org/apache/kylin/engine/spark/SparkExecutable.java](https://codecov.io/gh/apache/kylin/pull/1058/diff?src=pr&el=tree#diff-ZW5naW5lLXNwYXJrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvc3BhcmsvU3BhcmtFeGVjdXRhYmxlLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...apache/kylin/measure/bitmap/BitmapMeasureType.java](https://codecov.io/gh/apache/kylin/pull/1058/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWVhc3VyZS9iaXRtYXAvQml0bWFwTWVhc3VyZVR5cGUuamF2YQ==) | `18.86% <0%> (ø)` | `4 <0> (ø)` | :arrow_down: |
   | [...be/model/CubeDescTiretreeGlobalDomainDictUtil.java](https://codecov.io/gh/apache/kylin/pull/1058/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0N1YmVEZXNjVGlyZXRyZWVHbG9iYWxEb21haW5EaWN0VXRpbC5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
   | [...ache/kylin/engine/mr/common/AbstractHadoopJob.java](https://codecov.io/gh/apache/kylin/pull/1058/diff?src=pr&el=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvY29tbW9uL0Fic3RyYWN0SGFkb29wSm9iLmphdmE=) | `15.21% <0%> (-0.04%)` | `2 <0> (ø)` | |
   | [...va/org/apache/kylin/cube/model/DictionaryDesc.java](https://codecov.io/gh/apache/kylin/pull/1058/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0RpY3Rpb25hcnlEZXNjLmphdmE=) | `65.38% <10%> (-34.62%)` | `8 <1> (+1)` | |
   | [...ain/java/org/apache/kylin/cube/model/CubeDesc.java](https://codecov.io/gh/apache/kylin/pull/1058/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0N1YmVEZXNjLmphdmE=) | `63.56% <20%> (-0.57%)` | `182 <1> (+1)` | |
   | [...org/apache/kylin/metadata/model/DataModelDesc.java](https://codecov.io/gh/apache/kylin/pull/1058/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvbW9kZWwvRGF0YU1vZGVsRGVzYy5qYXZh) | `59.21% <25%> (-0.58%)` | `72 <1> (-1)` | |
   | [...c/main/java/org/apache/kylin/cube/CubeManager.java](https://codecov.io/gh/apache/kylin/pull/1058/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL0N1YmVNYW5hZ2VyLmphdmE=) | `36.52% <50%> (+0.02%)` | `44 <0> (ø)` | :arrow_down: |
   | [...lin/cube/model/validation/rule/DictionaryRule.java](https://codecov.io/gh/apache/kylin/pull/1058/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL3ZhbGlkYXRpb24vcnVsZS9EaWN0aW9uYXJ5UnVsZS5qYXZh) | `86.84% <60%> (-4.59%)` | `16 <1> (+1)` | |
   | [...ream/core/storage/columnar/ColumnarStoreCache.java](https://codecov.io/gh/apache/kylin/pull/1058/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvQ29sdW1uYXJTdG9yZUNhY2hlLmphdmE=) | `52.27% <0%> (-3.41%)` | `8% <0%> (ø)` | |
   | ... and [7 more](https://codecov.io/gh/apache/kylin/pull/1058/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1058?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1058?src=pr&el=footer). Last update [3777021...530471d](https://codecov.io/gh/apache/kylin/pull/1058?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] coveralls edited a comment on issue #1058: KYLIN-4338 Web page modification to support global domain dict

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #1058: KYLIN-4338 Web page modification to support global domain dict
URL: https://github.com/apache/kylin/pull/1058#issuecomment-573699498
 
 
   ## Pull Request Test Coverage Report for [Build 5640](https://coveralls.io/builds/28831723)
   
   * **20** of **113**   **(17.7%)**  changed or added relevant lines in **9** files are covered.
   * **2444** unchanged lines in **63** files lost coverage.
   * Overall coverage decreased (**-0.06%**) to **27.466%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [core-cube/src/main/java/org/apache/kylin/cube/CubeManager.java](https://coveralls.io/builds/28831723/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2FCubeManager.java#L1197) | 6 | 7 | 85.71%
   | [core-cube/src/main/java/org/apache/kylin/cube/model/validation/rule/DictionaryRule.java](https://coveralls.io/builds/28831723/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fmodel%2Fvalidation%2Frule%2FDictionaryRule.java#L88) | 4 | 5 | 80.0%
   | [engine-mr/src/main/java/org/apache/kylin/engine/mr/common/AbstractHadoopJob.java](https://coveralls.io/builds/28831723/source?filename=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2Fcommon%2FAbstractHadoopJob.java#L591) | 0 | 1 | 0.0%
   | [engine-spark/src/main/java/org/apache/kylin/engine/spark/SparkExecutable.java](https://coveralls.io/builds/28831723/source?filename=engine-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fspark%2FSparkExecutable.java#L508) | 0 | 2 | 0.0%
   | [core-metadata/src/main/java/org/apache/kylin/measure/bitmap/BitmapMeasureType.java](https://coveralls.io/builds/28831723/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmeasure%2Fbitmap%2FBitmapMeasureType.java#L113) | 0 | 3 | 0.0%
   | [core-metadata/src/main/java/org/apache/kylin/metadata/model/DataModelDesc.java](https://coveralls.io/builds/28831723/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Fmodel%2FDataModelDesc.java#L296) | 5 | 8 | 62.5%
   | [core-cube/src/main/java/org/apache/kylin/cube/model/CubeDesc.java](https://coveralls.io/builds/28831723/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fmodel%2FCubeDesc.java#L1381) | 3 | 10 | 30.0%
   | [core-cube/src/main/java/org/apache/kylin/cube/model/DictionaryDesc.java](https://coveralls.io/builds/28831723/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fmodel%2FDictionaryDesc.java#L82) | 2 | 10 | 20.0%
   | [core-cube/src/main/java/org/apache/kylin/cube/model/CubeDescTiretreeGlobalDomainDictUtil.java](https://coveralls.io/builds/28831723/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fmodel%2FCubeDescTiretreeGlobalDomainDictUtil.java#L41) | 0 | 67 | 0.0%
   <!-- | **Total:** | **20** | **113** | **17.7%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [core-common/src/main/java/org/apache/kylin/common/threadlocal/InternalThreadLocal.java](https://coveralls.io/builds/28831723/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Fthreadlocal%2FInternalThreadLocal.java#L148) | 1 | 61.76% |
   | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/28831723/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L553) | 1 | 78.12% |
   | [core-cube/src/main/java/org/apache/kylin/cube/model/CubeDesc.java](https://coveralls.io/builds/28831723/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fmodel%2FCubeDesc.java#L1386) | 1 | 69.81% |
   | [core-metadata/src/main/java/org/apache/kylin/metadata/badquery/BadQueryHistoryManager.java](https://coveralls.io/builds/28831723/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Fbadquery%2FBadQueryHistoryManager.java#L92) | 1 | 83.33% |
   | [stream-coordinator/src/main/java/org/apache/kylin/stream/coordinator/client/HttpCoordinatorClient.java](https://coveralls.io/builds/28831723/source?filename=stream-coordinator%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcoordinator%2Fclient%2FHttpCoordinatorClient.java#L216) | 1 | 0% |
   | [core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://coveralls.io/builds/28831723/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcuboid%2FTreeCuboidScheduler.java#L124) | 2 | 68.46% |
   | [core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java](https://coveralls.io/builds/28831723/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fimpl%2Fthreadpool%2FDefaultScheduler.java#L194) | 2 | 80.23% |
   | [core-metadata/src/main/java/org/apache/kylin/measure/topn/DoubleDeltaSerializer.java](https://coveralls.io/builds/28831723/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmeasure%2Ftopn%2FDoubleDeltaSerializer.java#L143) | 2 | 97.92% |
   | [core-metadata/src/main/java/org/apache/kylin/metadata/TableMetadataManager.java](https://coveralls.io/builds/28831723/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2FTableMetadataManager.java#L488) | 2 | 62.19% |
   | [engine-spark/src/main/java/org/apache/kylin/engine/spark/SparkExecutable.java](https://coveralls.io/builds/28831723/source?filename=engine-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fspark%2FSparkExecutable.java#L525) | 2 | 0% |
   <!-- | **Total:** | **2444** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/28831723/badge)](https://coveralls.io/builds/28831723) |
   | :-- | --: |
   | Change from base [Build 5512](https://coveralls.io/builds/28061631): |  -0.06% |
   | Covered Lines: | 24204 |
   | Relevant Lines: | 88123 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] coveralls edited a comment on issue #1058: KYLIN-4338 Web page modification to support global domain dict

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #1058: KYLIN-4338 Web page modification to support global domain dict
URL: https://github.com/apache/kylin/pull/1058#issuecomment-573699498
 
 
   ## Pull Request Test Coverage Report for [Build 5644](https://coveralls.io/builds/28855657)
   
   * **21** of **124**   **(16.94%)**  changed or added relevant lines in **9** files are covered.
   * **10** unchanged lines in **5** files lost coverage.
   * Overall coverage decreased (**-0.02%**) to **27.465%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [core-cube/src/main/java/org/apache/kylin/cube/CubeManager.java](https://coveralls.io/builds/28855657/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2FCubeManager.java#L1197) | 6 | 7 | 85.71%
   | [core-cube/src/main/java/org/apache/kylin/cube/model/validation/rule/DictionaryRule.java](https://coveralls.io/builds/28855657/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fmodel%2Fvalidation%2Frule%2FDictionaryRule.java#L88) | 4 | 5 | 80.0%
   | [engine-mr/src/main/java/org/apache/kylin/engine/mr/common/AbstractHadoopJob.java](https://coveralls.io/builds/28855657/source?filename=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2Fcommon%2FAbstractHadoopJob.java#L591) | 0 | 1 | 0.0%
   | [engine-spark/src/main/java/org/apache/kylin/engine/spark/SparkExecutable.java](https://coveralls.io/builds/28855657/source?filename=engine-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fspark%2FSparkExecutable.java#L508) | 0 | 2 | 0.0%
   | [core-metadata/src/main/java/org/apache/kylin/measure/bitmap/BitmapMeasureType.java](https://coveralls.io/builds/28855657/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmeasure%2Fbitmap%2FBitmapMeasureType.java#L113) | 0 | 3 | 0.0%
   | [core-metadata/src/main/java/org/apache/kylin/metadata/model/DataModelDesc.java](https://coveralls.io/builds/28855657/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Fmodel%2FDataModelDesc.java#L296) | 5 | 8 | 62.5%
   | [core-cube/src/main/java/org/apache/kylin/cube/model/DictionaryDesc.java](https://coveralls.io/builds/28855657/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fmodel%2FDictionaryDesc.java#L82) | 2 | 10 | 20.0%
   | [core-cube/src/main/java/org/apache/kylin/cube/model/CubeDesc.java](https://coveralls.io/builds/28855657/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fmodel%2FCubeDesc.java#L500) | 4 | 14 | 28.57%
   | [core-cube/src/main/java/org/apache/kylin/cube/model/CubeDescTiretreeGlobalDomainDictUtil.java](https://coveralls.io/builds/28855657/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fmodel%2FCubeDescTiretreeGlobalDomainDictUtil.java#L42) | 0 | 74 | 0.0%
   <!-- | **Total:** | **21** | **124** | **16.94%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [core-cube/src/main/java/org/apache/kylin/cube/model/CubeDesc.java](https://coveralls.io/builds/28855657/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fmodel%2FCubeDesc.java#L1386) | 1 | 69.81% |
   | [core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://coveralls.io/builds/28855657/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcuboid%2FTreeCuboidScheduler.java#L124) | 2 | 68.46% |
   | [engine-spark/src/main/java/org/apache/kylin/engine/spark/SparkExecutable.java](https://coveralls.io/builds/28855657/source?filename=engine-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fspark%2FSparkExecutable.java#L525) | 2 | 0% |
   | [stream-core/src/main/java/org/apache/kylin/stream/core/storage/CheckPointStore.java](https://coveralls.io/builds/28855657/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2FCheckPointStore.java#L98) | 2 | 73.74% |
   | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/28855657/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L449) | 3 | 78.42% |
   <!-- | **Total:** | **10** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/28855657/badge)](https://coveralls.io/builds/28855657) |
   | :-- | --: |
   | Change from base [Build 5638](https://coveralls.io/builds/28817725): |  -0.02% |
   | Covered Lines: | 24205 |
   | Relevant Lines: | 88130 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] codecov-io edited a comment on issue #1058: KYLIN-4338 Web page modification to support global domain dict

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1058: KYLIN-4338 Web page modification to support global domain dict
URL: https://github.com/apache/kylin/pull/1058#issuecomment-573696380
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/1058?src=pr&el=h1) Report
   > Merging [#1058](https://codecov.io/gh/apache/kylin/pull/1058?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/37770217b2a9d7a62a40acae74fe77ea1d170b2a?src=pr&el=desc) will **increase** coverage by `0.03%`.
   > The diff coverage is `9.73%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/kylin/pull/1058/graphs/tree.svg?width=650&token=JawVgbgsVo&height=150&src=pr)](https://codecov.io/gh/apache/kylin/pull/1058?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1058      +/-   ##
   ============================================
   + Coverage        25%   25.04%   +0.03%     
   - Complexity     6180     6222      +42     
   ============================================
     Files          1438     1439       +1     
     Lines         87669    87773     +104     
     Branches      12256    12272      +16     
   ============================================
   + Hits          21926    21985      +59     
   - Misses        63593    63633      +40     
   - Partials       2150     2155       +5
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1058?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...org/apache/kylin/engine/spark/SparkExecutable.java](https://codecov.io/gh/apache/kylin/pull/1058/diff?src=pr&el=tree#diff-ZW5naW5lLXNwYXJrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvc3BhcmsvU3BhcmtFeGVjdXRhYmxlLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...apache/kylin/measure/bitmap/BitmapMeasureType.java](https://codecov.io/gh/apache/kylin/pull/1058/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWVhc3VyZS9iaXRtYXAvQml0bWFwTWVhc3VyZVR5cGUuamF2YQ==) | `18.86% <0%> (ø)` | `4 <0> (ø)` | :arrow_down: |
   | [...be/model/CubeDescTiretreeGlobalDomainDictUtil.java](https://codecov.io/gh/apache/kylin/pull/1058/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0N1YmVEZXNjVGlyZXRyZWVHbG9iYWxEb21haW5EaWN0VXRpbC5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
   | [...ache/kylin/engine/mr/common/AbstractHadoopJob.java](https://codecov.io/gh/apache/kylin/pull/1058/diff?src=pr&el=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvY29tbW9uL0Fic3RyYWN0SGFkb29wSm9iLmphdmE=) | `15.21% <0%> (-0.04%)` | `2 <0> (ø)` | |
   | [...va/org/apache/kylin/cube/model/DictionaryDesc.java](https://codecov.io/gh/apache/kylin/pull/1058/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0RpY3Rpb25hcnlEZXNjLmphdmE=) | `65.38% <10%> (-34.62%)` | `8 <1> (+1)` | |
   | [...ain/java/org/apache/kylin/cube/model/CubeDesc.java](https://codecov.io/gh/apache/kylin/pull/1058/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0N1YmVEZXNjLmphdmE=) | `63.56% <20%> (-0.57%)` | `182 <1> (+1)` | |
   | [...org/apache/kylin/metadata/model/DataModelDesc.java](https://codecov.io/gh/apache/kylin/pull/1058/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvbW9kZWwvRGF0YU1vZGVsRGVzYy5qYXZh) | `59.21% <25%> (-0.58%)` | `72 <1> (-1)` | |
   | [...c/main/java/org/apache/kylin/cube/CubeManager.java](https://codecov.io/gh/apache/kylin/pull/1058/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL0N1YmVNYW5hZ2VyLmphdmE=) | `36.52% <50%> (+0.02%)` | `44 <0> (ø)` | :arrow_down: |
   | [...lin/cube/model/validation/rule/DictionaryRule.java](https://codecov.io/gh/apache/kylin/pull/1058/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL3ZhbGlkYXRpb24vcnVsZS9EaWN0aW9uYXJ5UnVsZS5qYXZh) | `86.84% <60%> (-4.59%)` | `16 <1> (+1)` | |
   | [...ream/core/storage/columnar/ColumnarStoreCache.java](https://codecov.io/gh/apache/kylin/pull/1058/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvQ29sdW1uYXJTdG9yZUNhY2hlLmphdmE=) | `52.27% <0%> (-3.41%)` | `8% <0%> (ø)` | |
   | ... and [7 more](https://codecov.io/gh/apache/kylin/pull/1058/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1058?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1058?src=pr&el=footer). Last update [3777021...530471d](https://codecov.io/gh/apache/kylin/pull/1058?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] codecov-io edited a comment on issue #1058: KYLIN-4338 Web page modification to support global domain dict

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1058: KYLIN-4338 Web page modification to support global domain dict
URL: https://github.com/apache/kylin/pull/1058#issuecomment-573696380
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/1058?src=pr&el=h1) Report
   > Merging [#1058](https://codecov.io/gh/apache/kylin/pull/1058?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/37770217b2a9d7a62a40acae74fe77ea1d170b2a?src=pr&el=desc) will **increase** coverage by `0.03%`.
   > The diff coverage is `9.73%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/kylin/pull/1058/graphs/tree.svg?width=650&token=JawVgbgsVo&height=150&src=pr)](https://codecov.io/gh/apache/kylin/pull/1058?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1058      +/-   ##
   ============================================
   + Coverage        25%   25.04%   +0.03%     
   - Complexity     6180     6222      +42     
   ============================================
     Files          1438     1439       +1     
     Lines         87669    87773     +104     
     Branches      12256    12272      +16     
   ============================================
   + Hits          21926    21985      +59     
   - Misses        63593    63633      +40     
   - Partials       2150     2155       +5
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1058?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...org/apache/kylin/engine/spark/SparkExecutable.java](https://codecov.io/gh/apache/kylin/pull/1058/diff?src=pr&el=tree#diff-ZW5naW5lLXNwYXJrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvc3BhcmsvU3BhcmtFeGVjdXRhYmxlLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...apache/kylin/measure/bitmap/BitmapMeasureType.java](https://codecov.io/gh/apache/kylin/pull/1058/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWVhc3VyZS9iaXRtYXAvQml0bWFwTWVhc3VyZVR5cGUuamF2YQ==) | `18.86% <0%> (ø)` | `4 <0> (ø)` | :arrow_down: |
   | [...be/model/CubeDescTiretreeGlobalDomainDictUtil.java](https://codecov.io/gh/apache/kylin/pull/1058/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0N1YmVEZXNjVGlyZXRyZWVHbG9iYWxEb21haW5EaWN0VXRpbC5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
   | [...ache/kylin/engine/mr/common/AbstractHadoopJob.java](https://codecov.io/gh/apache/kylin/pull/1058/diff?src=pr&el=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvY29tbW9uL0Fic3RyYWN0SGFkb29wSm9iLmphdmE=) | `15.21% <0%> (-0.04%)` | `2 <0> (ø)` | |
   | [...va/org/apache/kylin/cube/model/DictionaryDesc.java](https://codecov.io/gh/apache/kylin/pull/1058/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0RpY3Rpb25hcnlEZXNjLmphdmE=) | `65.38% <10%> (-34.62%)` | `8 <1> (+1)` | |
   | [...ain/java/org/apache/kylin/cube/model/CubeDesc.java](https://codecov.io/gh/apache/kylin/pull/1058/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0N1YmVEZXNjLmphdmE=) | `63.56% <20%> (-0.57%)` | `182 <1> (+1)` | |
   | [...org/apache/kylin/metadata/model/DataModelDesc.java](https://codecov.io/gh/apache/kylin/pull/1058/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvbW9kZWwvRGF0YU1vZGVsRGVzYy5qYXZh) | `59.21% <25%> (-0.58%)` | `72 <1> (-1)` | |
   | [...c/main/java/org/apache/kylin/cube/CubeManager.java](https://codecov.io/gh/apache/kylin/pull/1058/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL0N1YmVNYW5hZ2VyLmphdmE=) | `36.52% <50%> (+0.02%)` | `44 <0> (ø)` | :arrow_down: |
   | [...lin/cube/model/validation/rule/DictionaryRule.java](https://codecov.io/gh/apache/kylin/pull/1058/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL3ZhbGlkYXRpb24vcnVsZS9EaWN0aW9uYXJ5UnVsZS5qYXZh) | `86.84% <60%> (-4.59%)` | `16 <1> (+1)` | |
   | [...ream/core/storage/columnar/ColumnarStoreCache.java](https://codecov.io/gh/apache/kylin/pull/1058/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvQ29sdW1uYXJTdG9yZUNhY2hlLmphdmE=) | `52.27% <0%> (-3.41%)` | `8% <0%> (ø)` | |
   | ... and [7 more](https://codecov.io/gh/apache/kylin/pull/1058/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1058?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1058?src=pr&el=footer). Last update [3777021...530471d](https://codecov.io/gh/apache/kylin/pull/1058?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] nichunen merged pull request #1058: KYLIN-4338 Web page modification to support global domain dict

Posted by GitBox <gi...@apache.org>.
nichunen merged pull request #1058: KYLIN-4338 Web page modification to support global domain dict
URL: https://github.com/apache/kylin/pull/1058
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] codecov-io edited a comment on issue #1058: KYLIN-4338 Web page modification to support global domain dict

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1058: KYLIN-4338 Web page modification to support global domain dict
URL: https://github.com/apache/kylin/pull/1058#issuecomment-573696380
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/1058?src=pr&el=h1) Report
   > Merging [#1058](https://codecov.io/gh/apache/kylin/pull/1058?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/37770217b2a9d7a62a40acae74fe77ea1d170b2a?src=pr&el=desc) will **decrease** coverage by `<.01%`.
   > The diff coverage is `10.61%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/kylin/pull/1058/graphs/tree.svg?width=650&token=JawVgbgsVo&height=150&src=pr)](https://codecov.io/gh/apache/kylin/pull/1058?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##             master   #1058      +/-   ##
   ===========================================
   - Coverage        25%     25%   -0.01%     
   - Complexity     6180    6229      +49     
   ===========================================
     Files          1438    1443       +5     
     Lines         87669   88123     +454     
     Branches      12256   12337      +81     
   ===========================================
   + Hits          21926   22034     +108     
   - Misses        63593   63922     +329     
   - Partials       2150    2167      +17
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1058?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...org/apache/kylin/engine/spark/SparkExecutable.java](https://codecov.io/gh/apache/kylin/pull/1058/diff?src=pr&el=tree#diff-ZW5naW5lLXNwYXJrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvc3BhcmsvU3BhcmtFeGVjdXRhYmxlLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...apache/kylin/measure/bitmap/BitmapMeasureType.java](https://codecov.io/gh/apache/kylin/pull/1058/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWVhc3VyZS9iaXRtYXAvQml0bWFwTWVhc3VyZVR5cGUuamF2YQ==) | `18.51% <0%> (-0.35%)` | `4 <0> (ø)` | |
   | [...be/model/CubeDescTiretreeGlobalDomainDictUtil.java](https://codecov.io/gh/apache/kylin/pull/1058/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0N1YmVEZXNjVGlyZXRyZWVHbG9iYWxEb21haW5EaWN0VXRpbC5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
   | [...ache/kylin/engine/mr/common/AbstractHadoopJob.java](https://codecov.io/gh/apache/kylin/pull/1058/diff?src=pr&el=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvY29tbW9uL0Fic3RyYWN0SGFkb29wSm9iLmphdmE=) | `15.21% <0%> (-0.04%)` | `2 <0> (ø)` | |
   | [...va/org/apache/kylin/cube/model/DictionaryDesc.java](https://codecov.io/gh/apache/kylin/pull/1058/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0RpY3Rpb25hcnlEZXNjLmphdmE=) | `65.38% <10%> (-34.62%)` | `8 <1> (+1)` | |
   | [...ain/java/org/apache/kylin/cube/model/CubeDesc.java](https://codecov.io/gh/apache/kylin/pull/1058/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0N1YmVEZXNjLmphdmE=) | `63.56% <20%> (-0.57%)` | `182 <1> (+1)` | |
   | [...org/apache/kylin/metadata/model/DataModelDesc.java](https://codecov.io/gh/apache/kylin/pull/1058/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvbW9kZWwvRGF0YU1vZGVsRGVzYy5qYXZh) | `59.21% <25%> (-0.58%)` | `72 <1> (-1)` | |
   | [...c/main/java/org/apache/kylin/cube/CubeManager.java](https://codecov.io/gh/apache/kylin/pull/1058/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL0N1YmVNYW5hZ2VyLmphdmE=) | `36.62% <57.14%> (+0.12%)` | `44 <0> (ø)` | :arrow_down: |
   | [...lin/cube/model/validation/rule/DictionaryRule.java](https://codecov.io/gh/apache/kylin/pull/1058/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL3ZhbGlkYXRpb24vcnVsZS9EaWN0aW9uYXJ5UnVsZS5qYXZh) | `86.84% <60%> (-4.59%)` | `16 <1> (+1)` | |
   | [...engine/spark/util/PercentileCounterSerializer.java](https://codecov.io/gh/apache/kylin/pull/1058/diff?src=pr&el=tree#diff-ZW5naW5lLXNwYXJrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvc3BhcmsvdXRpbC9QZXJjZW50aWxlQ291bnRlclNlcmlhbGl6ZXIuamF2YQ==) | `90.47% <0%> (-9.53%)` | `3% <0%> (ø)` | |
   | ... and [77 more](https://codecov.io/gh/apache/kylin/pull/1058/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1058?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1058?src=pr&el=footer). Last update [3777021...1ca13f7](https://codecov.io/gh/apache/kylin/pull/1058?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] lgtm-com[bot] commented on issue #1058: KYLIN-4338 Web page modification to support global domain dict

Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on issue #1058: KYLIN-4338 Web page modification to support global domain dict
URL: https://github.com/apache/kylin/pull/1058#issuecomment-588351324
 
 
   This pull request **introduces 4 alerts** when merging 1ca13f7ca40dd4a9939cc883a5c964f40c5d12b1 into 78deee8fc431cc32d67d9384423cf4f09196b605 - [view on LGTM.com](https://lgtm.com/projects/g/apache/kylin/rev/pr-be649b599cdfa77ccf2c6726467b3a798c4bcbef)
   
   **new alerts:**
   
   * 3 for Missing format argument
   * 1 for Unused format argument

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] lgtm-com[bot] commented on issue #1058: KYLIN-4338 Web page modification to support global domain dict

Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on issue #1058: KYLIN-4338 Web page modification to support global domain dict
URL: https://github.com/apache/kylin/pull/1058#issuecomment-588893544
 
 
   This pull request **introduces 4 alerts** when merging 23cf65d3bce88bf354ec10dcea9fa6f328f6d694 into 78deee8fc431cc32d67d9384423cf4f09196b605 - [view on LGTM.com](https://lgtm.com/projects/g/apache/kylin/rev/pr-03ee7214382852defef2aec75f9f91b53c31c088)
   
   **new alerts:**
   
   * 3 for Missing format argument
   * 1 for Unused format argument

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] lgtm-com[bot] commented on issue #1058: KYLIN-4338 Web page modification to support global domain dict

Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on issue #1058: KYLIN-4338 Web page modification to support global domain dict
URL: https://github.com/apache/kylin/pull/1058#issuecomment-589039325
 
 
   This pull request **introduces 4 alerts** when merging 58e0cfd85cc9de659b32bf51930e442da1a30816 into 78deee8fc431cc32d67d9384423cf4f09196b605 - [view on LGTM.com](https://lgtm.com/projects/g/apache/kylin/rev/pr-c2b1c45eb0f77188fd2b4a586af9e3c1a34cb0ca)
   
   **new alerts:**
   
   * 3 for Missing format argument
   * 1 for Unused format argument

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services