[GitHub] [incubator-doris] morningman commented on a change in pull request #6374: [BUG] Fix query failure caused by using case-insensitive system view names in information_schema.

[GitBox <gi...@apache.org>]

morningman commented on a change in pull request #6374:
URL: https://github.com/apache/incubator-doris/pull/6374#discussion_r682722871



##########
File path: fe/fe-core/src/main/java/org/apache/doris/analysis/Analyzer.java
##########
@@ -553,7 +552,7 @@ public TableRef resolveTableRef(TableRef tableRef) throws AnalysisException {
             ErrorReport.reportAnalysisException(ErrorCode.ERR_BAD_TABLE_STATE, "RESTORING");
         }
 
-        TableName tblName = new TableName(database.getFullName(), table.getName());
+        TableName tblName = new TableName(dbName, tableName.getTbl());

Review comment:
       Add comment to explain why using `tableName.getTbl()` instead of `table.getName()` here.

##########
File path: fe/fe-core/src/main/java/org/apache/doris/analysis/Analyzer.java
##########
@@ -618,10 +617,6 @@ public SlotDescriptor registerColumnRef(TableName tblName, String colName) throw
         if (newTblName == null) {

Review comment:
       The local variable `newTblName` seems unused now.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org