You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@asterixdb.apache.org by Ian Maxon <im...@uci.edu> on 2022/02/25 07:52:25 UTC

[VOTE] Release Apache AsterixDB JDBC Connector 0.9.7.1 (RC1)

Hi everyone,

Please verify and vote on the first release of the AsterixDB JDBC connector.

This release candidate fixes some issues with license files that were present
in RC0 as well as simplifying the list of artifacts.

The change that produced this release is up on Gerrit:

https://asterix-gerrit.ics.uci.edu/c/asterixdb-clients/+/15444

The release artifacts are as follows:

JDBC Driver Source
https://dist.apache.org/repos/dist/dev/asterixdb/apache-asterixdb-jdbc-0.9.7.1-source-release.zip
https://dist.apache.org/repos/dist/dev/asterixdb/apache-asterixdb-jdbc-0.9.7.1-source-release.zip.asc
https://dist.apache.org/repos/dist/dev/asterixdb/apache-asterixdb-jdbc-0.9.7.1-source-release.zip.sha512

SHA512: b851a73bfd3da0cd7c17d3c4247a924ecd85c5138bab3f36f813109db38918f3f2993a75f57ae4b7d532719b01d7cb3c9fcfdd0de0dbd47452e9394d01ff5441⏎

JDBC Driver Distributable Jar
https://dist.apache.org/repos/dist/dev/asterixdb/asterix-jdbc-driver-0.9.7.1-dist.jar
https://dist.apache.org/repos/dist/dev/asterixdb/asterix-jdbc-driver-0.9.7.1-dist.jar.asc
https://dist.apache.org/repos/dist/dev/asterixdb/asterix-jdbc-driver-0.9.7.1-dist.jar.sha512

SHA512: c7184054958dffb280de51fc472c4f94e218b2d67435fae73a10663a46d8fc06c607da520facbd4c8ba159b0e7339a23e64079361bff2f9e4ef3c76a2a900df1

Tableau Connector (TACO file)
https://dist.apache.org/repos/dist/dev/asterixdb/asterixdb_jdbc.taco
https://dist.apache.org/repos/dist/dev/asterixdb/asterixdb_jdbc.taco.asc
https://dist.apache.org/repos/dist/dev/asterixdb/asterixdb_jdbc.taco.sha512

SHA512: 2538bd8e5266c280a0ff3de7bdb7e262d7963207181a8bfba3bb852c1c9c3820ea3495e68e4e31038e18542f01891ae2734007e29aea74219e7c1896d0807321


The KEYS file containing the PGP keys used to sign the release can be
found at

https://dist.apache.org/repos/dist/release/asterixdb/KEYS

RAT was executed as part of Maven via the RAT maven plugin, but
excludes files that are:

- data for tests
- procedurally generated,
- or source files which come without a header mentioning their license,
  but have an explicit reference in the LICENSE file.


The vote is open for 72 hours, or until the necessary number of votes
(3 +1) has been reached.

Please vote
[ ] +1 release these packages as Apache AsterixDB JDBC Driver 0.9.7.1
[ ] 0 No strong feeling either way
[ ] -1 do not release one or both packages because ...

Thanks!

Re: [VOTE] Release Apache AsterixDB JDBC Connector 0.9.7.1 (RC1)

Posted by Dmitry Lychagin <dm...@couchbase.com.INVALID>.
+1. Verified driver with DbVisualizer and DBeaver.

Also checked LICENSE and NOTICE files.

Thanks,
-- Dmitry
 

On 2/24/22, 11:52 PM, "Ian Maxon" <im...@uci.edu> wrote:

     EXTERNAL EMAIL:  Use caution when opening attachments or clicking on links





    Hi everyone,

    Please verify and vote on the first release of the AsterixDB JDBC connector.

    This release candidate fixes some issues with license files that were present
    in RC0 as well as simplifying the list of artifacts.

    The change that produced this release is up on Gerrit:

    https://asterix-gerrit.ics.uci.edu/c/asterixdb-clients/+/15444

    The release artifacts are as follows:

    JDBC Driver Source
    https://dist.apache.org/repos/dist/dev/asterixdb/apache-asterixdb-jdbc-0.9.7.1-source-release.zip
    https://dist.apache.org/repos/dist/dev/asterixdb/apache-asterixdb-jdbc-0.9.7.1-source-release.zip.asc
    https://dist.apache.org/repos/dist/dev/asterixdb/apache-asterixdb-jdbc-0.9.7.1-source-release.zip.sha512

    SHA512: b851a73bfd3da0cd7c17d3c4247a924ecd85c5138bab3f36f813109db38918f3f2993a75f57ae4b7d532719b01d7cb3c9fcfdd0de0dbd47452e9394d01ff5441⏎

    JDBC Driver Distributable Jar
    https://dist.apache.org/repos/dist/dev/asterixdb/asterix-jdbc-driver-0.9.7.1-dist.jar
    https://dist.apache.org/repos/dist/dev/asterixdb/asterix-jdbc-driver-0.9.7.1-dist.jar.asc
    https://dist.apache.org/repos/dist/dev/asterixdb/asterix-jdbc-driver-0.9.7.1-dist.jar.sha512

    SHA512: c7184054958dffb280de51fc472c4f94e218b2d67435fae73a10663a46d8fc06c607da520facbd4c8ba159b0e7339a23e64079361bff2f9e4ef3c76a2a900df1

    Tableau Connector (TACO file)
    https://dist.apache.org/repos/dist/dev/asterixdb/asterixdb_jdbc.taco
    https://dist.apache.org/repos/dist/dev/asterixdb/asterixdb_jdbc.taco.asc
    https://dist.apache.org/repos/dist/dev/asterixdb/asterixdb_jdbc.taco.sha512

    SHA512: 2538bd8e5266c280a0ff3de7bdb7e262d7963207181a8bfba3bb852c1c9c3820ea3495e68e4e31038e18542f01891ae2734007e29aea74219e7c1896d0807321


    The KEYS file containing the PGP keys used to sign the release can be
    found at

    https://dist.apache.org/repos/dist/release/asterixdb/KEYS

    RAT was executed as part of Maven via the RAT maven plugin, but
    excludes files that are:

    - data for tests
    - procedurally generated,
    - or source files which come without a header mentioning their license,
      but have an explicit reference in the LICENSE file.


    The vote is open for 72 hours, or until the necessary number of votes
    (3 +1) has been reached.

    Please vote
    [ ] +1 release these packages as Apache AsterixDB JDBC Driver 0.9.7.1
    [ ] 0 No strong feeling either way
    [ ] -1 do not release one or both packages because ...

    Thanks!


Re: [VOTE] Release Apache AsterixDB JDBC Connector 0.9.7.1 (RC1)

Posted by Ian Maxon <im...@uci.edu>.
The vote for releasing Apache AsterixDB JDBC Connector 0.9.7.1
with 4 +1's (4 binding) and no 0's or -1s.

Permalink to vote thread:
https://lists.apache.org/thread/mm0bnf357flsrlw91qfdb4rd39rnh1xv

PMC Members & Committers (binding):
+1 [4]
 0 [0]
-1 [0]


Voting Record:

Dmitry Lychagin:   +1
Till Westmann:      +1
Taewoo Kim:         +1
Mike Carey:         +1


Thanks for voting and reviewing the release, everyone.

On Mon, Feb 28, 2022 at 11:32 PM Mike Carey <dt...@gmail.com> wrote:
>
> +1
>
> Downloaded driver and set it up in dbvisualizer and ran a SQL join query
> against DonCData-based views.
>
> On 2/25/22 2:52 AM, Ian Maxon wrote:
> > Hi everyone,
> >
> > Please verify and vote on the first release of the AsterixDB JDBC connector.
> >
> > This release candidate fixes some issues with license files that were present
> > in RC0 as well as simplifying the list of artifacts.
> >
> > The change that produced this release is up on Gerrit:
> >
> > https://asterix-gerrit.ics.uci.edu/c/asterixdb-clients/+/15444
> >
> > The release artifacts are as follows:
> >
> > JDBC Driver Source
> > https://dist.apache.org/repos/dist/dev/asterixdb/apache-asterixdb-jdbc-0.9.7.1-source-release.zip
> > https://dist.apache.org/repos/dist/dev/asterixdb/apache-asterixdb-jdbc-0.9.7.1-source-release.zip.asc
> > https://dist.apache.org/repos/dist/dev/asterixdb/apache-asterixdb-jdbc-0.9.7.1-source-release.zip.sha512
> >
> > SHA512: b851a73bfd3da0cd7c17d3c4247a924ecd85c5138bab3f36f813109db38918f3f2993a75f57ae4b7d532719b01d7cb3c9fcfdd0de0dbd47452e9394d01ff5441⏎
> >
> > JDBC Driver Distributable Jar
> > https://dist.apache.org/repos/dist/dev/asterixdb/asterix-jdbc-driver-0.9.7.1-dist.jar
> > https://dist.apache.org/repos/dist/dev/asterixdb/asterix-jdbc-driver-0.9.7.1-dist.jar.asc
> > https://dist.apache.org/repos/dist/dev/asterixdb/asterix-jdbc-driver-0.9.7.1-dist.jar.sha512
> >
> > SHA512: c7184054958dffb280de51fc472c4f94e218b2d67435fae73a10663a46d8fc06c607da520facbd4c8ba159b0e7339a23e64079361bff2f9e4ef3c76a2a900df1
> >
> > Tableau Connector (TACO file)
> > https://dist.apache.org/repos/dist/dev/asterixdb/asterixdb_jdbc.taco
> > https://dist.apache.org/repos/dist/dev/asterixdb/asterixdb_jdbc.taco.asc
> > https://dist.apache.org/repos/dist/dev/asterixdb/asterixdb_jdbc.taco.sha512
> >
> > SHA512: 2538bd8e5266c280a0ff3de7bdb7e262d7963207181a8bfba3bb852c1c9c3820ea3495e68e4e31038e18542f01891ae2734007e29aea74219e7c1896d0807321
> >
> >
> > The KEYS file containing the PGP keys used to sign the release can be
> > found at
> >
> > https://dist.apache.org/repos/dist/release/asterixdb/KEYS
> >
> > RAT was executed as part of Maven via the RAT maven plugin, but
> > excludes files that are:
> >
> > - data for tests
> > - procedurally generated,
> > - or source files which come without a header mentioning their license,
> >    but have an explicit reference in the LICENSE file.
> >
> >
> > The vote is open for 72 hours, or until the necessary number of votes
> > (3 +1) has been reached.
> >
> > Please vote
> > [ ] +1 release these packages as Apache AsterixDB JDBC Driver 0.9.7.1
> > [ ] 0 No strong feeling either way
> > [ ] -1 do not release one or both packages because ...
> >
> > Thanks!

Re: [VOTE] Release Apache AsterixDB JDBC Connector 0.9.7.1 (RC1)

Posted by Mike Carey <dt...@gmail.com>.
+1

Downloaded driver and set it up in dbvisualizer and ran a SQL join query 
against DonCData-based views.

On 2/25/22 2:52 AM, Ian Maxon wrote:
> Hi everyone,
>
> Please verify and vote on the first release of the AsterixDB JDBC connector.
>
> This release candidate fixes some issues with license files that were present
> in RC0 as well as simplifying the list of artifacts.
>
> The change that produced this release is up on Gerrit:
>
> https://asterix-gerrit.ics.uci.edu/c/asterixdb-clients/+/15444
>
> The release artifacts are as follows:
>
> JDBC Driver Source
> https://dist.apache.org/repos/dist/dev/asterixdb/apache-asterixdb-jdbc-0.9.7.1-source-release.zip
> https://dist.apache.org/repos/dist/dev/asterixdb/apache-asterixdb-jdbc-0.9.7.1-source-release.zip.asc
> https://dist.apache.org/repos/dist/dev/asterixdb/apache-asterixdb-jdbc-0.9.7.1-source-release.zip.sha512
>
> SHA512: b851a73bfd3da0cd7c17d3c4247a924ecd85c5138bab3f36f813109db38918f3f2993a75f57ae4b7d532719b01d7cb3c9fcfdd0de0dbd47452e9394d01ff5441⏎
>
> JDBC Driver Distributable Jar
> https://dist.apache.org/repos/dist/dev/asterixdb/asterix-jdbc-driver-0.9.7.1-dist.jar
> https://dist.apache.org/repos/dist/dev/asterixdb/asterix-jdbc-driver-0.9.7.1-dist.jar.asc
> https://dist.apache.org/repos/dist/dev/asterixdb/asterix-jdbc-driver-0.9.7.1-dist.jar.sha512
>
> SHA512: c7184054958dffb280de51fc472c4f94e218b2d67435fae73a10663a46d8fc06c607da520facbd4c8ba159b0e7339a23e64079361bff2f9e4ef3c76a2a900df1
>
> Tableau Connector (TACO file)
> https://dist.apache.org/repos/dist/dev/asterixdb/asterixdb_jdbc.taco
> https://dist.apache.org/repos/dist/dev/asterixdb/asterixdb_jdbc.taco.asc
> https://dist.apache.org/repos/dist/dev/asterixdb/asterixdb_jdbc.taco.sha512
>
> SHA512: 2538bd8e5266c280a0ff3de7bdb7e262d7963207181a8bfba3bb852c1c9c3820ea3495e68e4e31038e18542f01891ae2734007e29aea74219e7c1896d0807321
>
>
> The KEYS file containing the PGP keys used to sign the release can be
> found at
>
> https://dist.apache.org/repos/dist/release/asterixdb/KEYS
>
> RAT was executed as part of Maven via the RAT maven plugin, but
> excludes files that are:
>
> - data for tests
> - procedurally generated,
> - or source files which come without a header mentioning their license,
>    but have an explicit reference in the LICENSE file.
>
>
> The vote is open for 72 hours, or until the necessary number of votes
> (3 +1) has been reached.
>
> Please vote
> [ ] +1 release these packages as Apache AsterixDB JDBC Driver 0.9.7.1
> [ ] 0 No strong feeling either way
> [ ] -1 do not release one or both packages because ...
>
> Thanks!

Re: [VOTE] Release Apache AsterixDB JDBC Connector 0.9.7.1 (RC1)

Posted by Mike Carey <dt...@gmail.com>.
Will do by Monday!

On Thu, Feb 24, 2022 at 11:52 PM Ian Maxon <im...@uci.edu> wrote:

> Hi everyone,
>
> Please verify and vote on the first release of the AsterixDB JDBC
> connector.
>
> This release candidate fixes some issues with license files that were
> present
> in RC0 as well as simplifying the list of artifacts.
>
> The change that produced this release is up on Gerrit:
>
> https://asterix-gerrit.ics.uci.edu/c/asterixdb-clients/+/15444
>
> The release artifacts are as follows:
>
> JDBC Driver Source
>
> https://dist.apache.org/repos/dist/dev/asterixdb/apache-asterixdb-jdbc-0.9.7.1-source-release.zip
>
> https://dist.apache.org/repos/dist/dev/asterixdb/apache-asterixdb-jdbc-0.9.7.1-source-release.zip.asc
>
> https://dist.apache.org/repos/dist/dev/asterixdb/apache-asterixdb-jdbc-0.9.7.1-source-release.zip.sha512
>
> SHA512:
> b851a73bfd3da0cd7c17d3c4247a924ecd85c5138bab3f36f813109db38918f3f2993a75f57ae4b7d532719b01d7cb3c9fcfdd0de0dbd47452e9394d01ff5441⏎
>
> JDBC Driver Distributable Jar
>
> https://dist.apache.org/repos/dist/dev/asterixdb/asterix-jdbc-driver-0.9.7.1-dist.jar
>
> https://dist.apache.org/repos/dist/dev/asterixdb/asterix-jdbc-driver-0.9.7.1-dist.jar.asc
>
> https://dist.apache.org/repos/dist/dev/asterixdb/asterix-jdbc-driver-0.9.7.1-dist.jar.sha512
>
> SHA512:
> c7184054958dffb280de51fc472c4f94e218b2d67435fae73a10663a46d8fc06c607da520facbd4c8ba159b0e7339a23e64079361bff2f9e4ef3c76a2a900df1
>
> Tableau Connector (TACO file)
> https://dist.apache.org/repos/dist/dev/asterixdb/asterixdb_jdbc.taco
> https://dist.apache.org/repos/dist/dev/asterixdb/asterixdb_jdbc.taco.asc
> https://dist.apache.org/repos/dist/dev/asterixdb/asterixdb_jdbc.taco.sha512
>
> SHA512:
> 2538bd8e5266c280a0ff3de7bdb7e262d7963207181a8bfba3bb852c1c9c3820ea3495e68e4e31038e18542f01891ae2734007e29aea74219e7c1896d0807321
>
>
> The KEYS file containing the PGP keys used to sign the release can be
> found at
>
> https://dist.apache.org/repos/dist/release/asterixdb/KEYS
>
> RAT was executed as part of Maven via the RAT maven plugin, but
> excludes files that are:
>
> - data for tests
> - procedurally generated,
> - or source files which come without a header mentioning their license,
>   but have an explicit reference in the LICENSE file.
>
>
> The vote is open for 72 hours, or until the necessary number of votes
> (3 +1) has been reached.
>
> Please vote
> [ ] +1 release these packages as Apache AsterixDB JDBC Driver 0.9.7.1
> [ ] 0 No strong feeling either way
> [ ] -1 do not release one or both packages because ...
>
> Thanks!
>

Re: [VOTE] Release Apache AsterixDB JDBC Connector 0.9.7.1 (RC1)

Posted by Taewoo Kim <wa...@gmail.com>.
+1
Verified the driver with DbVisualizer


On Fri, Feb 25, 2022 at 10:28 AM Till Westmann <ti...@gmail.com>
wrote:

> +1
>
> Checked the source artifacts:
> - Signatures and hashes correct
> — LICENSE and NOTICE look ok
> - Source files have Apache header
> - No unexpected binary files (checked expected binary files)
> - Can compile from source
>
> Checked the Driver jar binary artifact:
> - Signatures and hashes correct
> — LICENSE and NOTICE look ok
>
>
> On 24 Feb 2022, at 23:52, Ian Maxon wrote:
>
> > Hi everyone,
> >
> > Please verify and vote on the first release of the AsterixDB JDBC
> > connector.
> >
> > This release candidate fixes some issues with license files that were
> > present
> > in RC0 as well as simplifying the list of artifacts.
> >
> > The change that produced this release is up on Gerrit:
> >
> > https://asterix-gerrit.ics.uci.edu/c/asterixdb-clients/+/15444
> >
> > The release artifacts are as follows:
> >
> > JDBC Driver Source
> >
> https://dist.apache.org/repos/dist/dev/asterixdb/apache-asterixdb-jdbc-0.9.7.1-source-release.zip
> >
> https://dist.apache.org/repos/dist/dev/asterixdb/apache-asterixdb-jdbc-0.9.7.1-source-release.zip.asc
> >
> https://dist.apache.org/repos/dist/dev/asterixdb/apache-asterixdb-jdbc-0.9.7.1-source-release.zip.sha512
> >
> > SHA512:
> >
> b851a73bfd3da0cd7c17d3c4247a924ecd85c5138bab3f36f813109db38918f3f2993a75f57ae4b7d532719b01d7cb3c9fcfdd0de0dbd47452e9394d01ff5441⏎
> >
> > JDBC Driver Distributable Jar
> >
> https://dist.apache.org/repos/dist/dev/asterixdb/asterix-jdbc-driver-0.9.7.1-dist.jar
> >
> https://dist.apache.org/repos/dist/dev/asterixdb/asterix-jdbc-driver-0.9.7.1-dist.jar.asc
> >
> https://dist.apache.org/repos/dist/dev/asterixdb/asterix-jdbc-driver-0.9.7.1-dist.jar.sha512
> >
> > SHA512:
> >
> c7184054958dffb280de51fc472c4f94e218b2d67435fae73a10663a46d8fc06c607da520facbd4c8ba159b0e7339a23e64079361bff2f9e4ef3c76a2a900df1
> >
> > Tableau Connector (TACO file)
> > https://dist.apache.org/repos/dist/dev/asterixdb/asterixdb_jdbc.taco
> > https://dist.apache.org/repos/dist/dev/asterixdb/asterixdb_jdbc.taco.asc
> >
> https://dist.apache.org/repos/dist/dev/asterixdb/asterixdb_jdbc.taco.sha512
> >
> > SHA512:
> >
> 2538bd8e5266c280a0ff3de7bdb7e262d7963207181a8bfba3bb852c1c9c3820ea3495e68e4e31038e18542f01891ae2734007e29aea74219e7c1896d0807321
> >
> >
> > The KEYS file containing the PGP keys used to sign the release can be
> > found at
> >
> > https://dist.apache.org/repos/dist/release/asterixdb/KEYS
> >
> > RAT was executed as part of Maven via the RAT maven plugin, but
> > excludes files that are:
> >
> > - data for tests
> > - procedurally generated,
> > - or source files which come without a header mentioning their
> > license,
> >   but have an explicit reference in the LICENSE file.
> >
> >
> > The vote is open for 72 hours, or until the necessary number of votes
> > (3 +1) has been reached.
> >
> > Please vote
> > [ ] +1 release these packages as Apache AsterixDB JDBC Driver 0.9.7.1
> > [ ] 0 No strong feeling either way
> > [ ] -1 do not release one or both packages because ...
> >
> > Thanks!
>

Re: [VOTE] Release Apache AsterixDB JDBC Connector 0.9.7.1 (RC1)

Posted by Till Westmann <ti...@gmail.com>.
+1

Checked the source artifacts:
- Signatures and hashes correct
— LICENSE and NOTICE look ok
- Source files have Apache header
- No unexpected binary files (checked expected binary files)
- Can compile from source

Checked the Driver jar binary artifact:
- Signatures and hashes correct
— LICENSE and NOTICE look ok


On 24 Feb 2022, at 23:52, Ian Maxon wrote:

> Hi everyone,
>
> Please verify and vote on the first release of the AsterixDB JDBC 
> connector.
>
> This release candidate fixes some issues with license files that were 
> present
> in RC0 as well as simplifying the list of artifacts.
>
> The change that produced this release is up on Gerrit:
>
> https://asterix-gerrit.ics.uci.edu/c/asterixdb-clients/+/15444
>
> The release artifacts are as follows:
>
> JDBC Driver Source
> https://dist.apache.org/repos/dist/dev/asterixdb/apache-asterixdb-jdbc-0.9.7.1-source-release.zip
> https://dist.apache.org/repos/dist/dev/asterixdb/apache-asterixdb-jdbc-0.9.7.1-source-release.zip.asc
> https://dist.apache.org/repos/dist/dev/asterixdb/apache-asterixdb-jdbc-0.9.7.1-source-release.zip.sha512
>
> SHA512: 
> b851a73bfd3da0cd7c17d3c4247a924ecd85c5138bab3f36f813109db38918f3f2993a75f57ae4b7d532719b01d7cb3c9fcfdd0de0dbd47452e9394d01ff5441⏎
>
> JDBC Driver Distributable Jar
> https://dist.apache.org/repos/dist/dev/asterixdb/asterix-jdbc-driver-0.9.7.1-dist.jar
> https://dist.apache.org/repos/dist/dev/asterixdb/asterix-jdbc-driver-0.9.7.1-dist.jar.asc
> https://dist.apache.org/repos/dist/dev/asterixdb/asterix-jdbc-driver-0.9.7.1-dist.jar.sha512
>
> SHA512: 
> c7184054958dffb280de51fc472c4f94e218b2d67435fae73a10663a46d8fc06c607da520facbd4c8ba159b0e7339a23e64079361bff2f9e4ef3c76a2a900df1
>
> Tableau Connector (TACO file)
> https://dist.apache.org/repos/dist/dev/asterixdb/asterixdb_jdbc.taco
> https://dist.apache.org/repos/dist/dev/asterixdb/asterixdb_jdbc.taco.asc
> https://dist.apache.org/repos/dist/dev/asterixdb/asterixdb_jdbc.taco.sha512
>
> SHA512: 
> 2538bd8e5266c280a0ff3de7bdb7e262d7963207181a8bfba3bb852c1c9c3820ea3495e68e4e31038e18542f01891ae2734007e29aea74219e7c1896d0807321
>
>
> The KEYS file containing the PGP keys used to sign the release can be
> found at
>
> https://dist.apache.org/repos/dist/release/asterixdb/KEYS
>
> RAT was executed as part of Maven via the RAT maven plugin, but
> excludes files that are:
>
> - data for tests
> - procedurally generated,
> - or source files which come without a header mentioning their 
> license,
>   but have an explicit reference in the LICENSE file.
>
>
> The vote is open for 72 hours, or until the necessary number of votes
> (3 +1) has been reached.
>
> Please vote
> [ ] +1 release these packages as Apache AsterixDB JDBC Driver 0.9.7.1
> [ ] 0 No strong feeling either way
> [ ] -1 do not release one or both packages because ...
>
> Thanks!