You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "ottlinger (via GitHub)" <gi...@apache.org> on 2024/11/07 19:27:32 UTC

[PR] DOXIASITETOOLS-356: Provide more context in error message [maven-doxia-sitetools]

ottlinger opened a new pull request, #184:
URL: https://github.com/apache/maven-doxia-sitetools/pull/184

   Provide more context when version mismatches arise during doxia migration
   
   @michael-o hope this text change can go through.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] DOXIASITETOOLS-356: Provide more context in error message [maven-doxia-sitetools]

Posted by "ottlinger (via GitHub)" <gi...@apache.org>.
ottlinger commented on PR #184:
URL: https://github.com/apache/maven-doxia-sitetools/pull/184#issuecomment-2544004454

   Any help I can provide in getting in this textual change? @michael-o ping :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] DOXIASITETOOLS-356: Provide more context in error message [maven-doxia-sitetools]

Posted by "ottlinger (via GitHub)" <gi...@apache.org>.
ottlinger commented on code in PR #184:
URL: https://github.com/apache/maven-doxia-sitetools/pull/184#discussion_r1953159702


##########
doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java:
##########
@@ -700,8 +700,9 @@ public SiteRenderingContext createContextForSkin(
                 if (StringUtils.isNotBlank(toolsPrerequisite)
                         && (current != null)
                         && !matchVersion(current, toolsPrerequisite)) {
-                    throw new RendererException("Cannot use skin: has " + toolsPrerequisite
-                            + " Doxia Sitetools prerequisite, but current is " + current);
+                    throw new RendererException("Cannot use skin as it needs " + toolsPrerequisite
+                            + " Doxia Sitetools, but your configuration uses " + current + "."
+                            + "Check your version setup of plugins and skins to use the same doxia stack.");

Review Comment:
   I ran into this error as my combination of site-plugin-version and skin version did not match. It's not only a matter of the skin, but I will open a new PR with the changes you proposed and we'll see if that gets merged. Thanks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] DOXIASITETOOLS-356: Provide more context in error message [maven-doxia-sitetools]

Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on code in PR #184:
URL: https://github.com/apache/maven-doxia-sitetools/pull/184#discussion_r1952582357


##########
doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java:
##########
@@ -700,8 +700,9 @@ public SiteRenderingContext createContextForSkin(
                 if (StringUtils.isNotBlank(toolsPrerequisite)
                         && (current != null)
                         && !matchVersion(current, toolsPrerequisite)) {
-                    throw new RendererException("Cannot use skin: has " + toolsPrerequisite
-                            + " Doxia Sitetools prerequisite, but current is " + current);
+                    throw new RendererException("Cannot use skin as it needs " + toolsPrerequisite
+                            + " Doxia Sitetools, but your configuration uses " + current + "."
+                            + "Check your version setup of plugins and skins to use the same doxia stack.");

Review Comment:
   Not bad, after all.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] DOXIASITETOOLS-356: Provide more context in error message [maven-doxia-sitetools]

Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #184:
URL: https://github.com/apache/maven-doxia-sitetools/pull/184#issuecomment-2482056524

   No time yet


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] DOXIASITETOOLS-356: Provide more context in error message [maven-doxia-sitetools]

Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #184:
URL: https://github.com/apache/maven-doxia-sitetools/pull/184#issuecomment-2544012016

   Low priority for me at the moment 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] DOXIASITETOOLS-356: Provide more context in error message [maven-doxia-sitetools]

Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on code in PR #184:
URL: https://github.com/apache/maven-doxia-sitetools/pull/184#discussion_r1952574944


##########
doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java:
##########
@@ -700,8 +700,9 @@ public SiteRenderingContext createContextForSkin(
                 if (StringUtils.isNotBlank(toolsPrerequisite)
                         && (current != null)
                         && !matchVersion(current, toolsPrerequisite)) {
-                    throw new RendererException("Cannot use skin: has " + toolsPrerequisite
-                            + " Doxia Sitetools prerequisite, but current is " + current);
+                    throw new RendererException("Cannot use skin as it needs " + toolsPrerequisite
+                            + " Doxia Sitetools, but your configuration uses " + current + "."
+                            + "Check your version setup of plugins and skins to use the same doxia stack.");

Review Comment:
   WDYT about "Your current Doxia Sitetools version " + current + " does not match the requirements of the skin (" + toolsPrerequisite + "). In order to fix this choose a skin version which is compatible with this Doxia Sitetools version."



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] DOXIASITETOOLS-356: Provide more context in error message [maven-doxia-sitetools]

Posted by "ottlinger (via GitHub)" <gi...@apache.org>.
ottlinger closed pull request #184: DOXIASITETOOLS-356: Provide more context in error message
URL: https://github.com/apache/maven-doxia-sitetools/pull/184


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] DOXIASITETOOLS-356: Provide more context in error message [maven-doxia-sitetools]

Posted by "ottlinger (via GitHub)" <gi...@apache.org>.
ottlinger commented on PR #184:
URL: https://github.com/apache/maven-doxia-sitetools/pull/184#issuecomment-2654475436

   Applied proposed changes in https://github.com/apache/maven-doxia-sitetools/pull/192


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org