You are viewing a plain text version of this content. The canonical link for it is here.
Posted to test-dev@httpd.apache.org by Randy Kobes <ra...@theoryx5.uwinnipeg.ca> on 2004/01/07 05:00:59 UTC
Re: sticky preferences in Apache-Test
On Tue, 6 Jan 2004, Stas Bekman wrote:
> OK, here is a an extended version of Randy's original work
> to be able to save and reuse A-T config. I've added first
> time interactive configuration feature (similar to
> CPAN.pm). It took me a long time to polish it as there are
> so many possible cases on how this new feature can be
> used, it was pretty tricky. I haven't quite tested -save
> too. Also there could be some issues with win32, I'm sure
> Randy will post a fix. It's a pretty big patch, let me
> know if you want me to commit it and we will take it from
> there, making it easier to users to test it. We probably
> need to polish it somewhat.
Great work, Stas! This is a deceptively tricky problem ...
I for one would find it really convenient if you could
commit it and work on it from there - I have trouble with
longish patches getting them onto my Win32 system.
--
best regards,
randy
Re: sticky preferences in Apache-Test
Posted by Geoffrey Young <ge...@modperlcookbook.org>.
> Are you sure that your not problem is elsewhere?
I have no idea where it's tripping up. here's my nightly build process:
1 - nuke all Apache foo from my perls
$ find /perl/ -name "Apache*" -exec sudo rm -rf {} \;
2 - nuke my apache installs
3 - build each apache
4 - cd mod_perl-2.0 && make realclean && perl Makefile.PL MP_APXS=...
so, essentially I'm starting from a fresh @INC at the start of each night.
but it chokes when apache moves from 2.1 to 2.0, since the binaries are
incompatable. in reality, though, it's probably not using the right httpd
for any but the first iteration.
but even if it is "user error" on my part, I _still_ haven't found a way to
fix it short of purging my entire system of TestConfigData.pm files. and we
shouldn't need to expect users to do this when they upgrade mod_perl or
decide to build mod_perl against a different apache - right now both appear
to be broken.
--Geoff
Re: sticky preferences in Apache-Test
Posted by Stas Bekman <st...@stason.org>.
Randy Kobes wrote:
> On Sat, 17 Jan 2004, Stas Bekman wrote:
>
>
>>Randy Kobes wrote:
>
> [ ... ]
>
>>>I don't have an ~/.apache-test/, and yes, using the perl
>>>with the CPAN A-T installed to build the cvs A-T is fine.
>>>Where I run into problems in not seeing the configuration
>>>dialogue is using the perl with the cvs A-T installed in
>>>building the cvs A-T, even if I delete the installed
>>>TestConfigData.pm.
>>
>>That's the correct behavior at the moment, because you
>>have mp2 installed. If mp2 is found it has
>>Apache/BuildConfig.pm which tells A-T where httpd is. And
>>A-T will save that value in the global
>>Apache/TestConfigData.pm if it can write to it, or in
>>~/.apache-test/.'
>>
>>Of course we can change that behavior, but I think it's
>>cool as mp2 users will never see that interactive dialog.
>
>
> That is neat - I was just wondering where A-T was finding
> this information from. I'd leave that as is - thanks.
That feature was in A-T for about 2 years I think. I've removed it when I did
the first iteration of custom config, but then immediately added it back,
since it was silly to call an interactive config when you could avoid it.
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
Re: sticky preferences in Apache-Test
Posted by Randy Kobes <ra...@theoryx5.uwinnipeg.ca>.
On Sat, 17 Jan 2004, Stas Bekman wrote:
> Randy Kobes wrote:
[ ... ]
> > I don't have an ~/.apache-test/, and yes, using the perl
> > with the CPAN A-T installed to build the cvs A-T is fine.
> > Where I run into problems in not seeing the configuration
> > dialogue is using the perl with the cvs A-T installed in
> > building the cvs A-T, even if I delete the installed
> > TestConfigData.pm.
>
> That's the correct behavior at the moment, because you
> have mp2 installed. If mp2 is found it has
> Apache/BuildConfig.pm which tells A-T where httpd is. And
> A-T will save that value in the global
> Apache/TestConfigData.pm if it can write to it, or in
> ~/.apache-test/.'
>
> Of course we can change that behavior, but I think it's
> cool as mp2 users will never see that interactive dialog.
That is neat - I was just wondering where A-T was finding
this information from. I'd leave that as is - thanks.
--
best regards,
randy
Re: sticky preferences in Apache-Test
Posted by Stas Bekman <st...@stason.org>.
Randy Kobes wrote:
> On Tue, 13 Jan 2004, Stas Bekman wrote:
>
>
>>Randy Kobes wrote:
>>
>>>I haven't worked through this yet, but I find a similar
>>>problem ... I have two Perls, both of which have mp2
>>>installed, but one has the CPAN Apache-Test and the other
>>>has the cvs Apache-Test installed. In building the
>>>cvs Apache-Test, I get the first-time dialogue with
>>>the perl with the CPAN Apache-Test installed, but don't
>>>get the dialogue with the perl with the cvs Apache-Test
>>>installed. I'm a bit baffled as to why, as this occurs
>>>even if I delete the system TestConfigData.pm.
>>
>>But CPAN A-T doesn't have this feature, so you must have
>>installed mp2-cvs on top of it. Also check that you don't
>>have ~/.apache-test/.
>
>
> I don't have an ~/.apache-test/, and yes, using the perl
> with the CPAN A-T installed to build the cvs A-T is fine.
> Where I run into problems in not seeing the configuration
> dialogue is using the perl with the cvs A-T installed in
> building the cvs A-T, even if I delete the installed
> TestConfigData.pm.
That's the correct behavior at the moment, because you have mp2 installed. If
mp2 is found it has Apache/BuildConfig.pm which tells A-T where httpd is. And
A-T will save that value in the global Apache/TestConfigData.pm if it can
write to it, or in ~/.apache-test/.'
Of course we can change that behavior, but I think it's cool as mp2 users will
never see that interactive dialog.
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
Re: sticky preferences in Apache-Test
Posted by Randy Kobes <ra...@theoryx5.uwinnipeg.ca>.
On Tue, 13 Jan 2004, Stas Bekman wrote:
> Randy Kobes wrote:
> >
> > I haven't worked through this yet, but I find a similar
> > problem ... I have two Perls, both of which have mp2
> > installed, but one has the CPAN Apache-Test and the other
> > has the cvs Apache-Test installed. In building the
> > cvs Apache-Test, I get the first-time dialogue with
> > the perl with the CPAN Apache-Test installed, but don't
> > get the dialogue with the perl with the cvs Apache-Test
> > installed. I'm a bit baffled as to why, as this occurs
> > even if I delete the system TestConfigData.pm.
>
> But CPAN A-T doesn't have this feature, so you must have
> installed mp2-cvs on top of it. Also check that you don't
> have ~/.apache-test/.
I don't have an ~/.apache-test/, and yes, using the perl
with the CPAN A-T installed to build the cvs A-T is fine.
Where I run into problems in not seeing the configuration
dialogue is using the perl with the cvs A-T installed in
building the cvs A-T, even if I delete the installed
TestConfigData.pm.
--
best regards,
randy
Re: sticky preferences in Apache-Test
Posted by Stas Bekman <st...@stason.org>.
Randy Kobes wrote:
> On Tue, 13 Jan 2004, Stas Bekman wrote:
>
>
>>Geoffrey Young wrote:
>
> [ ... ]
>
>>>what I do know, however, is that my nightly builds start
>>>with 2.1 then move to 2.0, issuing 'make realclean'
>>>between each. for the past few nights, the 2.0 tests
>>>don't run because it's loading TestConfigData.pm from my
>>>global @INC. at that point, TestConfigData.pm is from
>>>the last install, which is a 2.1 install.
>>>
>>>this seems wrong to me - I have no remedy short of removing
>>>TestDataConfig.pm between builds - at I think it would affect users that
>>>upgrade as well.
>>
>>Are you sure that your not problem is elsewhere? I see
>>this issue too though with non-mp2 build, just didn't have
>>a chance to work on it yet.
>>
>>How do you build your mp2? It should ignore the custom
>>config already, there must be some glitch.
>
>
> I haven't worked through this yet, but I find a similar
> problem ... I have two Perls, both of which have mp2
> installed, but one has the CPAN Apache-Test and the other
> has the cvs Apache-Test installed. In building the
> cvs Apache-Test, I get the first-time dialogue with
> the perl with the CPAN Apache-Test installed, but don't
> get the dialogue with the perl with the cvs Apache-Test
> installed. I'm a bit baffled as to why, as this occurs
> even if I delete the system TestConfigData.pm.
But CPAN A-T doesn't have this feature, so you must have installed mp2-cvs on
top of it. Also check that you don't have ~/.apache-test/.
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
Re: sticky preferences in Apache-Test
Posted by Randy Kobes <ra...@theoryx5.uwinnipeg.ca>.
On Tue, 13 Jan 2004, Stas Bekman wrote:
> Geoffrey Young wrote:
[ ... ]
> > what I do know, however, is that my nightly builds start
> > with 2.1 then move to 2.0, issuing 'make realclean'
> > between each. for the past few nights, the 2.0 tests
> > don't run because it's loading TestConfigData.pm from my
> > global @INC. at that point, TestConfigData.pm is from
> > the last install, which is a 2.1 install.
> >
> > this seems wrong to me - I have no remedy short of removing
> > TestDataConfig.pm between builds - at I think it would affect users that
> > upgrade as well.
>
> Are you sure that your not problem is elsewhere? I see
> this issue too though with non-mp2 build, just didn't have
> a chance to work on it yet.
>
> How do you build your mp2? It should ignore the custom
> config already, there must be some glitch.
I haven't worked through this yet, but I find a similar
problem ... I have two Perls, both of which have mp2
installed, but one has the CPAN Apache-Test and the other
has the cvs Apache-Test installed. In building the
cvs Apache-Test, I get the first-time dialogue with
the perl with the CPAN Apache-Test installed, but don't
get the dialogue with the perl with the cvs Apache-Test
installed. I'm a bit baffled as to why, as this occurs
even if I delete the system TestConfigData.pm.
--
best regards,
randy
Re: sticky preferences in Apache-Test
Posted by Stas Bekman <st...@stason.org>.
Geoffrey Young wrote:
>
> Stas Bekman wrote:
>
>>Geoffrey Young wrote:
>>
>>
>>>>I think the patch below handles that fine for any mp2 builds.
>>>
>>>
>>>
>>>I've done some more digging - this patch seems to be required.
>>
>>
>>How does it map on the thought from my previous email:
>>
>>"Let's see if we can stay without making a modperl-2.0 build special.
>>Why? Because it should use the modperl-2.0 build args for any 3rd party
>>modules A-T runs, if it's installed and used. So it's really the same as
>>modperl-2.0's "make test". "
>
>
> I can't really grok what you mean here.
>
> what I do know, however, is that my nightly builds start with 2.1 then move
> to 2.0, issuing 'make realclean' between each. for the past few nights, the
> 2.0 tests don't run because it's loading TestConfigData.pm from my global
> @INC. at that point, TestConfigData.pm is from the last install, which is a
> 2.1 install.
>
> this seems wrong to me - I have no remedy short of removing
> TestDataConfig.pm between builds - at I think it would affect users that
> upgrade as well.
Are you sure that your not problem is elsewhere? I see this issue too though
with non-mp2 build, just didn't have a chance to work on it yet.
How do you build your mp2? It should ignore the custom config already, there
must be some glitch.
I'm going to complete the Apache manpages generation and then work on it.
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
Re: sticky preferences in Apache-Test
Posted by Geoffrey Young <ge...@modperlcookbook.org>.
Stas Bekman wrote:
> Geoffrey Young wrote:
>
>>> I think the patch below handles that fine for any mp2 builds.
>>
>>
>>
>> I've done some more digging - this patch seems to be required.
>
>
> How does it map on the thought from my previous email:
>
> "Let's see if we can stay without making a modperl-2.0 build special.
> Why? Because it should use the modperl-2.0 build args for any 3rd party
> modules A-T runs, if it's installed and used. So it's really the same as
> modperl-2.0's "make test". "
I can't really grok what you mean here.
what I do know, however, is that my nightly builds start with 2.1 then move
to 2.0, issuing 'make realclean' between each. for the past few nights, the
2.0 tests don't run because it's loading TestConfigData.pm from my global
@INC. at that point, TestConfigData.pm is from the last install, which is a
2.1 install.
this seems wrong to me - I have no remedy short of removing
TestDataConfig.pm between builds - at I think it would affect users that
upgrade as well.
HTH
--Geoff
Re: sticky preferences in Apache-Test
Posted by Stas Bekman <st...@stason.org>.
Geoffrey Young wrote:
>>I think the patch below handles that fine for any mp2 builds.
>
>
> I've done some more digging - this patch seems to be required.
How does it map on the thought from my previous email:
"Let's see if we can stay without making a modperl-2.0 build special. Why?
Because it should use the modperl-2.0 build args for any 3rd party modules A-T
runs, if it's installed and used. So it's really the same as modperl-2.0's
"make test". "
>>Index: lib/Apache/TestRun.pm
>>===================================================================
>>RCS file:
>>/home/cvs/httpd-test/perl-framework/Apache-Test/lib/Apache/TestRun.pm,v
>>retrieving revision 1.135
>>diff -u -r1.135 TestRun.pm
>>--- lib/Apache/TestRun.pm 8 Jan 2004 04:54:06 -0000 1.135
>>+++ lib/Apache/TestRun.pm 8 Jan 2004 21:07:01 -0000
>>@@ -1291,6 +1291,11 @@
>> sub custom_config_load {
>> debug "trying to load custom config data";
>>
>>+ if (Apache::TestConfig::IS_MOD_PERL_2_BUILD()) {
>>+ debug "modperl-2.0 build - ignore any custom config data";
>>+ return;
>>+ }
>>+
>> if (my $custom_config_path = custom_config_path()) {
>> debug "loading custom config path '$custom_config_path'";
>>
>
>
--
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
Re: sticky preferences in Apache-Test
Posted by Geoffrey Young <ge...@modperlcookbook.org>.
>
> I think the patch below handles that fine for any mp2 builds.
I've done some more digging - this patch seems to be required.
--Geoff
>
> Index: lib/Apache/TestRun.pm
> ===================================================================
> RCS file:
> /home/cvs/httpd-test/perl-framework/Apache-Test/lib/Apache/TestRun.pm,v
> retrieving revision 1.135
> diff -u -r1.135 TestRun.pm
> --- lib/Apache/TestRun.pm 8 Jan 2004 04:54:06 -0000 1.135
> +++ lib/Apache/TestRun.pm 8 Jan 2004 21:07:01 -0000
> @@ -1291,6 +1291,11 @@
> sub custom_config_load {
> debug "trying to load custom config data";
>
> + if (Apache::TestConfig::IS_MOD_PERL_2_BUILD()) {
> + debug "modperl-2.0 build - ignore any custom config data";
> + return;
> + }
> +
> if (my $custom_config_path = custom_config_path()) {
> debug "loading custom config path '$custom_config_path'";
>
Re: sticky preferences in Apache-Test
Posted by Stas Bekman <st...@stason.org>.
Geoffrey Young wrote:
>>Can you please run t/TEST -debug=trace and see which TestConfigData.pm
>>is loaded? what's inside of it? May be the simple solution is not to
>>load custom_config when running from inside modperl-2.0? I think that's
>>the best solution.
>
>
> I've already cleaned everything out for today, but I'll do that tomorrow
> after my nightly builds run.
Try with the patch below. I haven't tested it, without having your debug input.
>>The problem is that we have 4 TestConfigData.pm files. If you are inside
>>modperl-2.0 or Apache-Test, you have one in lib and one in blib, the one
>>in lib is created as an empty config during 'perl Makefile.PL' then it's
>>copied to blib. Things gets complicated when you have a global
>>TestConfigData.pm installed and when you have ~/.apache-test one
>>installed. It gets very tricky.
>
>
> no doubt :)
>
> it is possible to have a makepl_args.mod_perl2 setting whereby using saved
> settings is skipped altogether? with all the builds that we both do
> nightly, that's the way I'd prefer to do at least infers from the build
> enviroment at the moment.
I think the patch below handles that fine for any mp2 builds.
Index: lib/Apache/TestRun.pm
===================================================================
RCS file: /home/cvs/httpd-test/perl-framework/Apache-Test/lib/Apache/TestRun.pm,v
retrieving revision 1.135
diff -u -r1.135 TestRun.pm
--- lib/Apache/TestRun.pm 8 Jan 2004 04:54:06 -0000 1.135
+++ lib/Apache/TestRun.pm 8 Jan 2004 21:07:01 -0000
@@ -1291,6 +1291,11 @@
sub custom_config_load {
debug "trying to load custom config data";
+ if (Apache::TestConfig::IS_MOD_PERL_2_BUILD()) {
+ debug "modperl-2.0 build - ignore any custom config data";
+ return;
+ }
+
if (my $custom_config_path = custom_config_path()) {
debug "loading custom config path '$custom_config_path'";
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
Re: sticky preferences in Apache-Test
Posted by Geoffrey Young <ge...@modperlcookbook.org>.
> Can you please run t/TEST -debug=trace and see which TestConfigData.pm
> is loaded? what's inside of it? May be the simple solution is not to
> load custom_config when running from inside modperl-2.0? I think that's
> the best solution.
I've already cleaned everything out for today, but I'll do that tomorrow
after my nightly builds run.
>
> The problem is that we have 4 TestConfigData.pm files. If you are inside
> modperl-2.0 or Apache-Test, you have one in lib and one in blib, the one
> in lib is created as an empty config during 'perl Makefile.PL' then it's
> copied to blib. Things gets complicated when you have a global
> TestConfigData.pm installed and when you have ~/.apache-test one
> installed. It gets very tricky.
no doubt :)
it is possible to have a makepl_args.mod_perl2 setting whereby using saved
settings is skipped altogether? with all the builds that we both do
nightly, that's the way I'd prefer to do at least infers from the build
enviroment at the moment.
--Geoff
Re: sticky preferences in Apache-Test
Posted by Stas Bekman <st...@stason.org>.
Geoffrey Young wrote:
>>>$ perl Makefile.PL MP_APXS=/apache/2.1/prefork/perl-5.8.2/bin/apxs
>>>...
>>>Configuring Apache/2.1.0-dev mod_perl/1.99_13-dev Perl/v5.8.2
>>>
>>>$ make && make test
>>>...
>>>using Apache/2.0.49-dev (prefork MPM)
>>>
>>>waiting 120 seconds for server to start: .httpd: module "mod_perl.c"
>>>is not
>>>compatible with this version of Apache (found 20030821, need 20020903).
>
>
> this seems to have gone away - it must have been a result of some stuff left
> over from a previous implementation.
You mean it wasn't 'cvs up'ed?
Let's see if we can stay without making a modperl-2.0 build special. Why?
Because it should use the modperl-2.0 build args for any 3rd party modules A-T
runs, if it's installed and used. So it's really the same as modperl-2.0's
"make test".
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
Re: sticky preferences in Apache-Test
Posted by Geoffrey Young <ge...@modperlcookbook.org>.
>>
>> $ perl Makefile.PL MP_APXS=/apache/2.1/prefork/perl-5.8.2/bin/apxs
>> ...
>> Configuring Apache/2.1.0-dev mod_perl/1.99_13-dev Perl/v5.8.2
>>
>> $ make && make test
>> ...
>> using Apache/2.0.49-dev (prefork MPM)
>>
>> waiting 120 seconds for server to start: .httpd: module "mod_perl.c"
>> is not
>> compatible with this version of Apache (found 20030821, need 20020903).
this seems to have gone away - it must have been a result of some stuff left
over from a previous implementation.
--Geoff
Re: sticky preferences in Apache-Test
Posted by Stas Bekman <st...@stason.org>.
Geoffrey Young wrote:
>>Yes, thank you Geoff, I've noticed that too late. And my mail server was
>>down most of the day :(
>
>
> :)
>
>
>>I think I have fixed these problems now.
>>
>>What bothers me is the call to default_httpd, which may pick a wrong
>>server. So I've removed it. It is used in the interactive config, to
>>help user to find the right httpd.
>
>
> I'm not sure if this is related, but something is still amuck for me. it
> seems that TestConfigData.pm isn't being properly cleaned up on 'make
> realclean' or otherwise overwritten:
>
> $ perl Makefile.PL MP_APXS=/apache/2.1/prefork/perl-5.8.2/bin/apxs
> ...
> Configuring Apache/2.1.0-dev mod_perl/1.99_13-dev Perl/v5.8.2
>
> $ make && make test
> ...
> using Apache/2.0.49-dev (prefork MPM)
>
> waiting 120 seconds for server to start: .httpd: module "mod_perl.c" is not
> compatible with this version of Apache (found 20030821, need 20020903).
Can you please run t/TEST -debug=trace and see which TestConfigData.pm is
loaded? what's inside of it? May be the simple solution is not to load
custom_config when running from inside modperl-2.0? I think that's the best
solution.
The problem is that we have 4 TestConfigData.pm files. If you are inside
modperl-2.0 or Apache-Test, you have one in lib and one in blib, the one in
lib is created as an empty config during 'perl Makefile.PL' then it's copied
to blib. Things gets complicated when you have a global TestConfigData.pm
installed and when you have ~/.apache-test one installed. It gets very tricky.
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
Re: sticky preferences in Apache-Test
Posted by Geoffrey Young <ge...@modperlcookbook.org>.
> Yes, thank you Geoff, I've noticed that too late. And my mail server was
> down most of the day :(
:)
>
> I think I have fixed these problems now.
>
> What bothers me is the call to default_httpd, which may pick a wrong
> server. So I've removed it. It is used in the interactive config, to
> help user to find the right httpd.
I'm not sure if this is related, but something is still amuck for me. it
seems that TestConfigData.pm isn't being properly cleaned up on 'make
realclean' or otherwise overwritten:
$ perl Makefile.PL MP_APXS=/apache/2.1/prefork/perl-5.8.2/bin/apxs
...
Configuring Apache/2.1.0-dev mod_perl/1.99_13-dev Perl/v5.8.2
$ make && make test
...
using Apache/2.0.49-dev (prefork MPM)
waiting 120 seconds for server to start: .httpd: module "mod_perl.c" is not
compatible with this version of Apache (found 20030821, need 20020903).
--Geoff
Re: sticky preferences in Apache-Test
Posted by Stas Bekman <st...@stason.org>.
Geoffrey Young wrote:
>
> Geoffrey Young wrote:
>
>>>committed. looking forward to hear about the odd parts.
>>
>>
>>the first thing that strikes me is that when I build mod_perl with
>>MP_APXS=/foo/bin/apxs then make && make test I get the dialogue asking me to
>>choose httpd and apxs binaries.
>>
>>I don't think we want a prompt for the mod_perl test suite - it should be
>>obvious that I want to use the binaries I'm building mod_perl against.
>
>
> actually, it seems a bit worse than that - I'm stuck in an endless loop and
> the test suite never runs. hmph.
Yes, thank you Geoff, I've noticed that too late. And my mail server was down
most of the day :(
I think I have fixed these problems now.
What bothers me is the call to default_httpd, which may pick a wrong server.
So I've removed it. It is used in the interactive config, to help user to find
the right httpd.
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
Re: sticky preferences in Apache-Test
Posted by Geoffrey Young <ge...@modperlcookbook.org>.
Geoffrey Young wrote:
>>committed. looking forward to hear about the odd parts.
>
>
> the first thing that strikes me is that when I build mod_perl with
> MP_APXS=/foo/bin/apxs then make && make test I get the dialogue asking me to
> choose httpd and apxs binaries.
>
> I don't think we want a prompt for the mod_perl test suite - it should be
> obvious that I want to use the binaries I'm building mod_perl against.
actually, it seems a bit worse than that - I'm stuck in an endless loop and
the test suite never runs. hmph.
--Geoff
Re: sticky preferences in Apache-Test
Posted by Geoffrey Young <ge...@modperlcookbook.org>.
> committed. looking forward to hear about the odd parts.
the first thing that strikes me is that when I build mod_perl with
MP_APXS=/foo/bin/apxs then make && make test I get the dialogue asking me to
choose httpd and apxs binaries.
I don't think we want a prompt for the mod_perl test suite - it should be
obvious that I want to use the binaries I'm building mod_perl against.
--Geoff
Re: sticky preferences in Apache-Test
Posted by Stas Bekman <st...@stason.org>.
Geoffrey Young wrote:
>>But it's a pretty big change, so I'd like a few folks to look at it
>>before I do that. Meanwhile I've attached the same patch if it makes it
>>easier to patch your source.
>>
>>May be Geoff will chime in and I'll commit it then. He has a flu though :(
>
>
> I seem to be better now. thanks :)
>
> some of the patch seems odd, but it's hard for me to tell by looking at it.
> I'd say commit it and let people play with it for a while to see if it does
> what they want it to. we can just fix the issue that are bound to show up
> as they come.
committed. looking forward to hear about the odd parts. beware that the logic
is quite twisted. probably need better documentation (may be centralized).
> nice work guys.
thanks ;)
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
Re: sticky preferences in Apache-Test
Posted by Geoffrey Young <ge...@modperlcookbook.org>.
> But it's a pretty big change, so I'd like a few folks to look at it
> before I do that. Meanwhile I've attached the same patch if it makes it
> easier to patch your source.
>
> May be Geoff will chime in and I'll commit it then. He has a flu though :(
I seem to be better now. thanks :)
some of the patch seems odd, but it's hard for me to tell by looking at it.
I'd say commit it and let people play with it for a while to see if it does
what they want it to. we can just fix the issue that are bound to show up
as they come.
nice work guys.
--Geoff
Re: sticky preferences in Apache-Test
Posted by Stas Bekman <st...@stason.org>.
Randy Kobes wrote:
> On Tue, 6 Jan 2004, Stas Bekman wrote:
>
>
>>OK, here is a an extended version of Randy's original work
>>to be able to save and reuse A-T config. I've added first
>>time interactive configuration feature (similar to
>>CPAN.pm). It took me a long time to polish it as there are
>>so many possible cases on how this new feature can be
>>used, it was pretty tricky. I haven't quite tested -save
>>too. Also there could be some issues with win32, I'm sure
>>Randy will post a fix. It's a pretty big patch, let me
>>know if you want me to commit it and we will take it from
>>there, making it easier to users to test it. We probably
>>need to polish it somewhat.
>
>
> Great work, Stas! This is a deceptively tricky problem ...
It is. And I'm sure I've missed a few cases.
> I for one would find it really convenient if you could
> commit it and work on it from there - I have trouble with
> longish patches getting them onto my Win32 system.
But it's a pretty big change, so I'd like a few folks to look at it before I
do that. Meanwhile I've attached the same patch if it makes it easier to patch
your source.
May be Geoff will chime in and I'll commit it then. He has a flu though :(
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com