You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2022/07/17 03:11:05 UTC

[Impala-ASF-CR] IMPALA-11440: Remove the unnecessary installation of Apache Ant

yx91490@126.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18741


Change subject: IMPALA-11440: Remove the unnecessary installation of Apache Ant
......................................................................

IMPALA-11440: Remove the unnecessary installation of Apache Ant

Change-Id: I4f744c8a1d0ec9a7e7fbe00d42bc50b1cbd68b08
---
M bin/bootstrap_system.sh
1 file changed, 1 insertion(+), 8 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/41/18741/2
-- 
To view, visit http://gerrit.cloudera.org:8080/18741
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4f744c8a1d0ec9a7e7fbe00d42bc50b1cbd68b08
Gerrit-Change-Number: 18741
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <yx...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-11440: Remove the unnecessary installation of Apache Ant

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18741 )

Change subject: IMPALA-11440: Remove the unnecessary installation of Apache Ant
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/11043/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18741
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f744c8a1d0ec9a7e7fbe00d42bc50b1cbd68b08
Gerrit-Change-Number: 18741
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <yx...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 27 Jul 2022 06:00:23 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11440: Remove the unnecessary installation of Apache Ant

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18741 )

Change subject: IMPALA-11440: Remove the unnecessary installation of Apache Ant
......................................................................


Patch Set 3: Code-Review+2

Thanks! It makes sense to clean this up.


-- 
To view, visit http://gerrit.cloudera.org:8080/18741
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f744c8a1d0ec9a7e7fbe00d42bc50b1cbd68b08
Gerrit-Change-Number: 18741
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <yx...@126.com>
Gerrit-Reviewer: Anonymous Coward <yx...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 Jul 2022 15:46:20 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11440: Remove the unnecessary installation of Apache Ant

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
yx91490@126.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/18741 )

Change subject: IMPALA-11440: Remove the unnecessary installation of Apache Ant
......................................................................


Patch Set 3:

Hi Joe, can you help me to review this? thanks.


-- 
To view, visit http://gerrit.cloudera.org:8080/18741
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f744c8a1d0ec9a7e7fbe00d42bc50b1cbd68b08
Gerrit-Change-Number: 18741
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <yx...@126.com>
Gerrit-Reviewer: Anonymous Coward <yx...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Wed, 27 Jul 2022 11:56:14 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11440: Remove the unnecessary installation of Apache Ant

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18741 )

Change subject: IMPALA-11440: Remove the unnecessary installation of Apache Ant
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10981/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18741
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f744c8a1d0ec9a7e7fbe00d42bc50b1cbd68b08
Gerrit-Change-Number: 18741
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <yx...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 17 Jul 2022 03:31:55 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11440: Remove the unnecessary installation of Apache Ant

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
yx91490@126.com has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/18741 )

Change subject: IMPALA-11440: Remove the unnecessary installation of Apache Ant
......................................................................

IMPALA-11440: Remove the unnecessary installation of Apache Ant

Testing:
 - run existing CI jobs.

Change-Id: I4f744c8a1d0ec9a7e7fbe00d42bc50b1cbd68b08
---
M bin/bootstrap_system.sh
1 file changed, 1 insertion(+), 8 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/41/18741/3
-- 
To view, visit http://gerrit.cloudera.org:8080/18741
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4f744c8a1d0ec9a7e7fbe00d42bc50b1cbd68b08
Gerrit-Change-Number: 18741
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <yx...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-11440: Remove the unnecessary installation of Apache Ant

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18741 )

Change subject: IMPALA-11440: Remove the unnecessary installation of Apache Ant
......................................................................

IMPALA-11440: Remove the unnecessary installation of Apache Ant

Testing:
 - run existing CI jobs.

Change-Id: I4f744c8a1d0ec9a7e7fbe00d42bc50b1cbd68b08
Reviewed-on: http://gerrit.cloudera.org:8080/18741
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
---
M bin/bootstrap_system.sh
1 file changed, 1 insertion(+), 8 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Joe McDonnell: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/18741
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4f744c8a1d0ec9a7e7fbe00d42bc50b1cbd68b08
Gerrit-Change-Number: 18741
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <yx...@126.com>
Gerrit-Reviewer: Anonymous Coward <yx...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>

[Impala-ASF-CR] IMPALA-11440: Remove the unnecessary installation of Apache Ant

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18741 )

Change subject: IMPALA-11440: Remove the unnecessary installation of Apache Ant
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18741
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f744c8a1d0ec9a7e7fbe00d42bc50b1cbd68b08
Gerrit-Change-Number: 18741
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <yx...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 27 Jul 2022 10:46:16 +0000
Gerrit-HasComments: No