You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by lo...@apache.org on 2016/12/21 13:54:22 UTC
svn commit: r1775421 - in
/myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal:
renderkit/renderer/SheetRenderer.java util/JsonUtils.java
webapp/TobagoResponseWriterBase.java webapp/TobagoResponseWriterWrapper.java
Author: lofwyr
Date: Wed Dec 21 13:54:22 2016
New Revision: 1775421
URL: http://svn.apache.org/viewvc?rev=1775421&view=rev
Log:
TOBAGO-1668: Unnecessary Error Logging
Modified:
myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SheetRenderer.java
myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/util/JsonUtils.java
myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/webapp/TobagoResponseWriterBase.java
myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/webapp/TobagoResponseWriterWrapper.java
Modified: myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SheetRenderer.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SheetRenderer.java?rev=1775421&r1=1775420&r2=1775421&view=diff
==============================================================================
--- myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SheetRenderer.java (original)
+++ myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SheetRenderer.java Wed Dec 21 13:54:22 2016
@@ -240,9 +240,10 @@ public class SheetRenderer extends Rende
writer.writeIdAttribute(sheetId + SUFFIX_WIDTHS);
writer.writeNameAttribute(sheetId + SUFFIX_WIDTHS);
writer.writeAttribute(HtmlAttributes.TYPE, HtmlInputTypes.HIDDEN);
- if (definedColumnWidths) {
- writer.writeAttribute(HtmlAttributes.VALUE, JsonUtils.encode(columnWidths), false);
- }
+ writer.writeAttribute(
+ HtmlAttributes.VALUE,
+ JsonUtils.encode(definedColumnWidths ? columnWidths : Collections.<Integer>emptyList()),
+ false);
writer.endElement(HtmlElements.INPUT);
writer.startElement(HtmlElements.INPUT);
Modified: myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/util/JsonUtils.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/util/JsonUtils.java?rev=1775421&r1=1775420&r2=1775421&view=diff
==============================================================================
--- myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/util/JsonUtils.java (original)
+++ myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/util/JsonUtils.java Wed Dec 21 13:54:22 2016
@@ -278,7 +278,7 @@ public class JsonUtils {
json = json.trim();
final List<Integer> result = new ArrayList<Integer>();
if (json.length() < 2 || json.charAt(0) != '[' || json.charAt(json.length() - 1) != ']') {
- LOG.error("Can't parse JSON array: no surrounding square brackets []: '{}'", json);
+ LOG.warn("Can't parse JSON array: no surrounding square brackets []: '{}'", json);
} else {
json = json.substring(1, json.length() - 1);
final StringTokenizer tokenizer = new StringTokenizer(json, ",");
@@ -287,7 +287,7 @@ public class JsonUtils {
try {
result.add(Integer.parseInt(token));
} catch (NumberFormatException e) {
- LOG.error("Can't parse JSON array: not an integer token: '{}'", token);
+ LOG.warn("Can't parse JSON array: not an integer token: '{}'", token);
// ignoring so far
}
}
Modified: myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/webapp/TobagoResponseWriterBase.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/webapp/TobagoResponseWriterBase.java?rev=1775421&r1=1775420&r2=1775421&view=diff
==============================================================================
--- myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/webapp/TobagoResponseWriterBase.java (original)
+++ myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/webapp/TobagoResponseWriterBase.java Wed Dec 21 13:54:22 2016
@@ -97,14 +97,14 @@ public abstract class TobagoResponseWrit
}
} else {
final String trace = getCallingClassStackTraceElementString();
- LOG.error("Don't know what to do! "
+ LOG.warn("Don't know what to do! "
+ "Property defined, but no component to get a value. (value=null, property='" + property + "') "
+ trace.substring(trace.indexOf('(')));
return null;
}
} else {
final String trace = getCallingClassStackTraceElementString();
- LOG.error("Don't know what to do! "
+ LOG.warn("Don't know what to do! "
+ "No value and no property defined. (value=null, property=null)"
+ trace.substring(trace.indexOf('(')));
return null;
Modified: myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/webapp/TobagoResponseWriterWrapper.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/webapp/TobagoResponseWriterWrapper.java?rev=1775421&r1=1775420&r2=1775421&view=diff
==============================================================================
--- myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/webapp/TobagoResponseWriterWrapper.java (original)
+++ myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/webapp/TobagoResponseWriterWrapper.java Wed Dec 21 13:54:22 2016
@@ -92,7 +92,9 @@ public class TobagoResponseWriterWrapper
@Override
public void writeAttribute(final MarkupLanguageAttributes name, final String value, final boolean escape)
throws IOException {
- responseWriter.writeAttribute(name.getValue(), value, null);
+ if (value != null) {
+ responseWriter.writeAttribute(name.getValue(), value, null);
+ }
}
@Override