You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/05/06 19:34:55 UTC
[GitHub] [beam] ibzib opened a new pull request #11623: [BEAM-9908] Fix Python build failures in release script.
ibzib opened a new pull request #11623:
URL: https://github.com/apache/beam/pull/11623
R: @udim
CC: @amaliujia
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/)
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/)
XLang | --- | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/)
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website
--- | --- | --- | --- | ---
Non-portable | [](https://builds.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
Portable | --- | [](https://builds.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] udim commented on a change in pull request #11623: [BEAM-9908] Fix Python build failures in release script.
Posted by GitBox <gi...@apache.org>.
udim commented on a change in pull request #11623:
URL: https://github.com/apache/beam/pull/11623#discussion_r421086807
##########
File path: release/src/main/scripts/build_release_candidate.sh
##########
@@ -275,7 +276,7 @@ if [[ $confirmation = "y" ]]; then
git clone ${GIT_REPO_URL}
cd ${BEAM_ROOT_DIR}
git checkout ${RELEASE_BRANCH}
- cd sdks/python && tox -e docs
+ cd sdks/python && pip install -r build-requirements.txt && tox -e py37-docs
Review comment:
There are 2 virtualenvs here. The one in line 272 will use the default python version, and the one created by tox will use python3.7.
Tox runs "python setup.py sdist" in the first virtualenv and installs the tarball in the second.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] amaliujia commented on a change in pull request #11623: [BEAM-9908] Fix Python build failures in release script.
Posted by GitBox <gi...@apache.org>.
amaliujia commented on a change in pull request #11623:
URL: https://github.com/apache/beam/pull/11623#discussion_r421097127
##########
File path: release/src/main/scripts/build_release_candidate.sh
##########
@@ -275,7 +276,7 @@ if [[ $confirmation = "y" ]]; then
git clone ${GIT_REPO_URL}
cd ${BEAM_ROOT_DIR}
git checkout ${RELEASE_BRANCH}
- cd sdks/python && tox -e docs
+ cd sdks/python && pip install -r build-requirements.txt && tox -e py37-docs
Review comment:
Thanks for clarifying this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] amaliujia commented on a change in pull request #11623: [BEAM-9908] Fix Python build failures in release script.
Posted by GitBox <gi...@apache.org>.
amaliujia commented on a change in pull request #11623:
URL: https://github.com/apache/beam/pull/11623#discussion_r421050465
##########
File path: release/src/main/scripts/build_release_candidate.sh
##########
@@ -275,7 +276,7 @@ if [[ $confirmation = "y" ]]; then
git clone ${GIT_REPO_URL}
cd ${BEAM_ROOT_DIR}
git checkout ${RELEASE_BRANCH}
- cd sdks/python && tox -e docs
+ cd sdks/python && pip install -r build-requirements.txt && tox -e py37-docs
Review comment:
this is interesting cause I thought this script uses python2, and then in this PR `tox -e py37-docs` looks like work with python2
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] amaliujia commented on a change in pull request #11623: [BEAM-9908] Fix Python build failures in release script.
Posted by GitBox <gi...@apache.org>.
amaliujia commented on a change in pull request #11623:
URL: https://github.com/apache/beam/pull/11623#discussion_r421050465
##########
File path: release/src/main/scripts/build_release_candidate.sh
##########
@@ -275,7 +276,7 @@ if [[ $confirmation = "y" ]]; then
git clone ${GIT_REPO_URL}
cd ${BEAM_ROOT_DIR}
git checkout ${RELEASE_BRANCH}
- cd sdks/python && tox -e docs
+ cd sdks/python && pip install -r build-requirements.txt && tox -e py37-docs
Review comment:
this is interesting cause I thought this script uses python2, but `tox -e py37-docs` looks works by python2
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ibzib commented on a change in pull request #11623: [BEAM-9908] Fix Python build failures in release script.
Posted by GitBox <gi...@apache.org>.
ibzib commented on a change in pull request #11623:
URL: https://github.com/apache/beam/pull/11623#discussion_r421089353
##########
File path: release/src/main/scripts/build_release_candidate.sh
##########
@@ -275,7 +276,7 @@ if [[ $confirmation = "y" ]]; then
git clone ${GIT_REPO_URL}
cd ${BEAM_ROOT_DIR}
git checkout ${RELEASE_BRANCH}
- cd sdks/python && tox -e docs
+ cd sdks/python && pip install -r build-requirements.txt && tox -e py37-docs
Review comment:
I can do that.. but I hope we get rid of the "manual" steps in the future. They add no utility over the script and make the release guide hard to read.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] udim commented on a change in pull request #11623: [BEAM-9908] Fix Python build failures in release script.
Posted by GitBox <gi...@apache.org>.
udim commented on a change in pull request #11623:
URL: https://github.com/apache/beam/pull/11623#discussion_r421088091
##########
File path: release/src/main/scripts/build_release_candidate.sh
##########
@@ -275,7 +276,7 @@ if [[ $confirmation = "y" ]]; then
git clone ${GIT_REPO_URL}
cd ${BEAM_ROOT_DIR}
git checkout ${RELEASE_BRANCH}
- cd sdks/python && tox -e docs
+ cd sdks/python && pip install -r build-requirements.txt && tox -e py37-docs
Review comment:
Please also update the release guide:
https://github.com/apache/beam/blame/master/website/src/contribute/release-guide.md#L783
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ibzib commented on a change in pull request #11623: [BEAM-9908] Fix Python build failures in release script.
Posted by GitBox <gi...@apache.org>.
ibzib commented on a change in pull request #11623:
URL: https://github.com/apache/beam/pull/11623#discussion_r421092661
##########
File path: release/src/main/scripts/build_release_candidate.sh
##########
@@ -275,7 +276,7 @@ if [[ $confirmation = "y" ]]; then
git clone ${GIT_REPO_URL}
cd ${BEAM_ROOT_DIR}
git checkout ${RELEASE_BRANCH}
- cd sdks/python && tox -e docs
+ cd sdks/python && pip install -r build-requirements.txt && tox -e py37-docs
Review comment:
Done
##########
File path: release/src/main/scripts/build_release_candidate.sh
##########
@@ -275,7 +276,7 @@ if [[ $confirmation = "y" ]]; then
git clone ${GIT_REPO_URL}
cd ${BEAM_ROOT_DIR}
git checkout ${RELEASE_BRANCH}
- cd sdks/python && tox -e docs
+ cd sdks/python && pip install -r build-requirements.txt && tox -e py37-docs
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org