You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Chesnay Schepler (JIRA)" <ji...@apache.org> on 2019/06/24 07:46:00 UTC
[jira] [Closed] (FLINK-12842) Fix invalid check released state
during ResultPartition#createSubpartitionView
[ https://issues.apache.org/jira/browse/FLINK-12842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chesnay Schepler closed FLINK-12842.
------------------------------------
Resolution: Fixed
Fix Version/s: 1.9.0
master: 86e926266156fcce78430b1cd2c21f6f9f18c3f0
> Fix invalid check released state during ResultPartition#createSubpartitionView
> ------------------------------------------------------------------------------
>
> Key: FLINK-12842
> URL: https://issues.apache.org/jira/browse/FLINK-12842
> Project: Flink
> Issue Type: Sub-task
> Components: Runtime / Network
> Reporter: zhijiang
> Assignee: zhijiang
> Priority: Minor
> Labels: pull-request-available
> Fix For: 1.9.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Currently in {{ResultPartition#createSubpartitionView}} it would check whether this partition is released before creating view. But this check is based on {{refCnt != -1}} which seems invalid, because the reference counter would not always reflect the released state.
> In the case of {{ResultPartition#release/fail}}, the reference counter is not set to -1. Even if in the case of {{ResultPartition#onConsumedSubpartition}}, the reference counter seems also no chance to be -1.
> So we could check the real {{isReleased}} state during creating view instead of reference counter.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)