You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by viirya <gi...@git.apache.org> on 2017/08/18 03:36:24 UTC
[GitHub] spark pull request #18954: [SPARK-17654] [SQL] Enable populating hive bucket...
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18954#discussion_r133874032
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/EnsureRequirements.scala ---
@@ -50,7 +50,9 @@ case class EnsureRequirements(conf: SQLConf) extends Rule[SparkPlan] {
numPartitions: Int): Partitioning = {
requiredDistribution match {
case AllTuples => SinglePartition
- case ClusteredDistribution(clustering) => HashPartitioning(clustering, numPartitions)
+ case ClusteredDistribution(clustering, numClusters, hashingFunctionClass) =>
+ HashPartitioning(clustering, numClusters.getOrElse(numPartitions),
--- End diff --
This is going to create a partitioning that satisfies that distribution. According to modified `HashPartitioning`, if `numPartitions` isn't equal to `numClusters`, `satisfies` returns `false`. It seems a conflict if we ask to create a partitioning of `numPartitions` with a `ClusteredDistribution` of `numClusters`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org