[GitHub] [apisix-dashboard] bzp2010 commented on a change in pull request #2337: chore: add a switch to filter the enabled plugins

[GitBox <gi...@apache.org>]

bzp2010 commented on a change in pull request #2337:
URL: https://github.com/apache/apisix-dashboard/pull/2337#discussion_r813116796



##########
File path: web/src/pages/Upstream/locales/en-US.ts
##########
@@ -15,7 +15,7 @@
  * limitations under the License.
  */
 export default {
-  'page.upstream.step.select.upstream': 'Select Upstream',

Review comment:
       ditto

##########
File path: web/src/pages/Route/List.tsx
##########
@@ -264,7 +264,7 @@ const Page: React.FC = () => {
               </>
             ),
             onOk: () => {
-              remove(record.id!).then(() => {

Review comment:
       Why do you need to change the Login related files in this PR?

##########
File path: web/src/components/Plugin/PluginPage.tsx
##########
@@ -68,7 +68,7 @@ const PluginPage: React.FC<Props> = ({
   const [name, setName] = useState<string>(NEVER_EXIST_PLUGIN_FLAG);
   const [typeList, setTypeList] = useState<string[]>([]);
   const [plugins, setPlugins] = useState({});
-
+  const [showAll,setShowAll] = useState(true)

Review comment:
       A space is needed here.

##########
File path: web/src/pages/User/Login.less
##########
@@ -80,7 +80,6 @@ a {
 
 .logo {
   height: 60px;
-  margin-right: 16px;

Review comment:
       ditto

##########
File path: web/src/components/Plugin/PluginPage.tsx
##########
@@ -179,6 +179,11 @@ const PluginPage: React.FC<Props> = ({
             />
           </>
         )}
+        <Row>
+          <Col span={4} offset={20}>
+        <Switch checked={!showAll} checkedChildren='已启用' unCheckedChildren='全部' onClick = {checked => setShowAll(!checked) }/>
+        </Col>
+        </Row>

Review comment:
       It looks like no problem, can you provide some screenshots for this?

##########
File path: web/src/components/Plugin/PluginPage.tsx
##########
@@ -224,7 +229,7 @@ const PluginPage: React.FC<Props> = ({
                     justifyContent: 'center',
                     alignItems: 'center',
                   }}
-                  style={{ width: 200 }}
+                  style={{ width: 200 ,display: showAll || initialData[item.name] && !initialData[item.name].disable ? ' ' : 'NONE'}}

Review comment:
       Improperly positioned space.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org