You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by bu...@apache.org on 2006/04/02 14:54:48 UTC
DO NOT REPLY [Bug 39180] New: - Subclasses do not have access to StatusLine
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=39180>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=39180
Summary: Subclasses do not have access to StatusLine
Product: HttpClient
Version: 3.0 Final
Platform: All
OS/Version: All
Status: NEW
Severity: normal
Priority: P2
Component: Commons HttpClient
AssignedTo: httpclient-dev@jakarta.apache.org
ReportedBy: fdutton@bellsouth.net
HttpMethodBase provides the readStatusLine method explicitly designed for
subclasses to override. However, any attempt to do so quickly encounters issues
since the subclass does not have access to the statusLine member variable in
HttpMethodBase. The same holds true for several other member variables as well.
Recommend that all access to member variables occur through accessors and that
mutators be provided to set them. See patch below.
----------------------------------------------------------
Index: HttpMethodBase.java
===================================================================
--- HttpMethodBase.java (revision 390815)
+++ HttpMethodBase.java (working copy)
@@ -563,7 +563,7 @@
* @return the status code associated with the latest response.
*/
public int getStatusCode() {
- return statusLine.getStatusCode();
+ return getStatusLine().getStatusCode();
}
/**
@@ -577,6 +577,13 @@
}
/**
+ * @param statusLine The statusLine to set.
+ */
+ protected final void setStatusLine(StatusLine statusLine) {
+ this.statusLine = statusLine;
+ }
+
+ /**
* Checks if response data is available.
* @return <tt>true</tt> if response data is available, <tt>false</tt>
otherwise.
*/
@@ -798,7 +805,7 @@
* @return The status text.
*/
public String getStatusText() {
- return statusLine.getReasonPhrase();
+ return getStatusLine().getReasonPhrase();
}
/**
@@ -920,16 +927,16 @@
}
LOG.debug("Resorting to protocol version default close connection policy");
// missing or invalid connection header, do the default
- if (this.effectiveVersion.greaterEquals(HttpVersion.HTTP_1_1)) {
+ if (getEffectiveVersion().greaterEquals(HttpVersion.HTTP_1_1)) {
if (LOG.isDebugEnabled()) {
- LOG.debug("Should NOT close connection, using " +
this.effectiveVersion.toString());
+ LOG.debug("Should NOT close connection, using " +
getEffectiveVersion().toString());
}
} else {
if (LOG.isDebugEnabled()) {
- LOG.debug("Should close connection, using " +
this.effectiveVersion.toString());
+ LOG.debug("Should close connection, using " +
getEffectiveVersion().toString());
}
}
- return this.effectiveVersion.lessEquals(HttpVersion.HTTP_1_0);
+ return getEffectiveVersion().lessEquals(HttpVersion.HTTP_1_0);
}
/**
@@ -980,14 +987,14 @@
this.responseConnection = conn;
checkExecuteConditions(state, conn);
- this.statusLine = null;
+ setStatusLine(null);
this.connectionCloseForced = false;
conn.setLastResponseInputStream(null);
// determine the effective protocol version
- if (this.effectiveVersion == null) {
- this.effectiveVersion = this.params.getVersion();
+ if (getEffectiveVersion() == null) {
+ setEffectiveVersion(this.params.getVersion());
}
writeRequest(state, conn);
@@ -996,7 +1003,7 @@
// the method has successfully executed
used = true;
- return statusLine.getStatusCode();
+ return getStatusCode();
}
/**
@@ -1048,8 +1055,8 @@
getRequestHeaderGroup().clear();
getResponseHeaderGroup().clear();
getResponseTrailerHeaderGroup().clear();
- statusLine = null;
- effectiveVersion = null;
+ setStatusLine(null);
+ setEffectiveVersion(null);
aborted = false;
used = false;
params = new HttpMethodParams();
@@ -1586,18 +1593,18 @@
"enter HttpMethodBase.readResponse(HttpState, HttpConnection)");
// Status line & line may have already been received
// if 'expect - continue' handshake has been used
- while (this.statusLine == null) {
+ while (getStatusLine() == null) {
readStatusLine(state, conn);
processStatusLine(state, conn);
readResponseHeaders(state, conn);
processResponseHeaders(state, conn);
- int status = this.statusLine.getStatusCode();
+ int status = getStatusCode();
if ((status >= 100) && (status < 200)) {
if (LOG.isInfoEnabled()) {
- LOG.info("Discarding unexpected response: " +
this.statusLine.toString());
+ LOG.info("Discarding unexpected response: " +
getStatusLine().toString());
}
- this.statusLine = null;
+ setStatusLine(null);
}
}
readResponseBody(state, conn);
@@ -1675,7 +1682,7 @@
if (Wire.CONTENT_WIRE.enabled()) {
is = new WireLogInputStream(is, Wire.CONTENT_WIRE);
}
- boolean canHaveBody = canResponseHaveBody(statusLine.getStatusCode());
+ boolean canHaveBody = canResponseHaveBody(getStatusCode());
InputStream result = null;
Header transferEncodingHeader =
responseHeaders.getFirstHeader("Transfer-Encoding");
// We use Transfer-Encoding if present and ignore Content-Length.
@@ -1714,7 +1721,7 @@
} else {
long expectedLength = getResponseContentLength();
if (expectedLength == -1) {
- if (canHaveBody &&
this.effectiveVersion.greaterEquals(HttpVersion.HTTP_1_1)) {
+ if (canHaveBody &&
getEffectiveVersion().greaterEquals(HttpVersion.HTTP_1_1)) {
Header connectionHeader =
responseHeaders.getFirstHeader("Connection");
String connectionDirective = null;
if (connectionHeader != null) {
@@ -1850,19 +1857,19 @@
} while(true);
//create the status line from the status string
- statusLine = new StatusLine(s);
+ setStatusLine(new StatusLine(s));
//check for a valid HTTP-Version
- String versionStr = statusLine.getHttpVersion();
+ String versionStr = getStatusLine().getHttpVersion();
if (getParams().isParameterFalse(HttpMethodParams.UNAMBIGUOUS_STATUS_LINE)
&& versionStr.equals("HTTP")) {
getParams().setVersion(HttpVersion.HTTP_1_0);
if (LOG.isWarnEnabled()) {
LOG.warn("Ambiguous status line (HTTP protocol version missing):" +
- statusLine.toString());
+ getStatusLine().toString());
}
} else {
- this.effectiveVersion = HttpVersion.parse(versionStr);
+ setEffectiveVersion(HttpVersion.parse(versionStr));
}
}
@@ -1943,9 +1950,9 @@
readResponseHeaders(state, conn);
processResponseHeaders(state, conn);
- if (this.statusLine.getStatusCode() ==
HttpStatus.SC_CONTINUE) {
+ if (getStatusCode() == HttpStatus.SC_CONTINUE) {
// Discard status line
- this.statusLine = null;
+ setStatusLine(null);
LOG.debug("OK to continue received");
} else {
return;
@@ -2087,7 +2094,7 @@
*/
private String getRequestLine(HttpConnection conn) {
return HttpMethodBase.generateRequestLine(conn, getName(),
- getPath(), getQueryString(), this.effectiveVersion.toString());
+ getPath(), getQueryString(), getEffectiveVersion().toString());
}
/**
@@ -2128,6 +2135,13 @@
}
/**
+ * @param effectiveVersion The effectiveVersion to set.
+ */
+ protected final void setEffectiveVersion(HttpVersion effectiveVersion) {
+ this.effectiveVersion = effectiveVersion;
+ }
+
+ /**
* Per RFC 2616 section 4.3, some response can never contain a message
* body.
*
@@ -2358,7 +2372,7 @@
) {
// set used so that the response can be read
this.used = true;
- this.statusLine = statusline;
+ setStatusLine(statusline);
this.responseHeaders = responseheaders;
this.responseBody = null;
this.responseStream = responseStream;
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpclient-dev-help@jakarta.apache.org
DO NOT REPLY [Bug 39180] - Subclasses do not have access to StatusLine
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=39180>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=39180
------- Additional Comments From fdutton@bellsouth.net 2006-04-04 11:33 -------
The getter is already public for statusLine. The attached patch has a protected
setter and changes the rest of the code to use both the getter and setter
instead of using the member variable directly. For example,
"setStatusLine(null);" is used instead of "statusLine = null;" Same thing for
effectiveVersion.
I am no longer sure I understand what you meant by keeping a consistent coding
style. Could you elaborate?
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpclient-dev-help@jakarta.apache.org
DO NOT REPLY [Bug 39180] - Subclasses do not have write access to StatusLine
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=39180>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=39180
olegk@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Resolution|WONTFIX |
Summary|Subclasses do not have |Subclasses do not have write
|access to StatusLine |access to StatusLine
------- Additional Comments From olegk@apache.org 2006-04-04 12:51 -------
(In reply to comment #7)
> If I have offended you then I appologize. I did not open this issue just because
> I think it could be done a better way. I have not commented on the suitability
> of the code. I would like to try again :-)
>
No offense taken at all. The point I was trying to make (rather unsuccessfully)
is that merits of what some may consider a good practice tend to be subjective
and context specific.
> readResponse enters a loop looking for a non-null statusLine. readStatusLine is
> responsible for setting the variable to a non-null value. If I override
> readStatusLine I cannot set the variable and readResponse is stuck in the loop.
> I cannot override getStatusLine since readResponse uses the variable directly.
>
> I see four solutions here. Never override readStatusLine (should be private),
> make variable protected, add a setter, or change code to use existing getter.
> Any of the last three will work for me.
>
> The same problems exist with the other member variables; I just used statusLine
> as an example. I can resubmit the patch for any solution you choose and I can
> ensure that all member variables are accessed in a consistent manner.
My preference would be to make those variables protected.
HttpMethodBase (imho) is a horrible pile of <self-censored> broken beyond
redemption. I just want to keep it as stable as possible in the 3.x branch and
do away with it in the 4.x branch
Oleg
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpclient-dev-help@jakarta.apache.org
DO NOT REPLY [Bug 39180] - Subclasses do not have access to StatusLine
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=39180>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=39180
------- Additional Comments From olegk@apache.org 2006-04-03 21:39 -------
(In reply to comment #3)
> The only other option, which is lass safe, is to change all private member
> variables to protected. If this is what you prefer I can produce a patch for it.
What about just a protected getter?
Oleg
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpclient-dev-help@jakarta.apache.org
DO NOT REPLY [Bug 39180] - Subclasses do not have write access to StatusLine
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=39180>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=39180
fdutton@bellsouth.net changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #18014|0 |1
is obsolete| |
------- Additional Comments From fdutton@bellsouth.net 2006-04-05 11:08 -------
Created an attachment (id=18025)
--> (http://issues.apache.org/bugzilla/attachment.cgi?id=18025&action=view)
Change private member variables to protected.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpclient-dev-help@jakarta.apache.org
DO NOT REPLY [Bug 39180] - Subclasses do not have access to StatusLine
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=39180>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=39180
------- Additional Comments From fdutton@bellsouth.net 2006-04-04 12:27 -------
If I have offended you then I appologize. I did not open this issue just because
I think it could be done a better way. I have not commented on the suitability
of the code. I would like to try again :-)
readResponse enters a loop looking for a non-null statusLine. readStatusLine is
responsible for setting the variable to a non-null value. If I override
readStatusLine I cannot set the variable and readResponse is stuck in the loop.
I cannot override getStatusLine since readResponse uses the variable directly.
I see four solutions here. Never override readStatusLine (should be private),
make variable protected, add a setter, or change code to use existing getter.
Any of the last three will work for me.
The same problems exist with the other member variables; I just used statusLine
as an example. I can resubmit the patch for any solution you choose and I can
ensure that all member variables are accessed in a consistent manner.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpclient-dev-help@jakarta.apache.org
DO NOT REPLY [Bug 39180] - Subclasses do not have access to StatusLine
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=39180>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=39180
------- Additional Comments From fdutton@bellsouth.net 2006-04-03 21:36 -------
The only other option, which is lass safe, is to change all private member
variables to protected. If this is what you prefer I can produce a patch for it.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpclient-dev-help@jakarta.apache.org
DO NOT REPLY [Bug 39180] - Subclasses do not have write access to StatusLine
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=39180>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=39180
olegk@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|REOPENED |RESOLVED
Resolution| |WONTFIX
------- Additional Comments From olegk@apache.org 2006-04-18 14:31 -------
Faron,
Feel free to re-open the bug if you provide an alternative patch. I am closing
the bug as WONTFIX for now
Oleg
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpclient-dev-help@jakarta.apache.org
DO NOT REPLY [Bug 39180] - Subclasses do not have write access to StatusLine
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=39180>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=39180
------- Additional Comments From olegk@apache.org 2006-04-06 16:50 -------
Faron,
I think this is too much. Please pprovide a patch with _minimal_ impact on the
existing code. Please make protected only those variables that you absolutely
must have write access to.
Oleg
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpclient-dev-help@jakarta.apache.org
DO NOT REPLY [Bug 39180] - Subclasses do not have access to StatusLine
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=39180>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=39180
olegk@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |WONTFIX
------- Additional Comments From olegk@apache.org 2006-04-04 11:50 -------
I thought the whole issue was one could not have access to some private instance
variable because they did not have a corresponding protected getter. If that is
the case I am fully prepared to accept a patch for it. Otherwise I see no point
in providing protected setters for a _limited_ number of private instance
variables in a _single_ class just because some believe this is a better way.
It is just not feasible that we patch HttpMethodBase in order to please every
single user out there. HttpMethodBase is helplessly broken. It simply needs to go.
I hope this makes my position clearer
Oleg
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpclient-dev-help@jakarta.apache.org
DO NOT REPLY [Bug 39180] - Subclasses do not have access to StatusLine
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=39180>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=39180
------- Additional Comments From fdutton@bellsouth.net 2006-04-02 13:55 -------
Created an attachment (id=18014)
--> (http://issues.apache.org/bugzilla/attachment.cgi?id=18014&action=view)
Patch
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpclient-dev-help@jakarta.apache.org
DO NOT REPLY [Bug 39180] - Subclasses do not have access to StatusLine
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=39180>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=39180
olegk@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Target Milestone|--- |3.0.1
------- Additional Comments From olegk@apache.org 2006-04-02 21:57 -------
(In reply to comment #0)
> HttpMethodBase provides the readStatusLine method explicitly designed for
> subclasses to override. However, any attempt to do so quickly encounters issues
> since the subclass does not have access to the statusLine member variable in
> HttpMethodBase. The same holds true for several other member variables as well.
>
> Recommend that all access to member variables occur through accessors and that
> mutators be provided to set them. See patch below.
This _may_ be right. However I personally would very much rather keep things as
they are at the very least for the sake of consistency, unless the same coding
convention can be applied throughout the entire code base. Moreover,
HttpMethodBase class will go as version 4.0. There's no point in trying to apply
a new coding convention to something which is fundamentally flawed conceptually.
Could you please come up with a patch that just provides access to private
instance variables that you need with the minimal impact on the existing code?
Oleg
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpclient-dev-help@jakarta.apache.org
DO NOT REPLY [Bug 39180] - Subclasses do not have write access to StatusLine
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=39180>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=39180
------- Additional Comments From odi@odi.ch 2006-04-04 13:58 -------
+1 to make them protected
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpclient-dev-help@jakarta.apache.org