You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/10/29 09:34:10 UTC
[GitHub] [shardingsphere] codecov-commenter commented on pull request #21841: Remove useless code
codecov-commenter commented on PR #21841:
URL: https://github.com/apache/shardingsphere/pull/21841#issuecomment-1295784863
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/21841?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#21841](https://codecov.io/gh/apache/shardingsphere/pull/21841?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f8798d7) into [master](https://codecov.io/gh/apache/shardingsphere/commit/05a88dc658d47f9f89cd2a948ffb9ccfeefef40d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (05a88dc) will **increase** coverage by `0.07%`.
> The diff coverage is `33.33%`.
```diff
@@ Coverage Diff @@
## master #21841 +/- ##
============================================
+ Coverage 60.85% 60.92% +0.07%
+ Complexity 2446 2445 -1
============================================
Files 4107 4107
Lines 57339 57268 -71
Branches 9684 9678 -6
============================================
- Hits 34894 34892 -2
+ Misses 19541 19474 -67
+ Partials 2904 2902 -2
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/21841?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ine/core/api/impl/GovernanceRepositoryAPIImpl.java](https://codecov.io/gh/apache/shardingsphere/pull/21841/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS9jb3JlL2FwaS9pbXBsL0dvdmVybmFuY2VSZXBvc2l0b3J5QVBJSW1wbC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...coordinator/registry/GovernanceWatcherFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/21841/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bW9kZS90eXBlL2NsdXN0ZXIvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvbW9kZS9tYW5hZ2VyL2NsdXN0ZXIvY29vcmRpbmF0b3IvcmVnaXN0cnkvR292ZXJuYW5jZVdhdGNoZXJGYWN0b3J5LmphdmE=) | `80.00% <0.00%> (ø)` | |
| [...de/repository/cluster/consul/ConsulRepository.java](https://codecov.io/gh/apache/shardingsphere/pull/21841/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bW9kZS90eXBlL2NsdXN0ZXIvcmVwb3NpdG9yeS9wcm92aWRlci9jb25zdWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21vZGUvcmVwb3NpdG9yeS9jbHVzdGVyL2NvbnN1bC9Db25zdWxSZXBvc2l0b3J5LmphdmE=) | `8.86% <ø> (+0.81%)` | :arrow_up: |
| [...e/mode/repository/cluster/etcd/EtcdRepository.java](https://codecov.io/gh/apache/shardingsphere/pull/21841/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bW9kZS90eXBlL2NsdXN0ZXIvcmVwb3NpdG9yeS9wcm92aWRlci9ldGNkL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tb2RlL3JlcG9zaXRvcnkvY2x1c3Rlci9ldGNkL0V0Y2RSZXBvc2l0b3J5LmphdmE=) | `63.38% <ø> (+6.41%)` | :arrow_up: |
| [...mode/repository/cluster/nacos/NacosRepository.java](https://codecov.io/gh/apache/shardingsphere/pull/21841/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bW9kZS90eXBlL2NsdXN0ZXIvcmVwb3NpdG9yeS9wcm92aWRlci9uYWNvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvbW9kZS9yZXBvc2l0b3J5L2NsdXN0ZXIvbmFjb3MvTmFjb3NSZXBvc2l0b3J5LmphdmE=) | `74.07% <ø> (+3.00%)` | :arrow_up: |
| [...ode/repository/standalone/jdbc/JDBCRepository.java](https://codecov.io/gh/apache/shardingsphere/pull/21841/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bW9kZS90eXBlL3N0YW5kYWxvbmUvcmVwb3NpdG9yeS9wcm92aWRlci9qZGJjL2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21vZGUvcmVwb3NpdG9yeS9zdGFuZGFsb25lL2pkYmMvSkRCQ1JlcG9zaXRvcnkuamF2YQ==) | `82.17% <ø> (+0.80%)` | :arrow_up: |
| [.../cluster/zookeeper/CuratorZookeeperRepository.java](https://codecov.io/gh/apache/shardingsphere/pull/21841/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bW9kZS90eXBlL2NsdXN0ZXIvcmVwb3NpdG9yeS9wcm92aWRlci96b29rZWVwZXItY3VyYXRvci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvbW9kZS9yZXBvc2l0b3J5L2NsdXN0ZXIvem9va2VlcGVyL0N1cmF0b3Jab29rZWVwZXJSZXBvc2l0b3J5LmphdmE=) | `56.55% <100.00%> (+14.29%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org