You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2010/04/16 00:22:58 UTC

[jira] Created: (CASSANDRA-986) Make endpointsnitch per-cluster instead of per-keyspace

Make endpointsnitch per-cluster instead of per-keyspace
-------------------------------------------------------

                 Key: CASSANDRA-986
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-986
             Project: Cassandra
          Issue Type: Improvement
          Components: Core
    Affects Versions: 0.6
            Reporter: Jonathan Ellis
            Assignee: Jonathan Ellis
            Priority: Minor
             Fix For: 0.7


Looks like a deficiency in the EPS and/or ReplicationStrategy design is forcing this, we should clean it up; it doesn't make sense for there to be multiple answers for "how close is node X to me?"

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Resolved: (CASSANDRA-986) Make endpointsnitch per-cluster instead of per-keyspace

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis resolved CASSANDRA-986.
--------------------------------------

    Resolution: Fixed

> Make endpointsnitch per-cluster instead of per-keyspace
> -------------------------------------------------------
>
>                 Key: CASSANDRA-986
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-986
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.6
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 0.7
>
>         Attachments: 986-3.txt, 986.txt
>
>
> Looks like a deficiency in the EPS and/or ReplicationStrategy design is forcing this, we should clean it up; it doesn't make sense for there to be multiple answers for "how close is node X to me?"

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-986) Make endpointsnitch per-cluster instead of per-keyspace

Posted by "Gary Dusbabek (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12858581#action_12858581 ] 

Gary Dusbabek commented on CASSANDRA-986:
-----------------------------------------

I did it manually (which shouldn't change anything).

> Make endpointsnitch per-cluster instead of per-keyspace
> -------------------------------------------------------
>
>                 Key: CASSANDRA-986
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-986
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.6
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 0.7
>
>         Attachments: 986-3.txt, 986.txt
>
>
> Looks like a deficiency in the EPS and/or ReplicationStrategy design is forcing this, we should clean it up; it doesn't make sense for there to be multiple answers for "how close is node X to me?"

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-986) Make endpointsnitch per-cluster instead of per-keyspace

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-986:
-------------------------------------

    Attachment: 986.txt

Basics work fine with this patch, although there is still some cleanup to do so that the different strategies can interoperate (e.g. CASSANDRA-988).

> Make endpointsnitch per-cluster instead of per-keyspace
> -------------------------------------------------------
>
>                 Key: CASSANDRA-986
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-986
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.6
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 0.7
>
>         Attachments: 986.txt
>
>
> Looks like a deficiency in the EPS and/or ReplicationStrategy design is forcing this, we should clean it up; it doesn't make sense for there to be multiple answers for "how close is node X to me?"

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (CASSANDRA-986) Make endpointsnitch per-cluster instead of per-keyspace

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859518#action_12859518 ] 

Jonathan Ellis commented on CASSANDRA-986:
------------------------------------------

rebased patch 3 and hanging problem went away.  committed that.

> Make endpointsnitch per-cluster instead of per-keyspace
> -------------------------------------------------------
>
>                 Key: CASSANDRA-986
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-986
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.6
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 0.7
>
>         Attachments: 986-3.txt, 986.txt
>
>
> Looks like a deficiency in the EPS and/or ReplicationStrategy design is forcing this, we should clean it up; it doesn't make sense for there to be multiple answers for "how close is node X to me?"

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (CASSANDRA-986) Make endpointsnitch per-cluster instead of per-keyspace

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis resolved CASSANDRA-986.
--------------------------------------

    Resolution: Fixed

committed (minus the spurious TODO)

> Make endpointsnitch per-cluster instead of per-keyspace
> -------------------------------------------------------
>
>                 Key: CASSANDRA-986
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-986
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.6
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 0.7
>
>         Attachments: 986.txt
>
>
> Looks like a deficiency in the EPS and/or ReplicationStrategy design is forcing this, we should clean it up; it doesn't make sense for there to be multiple answers for "how close is node X to me?"

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (CASSANDRA-986) Make endpointsnitch per-cluster instead of per-keyspace

Posted by "Gary Dusbabek (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12858554#action_12858554 ] 

Gary Dusbabek commented on CASSANDRA-986:
-----------------------------------------

I gave it a try too, but something else is stopping me up:

Traceback (most recent call last):
  File "/Library/Python/2.6/site-packages/nose-0.11.1-py2.6.egg/nose/case.py", line 364, in setUp
    try_run(self.inst, ('setup', 'setUp'))
  File "/Library/Python/2.6/site-packages/nose-0.11.1-py2.6.egg/nose/util.py", line 487, in try_run
    return func()
  File "/Users/gary.dusbabek/codes/apache/git-trunk/test/system/__init__.py", line 124, in setUp
    self.define_schema()
  File "/Users/gary.dusbabek/codes/apache/git-trunk/test/system/__init__.py", line 154, in define_schema
    Cassandra.CfDef(table='Keyspace1', name='Super4', column_type='Super', subcomparator_type='UTF8Type')
TypeError: __init__() takes at most 5 arguments (6 given)


If I open up ttypes.py I see that CfDef.__init__ takes 8 args.  I'm not sure what's going on.

> Make endpointsnitch per-cluster instead of per-keyspace
> -------------------------------------------------------
>
>                 Key: CASSANDRA-986
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-986
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.6
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 0.7
>
>         Attachments: 986-3.txt, 986.txt
>
>
> Looks like a deficiency in the EPS and/or ReplicationStrategy design is forcing this, we should clean it up; it doesn't make sense for there to be multiple answers for "how close is node X to me?"

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-986) Make endpointsnitch per-cluster instead of per-keyspace

Posted by "Gary Dusbabek (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857940#action_12857940 ] 

Gary Dusbabek commented on CASSANDRA-986:
-----------------------------------------

+1. 

> Make endpointsnitch per-cluster instead of per-keyspace
> -------------------------------------------------------
>
>                 Key: CASSANDRA-986
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-986
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.6
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 0.7
>
>         Attachments: 986.txt
>
>
> Looks like a deficiency in the EPS and/or ReplicationStrategy design is forcing this, we should clean it up; it doesn't make sense for there to be multiple answers for "how close is node X to me?"

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Reopened: (CASSANDRA-986) Make endpointsnitch per-cluster instead of per-keyspace

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis reopened CASSANDRA-986:
--------------------------------------


> Make endpointsnitch per-cluster instead of per-keyspace
> -------------------------------------------------------
>
>                 Key: CASSANDRA-986
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-986
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.6
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 0.7
>
>         Attachments: 986-3.txt, 986.txt
>
>
> Looks like a deficiency in the EPS and/or ReplicationStrategy design is forcing this, we should clean it up; it doesn't make sense for there to be multiple answers for "how close is node X to me?"

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (CASSANDRA-986) Make endpointsnitch per-cluster instead of per-keyspace

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12858575#action_12858575 ] 

Jonathan Ellis commented on CASSANDRA-986:
------------------------------------------

you did rerun gen-thrift-py?

> Make endpointsnitch per-cluster instead of per-keyspace
> -------------------------------------------------------
>
>                 Key: CASSANDRA-986
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-986
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.6
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 0.7
>
>         Attachments: 986-3.txt, 986.txt
>
>
> Looks like a deficiency in the EPS and/or ReplicationStrategy design is forcing this, we should clean it up; it doesn't make sense for there to be multiple answers for "how close is node X to me?"

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-986) Make endpointsnitch per-cluster instead of per-keyspace

Posted by "Gary Dusbabek (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12858014#action_12858014 ] 

Gary Dusbabek commented on CASSANDRA-986:
-----------------------------------------

I just realized there is a KsDef struct in cassandra.thrift that needs to have the snitch ref removed as well.

> Make endpointsnitch per-cluster instead of per-keyspace
> -------------------------------------------------------
>
>                 Key: CASSANDRA-986
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-986
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.6
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 0.7
>
>         Attachments: 986.txt
>
>
> Looks like a deficiency in the EPS and/or ReplicationStrategy design is forcing this, we should clean it up; it doesn't make sense for there to be multiple answers for "how close is node X to me?"

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (CASSANDRA-986) Make endpointsnitch per-cluster instead of per-keyspace

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-986:
-------------------------------------

    Attachment: 986-3.txt

Oh, thanks for catching that.

I took a stab at cleaning it out but now my nosetests hangs. :(  Not sure what's going on, i think it's the KS setup.

> Make endpointsnitch per-cluster instead of per-keyspace
> -------------------------------------------------------
>
>                 Key: CASSANDRA-986
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-986
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.6
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 0.7
>
>         Attachments: 986-3.txt, 986.txt
>
>
> Looks like a deficiency in the EPS and/or ReplicationStrategy design is forcing this, we should clean it up; it doesn't make sense for there to be multiple answers for "how close is node X to me?"

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira