You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/10/04 12:23:00 UTC
[jira] [Commented] (HIVE-20685) XmlOutputFormat does not escape all
required symbols in case of attribte/text
[ https://issues.apache.org/jira/browse/HIVE-20685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16638140#comment-16638140 ]
ASF GitHub Bot commented on HIVE-20685:
---------------------------------------
GitHub user kochunstvo opened a pull request:
https://github.com/apache/hive/pull/444
HIVE-20685 XmlOutputFormat does not escape all required symbols in case of attribte/text
Change escaping to apache's StringEscapingUtil which works as written at https://www.w3.org/TR/2008/REC-xml-20081126/#syntax
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kochunstvo/hive HIVE-20685
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/hive/pull/444.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #444
----
commit 0cdb857ce669f182f8530a7105b81ac34fda8ace
Author: Dmitrii_Khekk <he...@...>
Date: 2018-10-04T12:20:41Z
HIVE-20685 Change escaping to apache's StringEscapingUtil which works as written at https://www.w3.org/TR/2008/REC-xml-20081126/#syntax
----
> XmlOutputFormat does not escape all required symbols in case of attribte/text
> -----------------------------------------------------------------------------
>
> Key: HIVE-20685
> URL: https://issues.apache.org/jira/browse/HIVE-20685
> Project: Hive
> Issue Type: Bug
> Reporter: Dmitrii Khekk
> Assignee: Dmitrii Khekk
> Priority: Minor
> Labels: pull-request-available
>
> Currently it escapes only " and < while & also must be escaped in case of attribute/text based on [1].
> At the same time both " and ' are not required to be encoded for case of element text while for xml attribute one of them should be depending on attribute quote type.
> Also > must be escaped if there is a sequence ]]> inside text or attribute value which is not a part of CDATA
> [1] https://www.w3.org/TR/2008/REC-xml-20081126/#syntax
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)