You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2019/01/23 07:10:24 UTC
Review Request 69813: Improved error printing for gRPC statuses.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69813/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
Bugs: MESOS-9517
https://issues.apache.org/jira/browse/MESOS-9517
Repository: mesos
Description
-------
This patch prepends the error message of a `process::grpc::StatusError`
with its status code.
Diffs
-----
3rdparty/libprocess/include/process/grpc.hpp 28c9cada1bb986af950bfdaa05f8307a062708b7
3rdparty/libprocess/src/grpc.cpp 4e4f989e4744fb11b07c75999fb4e6668277d2fc
Diff: https://reviews.apache.org/r/69813/diff/1/
Testing
-------
make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 69813: Improved error printing for gRPC statuses.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69813/#review212228
-----------------------------------------------------------
PASS: Mesos patch 69813 was successfully built and tested.
Reviews applied: `['69811', '69812', '69813']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2808/mesos-review-69813
- Mesos Reviewbot Windows
On Jan. 23, 2019, 7:10 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69813/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2019, 7:10 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
>
>
> Bugs: MESOS-9517
> https://issues.apache.org/jira/browse/MESOS-9517
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch prepends the error message of a `process::grpc::StatusError`
> with its status code.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/grpc.hpp 28c9cada1bb986af950bfdaa05f8307a062708b7
> 3rdparty/libprocess/src/grpc.cpp 4e4f989e4744fb11b07c75999fb4e6668277d2fc
>
>
> Diff: https://reviews.apache.org/r/69813/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 69813: Improved error printing for gRPC statuses.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69813/
-----------------------------------------------------------
(Updated Jan. 26, 2019, 12:29 a.m.)
Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
Changes
-------
Addressed Benjamin's comments.
Bugs: MESOS-9517
https://issues.apache.org/jira/browse/MESOS-9517
Repository: mesos
Description
-------
This patch prepends the error message of a `process::grpc::StatusError`
with its status code.
Diffs (updated)
-----
3rdparty/libprocess/include/process/grpc.hpp 28c9cada1bb986af950bfdaa05f8307a062708b7
3rdparty/libprocess/src/grpc.cpp 4e4f989e4744fb11b07c75999fb4e6668277d2fc
Diff: https://reviews.apache.org/r/69813/diff/3/
Changes: https://reviews.apache.org/r/69813/diff/2-3/
Testing
-------
make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 69813: Improved error printing for gRPC statuses.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69813/#review212326
-----------------------------------------------------------
Fix it, then Ship it!
3rdparty/libprocess/src/grpc.cpp
Lines 22 (patched)
<https://reviews.apache.org/r/69813/#comment298084>
Unused.
3rdparty/libprocess/src/grpc.cpp
Lines 63-64 (patched)
<https://reviews.apache.org/r/69813/#comment298085>
I'd suggest to just stringify this one as well as to reach here there might be an error in gRPC, not our code.
3rdparty/libprocess/src/grpc.cpp
Lines 75 (patched)
<https://reviews.apache.org/r/69813/#comment298086>
Remove this modification?
- Benjamin Bannier
On Jan. 24, 2019, 7:09 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69813/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2019, 7:09 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
>
>
> Bugs: MESOS-9517
> https://issues.apache.org/jira/browse/MESOS-9517
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch prepends the error message of a `process::grpc::StatusError`
> with its status code.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/grpc.hpp 28c9cada1bb986af950bfdaa05f8307a062708b7
> 3rdparty/libprocess/src/grpc.cpp 4e4f989e4744fb11b07c75999fb4e6668277d2fc
>
>
> Diff: https://reviews.apache.org/r/69813/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 69813: Improved error printing for gRPC statuses.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69813/
-----------------------------------------------------------
(Updated Jan. 24, 2019, 6:09 a.m.)
Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
Changes
-------
Implemented the output operator for `StatusCode` instead. This could be used to generate metric names.
Bugs: MESOS-9517
https://issues.apache.org/jira/browse/MESOS-9517
Repository: mesos
Description
-------
This patch prepends the error message of a `process::grpc::StatusError`
with its status code.
Diffs (updated)
-----
3rdparty/libprocess/include/process/grpc.hpp 28c9cada1bb986af950bfdaa05f8307a062708b7
3rdparty/libprocess/src/grpc.cpp 4e4f989e4744fb11b07c75999fb4e6668277d2fc
Diff: https://reviews.apache.org/r/69813/diff/2/
Changes: https://reviews.apache.org/r/69813/diff/1-2/
Testing
-------
make check
Thanks,
Chun-Hung Hsiao