You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/02/28 03:39:07 UTC

[GitHub] [rocketmq] xujianhai666 commented on a change in pull request #1799: [ISSUE #1798]feat(admin): remove group of deleted sub info when queryTopicConsumeB…

xujianhai666 commented on a change in pull request #1799: [ISSUE #1798]feat(admin): remove group of deleted sub info when queryTopicConsumeB…
URL: https://github.com/apache/rocketmq/pull/1799#discussion_r385493569
 
 

 ##########
 File path: broker/src/main/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java
 ##########
 @@ -1025,8 +1026,15 @@ private RemotingCommand queryTopicConsumeByWho(ChannelHandlerContext ctx,
             groups.addAll(groupInOffset);
         }
 
+        HashSet<String> filteredGroups = new HashSet<String>();
 
 Review comment:
   @duhenglucky so maybe I should add request flag for client, then broker will check flag bool indicator to dicide to filter ? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services