You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "HyukjinKwon (via GitHub)" <gi...@apache.org> on 2024/11/20 00:17:40 UTC
Re: [PR] [SPARK-50348][PYTHON] Make static import Python data source configurable [spark]
HyukjinKwon commented on code in PR #48888:
URL: https://github.com/apache/spark/pull/48888#discussion_r1849327909
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -3189,6 +3189,14 @@ object SQLConf {
.version("4.0.0")
.fallbackConf(Python.PYTHON_WORKER_FAULTHANLDER_ENABLED)
+ val PYTHON_DATA_SOURCE_STATIC_IMPORT_ENABLED =
+ buildConf("spark.sql.pyspark.dataSource.staticImport.enabled")
Review Comment:
I think this should be a `StaticSQLConf` because loading Python Data Source should happen once statically for all sessions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org