You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mahout.apache.org by "Benson Margulies (JIRA)" <ji...@apache.org> on 2009/12/14 03:50:18 UTC
[jira] Created: (MAHOUT-222) Colt collections work in progress
Colt collections work in progress
---------------------------------
Key: MAHOUT-222
URL: https://issues.apache.org/jira/browse/MAHOUT-222
Project: Mahout
Issue Type: Improvement
Components: Matrix
Affects Versions: 0.4
Reporter: Benson Margulies
I am attaching a patch that shows my current work state on polishing the colt collections code. My primary target is the int-int hash map, but I've also started work on extending it to an int-char hash map. No one should even think about committing this yet, I'm posting so that people can see what I'm up to.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAHOUT-222) Colt collections work in progress
Posted by "Benson Margulies (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12790136#action_12790136 ]
Benson Margulies commented on MAHOUT-222:
-----------------------------------------
Here the rule from legal: if you modify a file, even a little, you add an Apache notice, and then you make sure that the overall package NOTICES has the original information. I trust that you made the NOTICES changes when you first committed this stuff. So you will see me adding ASF notices as I modify files.
As for suppress, I don't like to see warnings. However, I can only dig down so deep at a time. So I am adding some suppressions at the moment. I will get rid of them. The 'unused' case was an unused private function. Would you prefer (a) deletion (b) default access, or (c) the suppression? I'm happy with anything except commenting out.
> Colt collections work in progress
> ---------------------------------
>
> Key: MAHOUT-222
> URL: https://issues.apache.org/jira/browse/MAHOUT-222
> Project: Mahout
> Issue Type: Improvement
> Components: Matrix
> Affects Versions: 0.4
> Reporter: Benson Margulies
> Attachments: hash-work-in-progress.diff
>
>
> I am attaching a patch that shows my current work state on polishing the colt collections code. My primary target is the int-int hash map, but I've also started work on extending it to an int-char hash map. No one should even think about committing this yet, I'm posting so that people can see what I'm up to.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAHOUT-222) Colt collections work in progress
Posted by "Benson Margulies (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benson Margulies updated MAHOUT-222:
------------------------------------
Attachment: hash-work-in-progress.diff
> Colt collections work in progress
> ---------------------------------
>
> Key: MAHOUT-222
> URL: https://issues.apache.org/jira/browse/MAHOUT-222
> Project: Mahout
> Issue Type: Improvement
> Components: Matrix
> Affects Versions: 0.4
> Reporter: Benson Margulies
> Attachments: hash-work-in-progress.diff
>
>
> I am attaching a patch that shows my current work state on polishing the colt collections code. My primary target is the int-int hash map, but I've also started work on extending it to an int-char hash map. No one should even think about committing this yet, I'm posting so that people can see what I'm up to.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAHOUT-222) Colt collections work in progress
Posted by "Benson Margulies (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benson Margulies updated MAHOUT-222:
------------------------------------
Attachment: (was: hash-work-in-progress.diff)
> Colt collections work in progress
> ---------------------------------
>
> Key: MAHOUT-222
> URL: https://issues.apache.org/jira/browse/MAHOUT-222
> Project: Mahout
> Issue Type: Improvement
> Components: Matrix
> Affects Versions: 0.4
> Reporter: Benson Margulies
> Attachments: mahout-222-ready.patch
>
>
> I am attaching a patch that shows my current work state on polishing the colt collections code. My primary target is the int-int hash map, but I've also started work on extending it to an int-char hash map. No one should even think about committing this yet, I'm posting so that people can see what I'm up to.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (MAHOUT-222) Colt collections work in progress
Posted by "Sean Owen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sean Owen resolved MAHOUT-222.
------------------------------
Resolution: Fixed
Fix Version/s: 0.3
Assignee: Benson Margulies
Submitted for Benson
> Colt collections work in progress
> ---------------------------------
>
> Key: MAHOUT-222
> URL: https://issues.apache.org/jira/browse/MAHOUT-222
> Project: Mahout
> Issue Type: Improvement
> Components: Matrix
> Affects Versions: 0.4
> Reporter: Benson Margulies
> Assignee: Benson Margulies
> Fix For: 0.3
>
> Attachments: mp2.patch
>
>
> I am attaching a patch that shows my current work state on polishing the colt collections code. My primary target is the int-int hash map, but I've also started work on extending it to an int-char hash map. No one should even think about committing this yet, I'm posting so that people can see what I'm up to.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAHOUT-222) Colt collections work in progress
Posted by "Sean Owen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12790031#action_12790031 ]
Sean Owen commented on MAHOUT-222:
----------------------------------
What's the SuppressWarnings("unused") for? Should we suppress those or address them?
Same with suppressing deprecations?
What's the story on copyright... we are adding the Apache license statement in addition to the Colt statement?
The code itself is looking fine after skimming it.
> Colt collections work in progress
> ---------------------------------
>
> Key: MAHOUT-222
> URL: https://issues.apache.org/jira/browse/MAHOUT-222
> Project: Mahout
> Issue Type: Improvement
> Components: Matrix
> Affects Versions: 0.4
> Reporter: Benson Margulies
> Attachments: hash-work-in-progress.diff
>
>
> I am attaching a patch that shows my current work state on polishing the colt collections code. My primary target is the int-int hash map, but I've also started work on extending it to an int-char hash map. No one should even think about committing this yet, I'm posting so that people can see what I'm up to.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAHOUT-222) Colt collections work in progress
Posted by "Drew Farris (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12790309#action_12790309 ]
Drew Farris commented on MAHOUT-222:
------------------------------------
This looks ok to me as far as code content is concerned. FWIW, I did notice however that OpenIntIntHashMap and its test and GenericSortingTest use tabs instead of two spaces per level. The project style convention dictates using two spaces, see http://cwiki.apache.org/MAHOUT/howtocontribute.html. Once that's fixed it would be great if someone could commit this.
> Colt collections work in progress
> ---------------------------------
>
> Key: MAHOUT-222
> URL: https://issues.apache.org/jira/browse/MAHOUT-222
> Project: Mahout
> Issue Type: Improvement
> Components: Matrix
> Affects Versions: 0.4
> Reporter: Benson Margulies
> Attachments: mahout-222-ready.patch
>
>
> I am attaching a patch that shows my current work state on polishing the colt collections code. My primary target is the int-int hash map, but I've also started work on extending it to an int-char hash map. No one should even think about committing this yet, I'm posting so that people can see what I'm up to.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAHOUT-222) Colt collections work in progress
Posted by "Sean Owen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12790189#action_12790189 ]
Sean Owen commented on MAHOUT-222:
----------------------------------
Nevermind, not comitting, per Benson's message.
> Colt collections work in progress
> ---------------------------------
>
> Key: MAHOUT-222
> URL: https://issues.apache.org/jira/browse/MAHOUT-222
> Project: Mahout
> Issue Type: Improvement
> Components: Matrix
> Affects Versions: 0.4
> Reporter: Benson Margulies
> Attachments: hash-work-in-progress.diff
>
>
> I am attaching a patch that shows my current work state on polishing the colt collections code. My primary target is the int-int hash map, but I've also started work on extending it to an int-char hash map. No one should even think about committing this yet, I'm posting so that people can see what I'm up to.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAHOUT-222) Colt collections work in progress
Posted by "Benson Margulies (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benson Margulies updated MAHOUT-222:
------------------------------------
Attachment: mp2.patch
Updated to fix format.
> Colt collections work in progress
> ---------------------------------
>
> Key: MAHOUT-222
> URL: https://issues.apache.org/jira/browse/MAHOUT-222
> Project: Mahout
> Issue Type: Improvement
> Components: Matrix
> Affects Versions: 0.4
> Reporter: Benson Margulies
> Attachments: mahout-222-ready.patch, mp2.patch
>
>
> I am attaching a patch that shows my current work state on polishing the colt collections code. My primary target is the int-int hash map, but I've also started work on extending it to an int-char hash map. No one should even think about committing this yet, I'm posting so that people can see what I'm up to.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAHOUT-222) Colt collections work in progress
Posted by "Benson Margulies (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benson Margulies updated MAHOUT-222:
------------------------------------
Attachment: mahout-222-ready.patch
This version is commit-worthy. It deleted more deprecations than it tests, but I promise to catch up.
> Colt collections work in progress
> ---------------------------------
>
> Key: MAHOUT-222
> URL: https://issues.apache.org/jira/browse/MAHOUT-222
> Project: Mahout
> Issue Type: Improvement
> Components: Matrix
> Affects Versions: 0.4
> Reporter: Benson Margulies
> Attachments: mahout-222-ready.patch
>
>
> I am attaching a patch that shows my current work state on polishing the colt collections code. My primary target is the int-int hash map, but I've also started work on extending it to an int-char hash map. No one should even think about committing this yet, I'm posting so that people can see what I'm up to.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAHOUT-222) Colt collections work in progress
Posted by "Sean Owen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12790188#action_12790188 ]
Sean Owen commented on MAHOUT-222:
----------------------------------
Sounds good, I will commit -- and if nobody objects, simply remove the unused method. There was a lot of that in the Colt code, especially methods starting with 'x', which I figured were marked that way to mean old/unused code.
> Colt collections work in progress
> ---------------------------------
>
> Key: MAHOUT-222
> URL: https://issues.apache.org/jira/browse/MAHOUT-222
> Project: Mahout
> Issue Type: Improvement
> Components: Matrix
> Affects Versions: 0.4
> Reporter: Benson Margulies
> Attachments: hash-work-in-progress.diff
>
>
> I am attaching a patch that shows my current work state on polishing the colt collections code. My primary target is the int-int hash map, but I've also started work on extending it to an int-char hash map. No one should even think about committing this yet, I'm posting so that people can see what I'm up to.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAHOUT-222) Colt collections work in progress
Posted by "Benson Margulies (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12790367#action_12790367 ]
Benson Margulies commented on MAHOUT-222:
-----------------------------------------
Oh, whoops. I wouldn't usually ask for this, but could one of you just whack this in eclipse and commit? if not i will get to it tonight.
> Colt collections work in progress
> ---------------------------------
>
> Key: MAHOUT-222
> URL: https://issues.apache.org/jira/browse/MAHOUT-222
> Project: Mahout
> Issue Type: Improvement
> Components: Matrix
> Affects Versions: 0.4
> Reporter: Benson Margulies
> Attachments: mahout-222-ready.patch
>
>
> I am attaching a patch that shows my current work state on polishing the colt collections code. My primary target is the int-int hash map, but I've also started work on extending it to an int-char hash map. No one should even think about committing this yet, I'm posting so that people can see what I'm up to.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAHOUT-222) Colt collections work in progress
Posted by "Benson Margulies (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12790409#action_12790409 ]
Benson Margulies commented on MAHOUT-222:
-----------------------------------------
I fixed the format.
> Colt collections work in progress
> ---------------------------------
>
> Key: MAHOUT-222
> URL: https://issues.apache.org/jira/browse/MAHOUT-222
> Project: Mahout
> Issue Type: Improvement
> Components: Matrix
> Affects Versions: 0.4
> Reporter: Benson Margulies
> Attachments: mp2.patch
>
>
> I am attaching a patch that shows my current work state on polishing the colt collections code. My primary target is the int-int hash map, but I've also started work on extending it to an int-char hash map. No one should even think about committing this yet, I'm posting so that people can see what I'm up to.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAHOUT-222) Colt collections work in progress
Posted by "Benson Margulies (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benson Margulies updated MAHOUT-222:
------------------------------------
Attachment: (was: mahout-222-ready.patch)
> Colt collections work in progress
> ---------------------------------
>
> Key: MAHOUT-222
> URL: https://issues.apache.org/jira/browse/MAHOUT-222
> Project: Mahout
> Issue Type: Improvement
> Components: Matrix
> Affects Versions: 0.4
> Reporter: Benson Margulies
> Attachments: mp2.patch
>
>
> I am attaching a patch that shows my current work state on polishing the colt collections code. My primary target is the int-int hash map, but I've also started work on extending it to an int-char hash map. No one should even think about committing this yet, I'm posting so that people can see what I'm up to.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.