[jira] [Commented] (KAFKA-6911) Incorrect check for keystore/truststore dynamic update

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-6911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16478831#comment-16478831 ] 

ASF GitHub Bot commented on KAFKA-6911:
---------------------------------------

rajinisivaram opened a new pull request #5029: KAFKA-6911: Fix dynamic keystore/truststore update check
URL: https://github.com/apache/kafka/pull/5029
 
 
   Fix the check, add unit test to verify the change, update DynamicBrokerReconfigurationTest to avoid dynamic keystore update in tests which are not expected to update keystores.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Incorrect check for keystore/truststore dynamic update
> ------------------------------------------------------
>
>                 Key: KAFKA-6911
>                 URL: https://issues.apache.org/jira/browse/KAFKA-6911
>             Project: Kafka
>          Issue Type: Task
>          Components: core
>    Affects Versions: 1.1.0
>            Reporter: Rajini Sivaram
>            Assignee: Rajini Sivaram
>            Priority: Major
>             Fix For: 2.0.0, 1.1.1
>
>
> The check to see if keystore or truststore needs updating is incorrect - it checks if one of the configs has not changed, rather than changed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)