You are viewing a plain text version of this content. The canonical link for it is here.

Posted to common-dev@hadoop.apache.org by "Suresh Srinivas (JIRA)" <ji...@apache.org> on 2008/09/24 01:05:46 UTC

[jira] Updated: (HADOOP-4253) Fix warnings generated by FindBugs

     [ https://issues.apache.org/jira/browse/HADOOP-4253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Suresh Srinivas updated HADOOP-4253:
------------------------------------

    Attachment: HADOOP-4253.patch

Changes to fix the following findbugs warnings:
- Move Stream creation to try block and ensure the stream is closed in finally block
- DateFormat is not thread safe. Adding synchronization to avoid threading issues.
- Added synchronized blocks to fix synchronization issues flagged by findbugs
- Added retrun value checks in some cases to ensure the error returned by calling a method is handled.
- In TaskTracker, the inner class MapEventsFetcherThread that extends Thread has ambiguous method getName() called. The method getName() is available in the super class Thread and the enclosing class TaskTracker. To avoid the ambiguity, calling the getName() method of the enclosing class.


> Fix warnings generated by FindBugs
> ----------------------------------
>
>                 Key: HADOOP-4253
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4253
>             Project: Hadoop Core
>          Issue Type: Bug
>            Reporter: Suresh Srinivas
>            Assignee: Suresh Srinivas
>             Fix For: 0.19.0
>
>         Attachments: HADOOP-4253.patch
>
>
> Findbugs generates several errors related to unused return values, thread synchronization and ambiguous method calls

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.