You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by "mridulpathak (via GitHub)" <gi...@apache.org> on 2026/09/27 08:49:51 UTC
[PR] Fixed: Regressions in the minilang-to-Groovy conversion of OrderReturnServicesScript.groovy (OFBIZ-13619) [ofbiz-framework]
mridulpathak opened a new pull request, #2125:
URL: https://github.com/apache/ofbiz-framework/pull/2125
- quickReturnFromOrder() read availableReturnTotal from a stale service-result variable that never had that field, always null; also fixed the adjacent countNewReturnItems key typo (was countNewReturnItemx, silently ignored) and a broken log interpolation, all in the same statement block.
- createExchangeOrderAssoc() called makeValue('OrderItemAsscoc'), a nonexistent entity name, guaranteed to throw whenever this branch is taken.
- updateReturnContactMech() never deleted the prior ReturnContactMech row when the contact mech changed, since contactMechId is part of its primary key; restored the missing deleteReturnContactMech call using oldContactMechId.
- updateReturnItem() set ctx.ReturnTypeId (capital R) instead of ctx.returnTypeId when calling updateReturnAdjustment, so the return type was never actually passed through.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed: Regressions in the minilang-to-Groovy conversion of OrderReturnServicesScript.groovy (OFBIZ-13619) [ofbiz-framework]
Posted by "mridulpathak (via GitHub)" <gi...@apache.org>.
mridulpathak merged PR #2125:
URL: https://github.com/apache/ofbiz-framework/pull/2125
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org