You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Xiangrui Meng (JIRA)" <ji...@apache.org> on 2015/04/29 07:09:06 UTC
[jira] [Commented] (SPARK-7220) Check whether moving shared params
is a compatible change
[ https://issues.apache.org/jira/browse/SPARK-7220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14518747#comment-14518747 ]
Xiangrui Meng commented on SPARK-7220:
--------------------------------------
I compiled an example app that calls LinearRegression with elasticNetParam, then I moved methods under HasElasticNetParam to LinearRegressionParams. Without re-compiling, the app jar works with the new Spark assembly jar. So we could treat shared params as implementation details and we don't need to worry about where the methods get declared.
> Check whether moving shared params is a compatible change
> ---------------------------------------------------------
>
> Key: SPARK-7220
> URL: https://issues.apache.org/jira/browse/SPARK-7220
> Project: Spark
> Issue Type: Task
> Components: ML
> Affects Versions: 1.4.0
> Reporter: Xiangrui Meng
> Assignee: Xiangrui Meng
> Priority: Critical
> Fix For: 1.4.0
>
>
> Shared params are private, and their usage are treated as implementation details. But we need to make sure moving params from shared to a concrete class is a compatible change. Otherwise, we shouldn't use shared params.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org