You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/09/29 11:48:28 UTC
[GitHub] [geode-native] gaussianrecurrence opened a new pull request #659: GEODE-8548 Avoid hostname resolution in TcpConn
gaussianrecurrence opened a new pull request #659:
URL: https://github.com/apache/geode-native/pull/659
- Calling get_host_name() in TcpConn::connect involves a system call that
might take several seconds to complete.
- So endpoint is stored instead upon TcpConn construction and used later
instead of making the system call.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] gaussianrecurrence commented on pull request #659: GEODE-8548 Avoid hostname resolution in TcpConn
Posted by GitBox <gi...@apache.org>.
gaussianrecurrence commented on pull request #659:
URL: https://github.com/apache/geode-native/pull/659#issuecomment-701680236
> Yikes, that's pretty subtle - I had to read it a couple of times to see where the important change was. Looks good, and glad to see us get rid of this call. Needless to say, it's super bad to have meaningful code executing inside a LOG* macro.
>
> I'm verifying the build and tests on all platforms, then will merge if everything checks out.
Yes, it was kind of a tricky one to troubleshoot haha. Thanks btw for reviewing the PR :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] pdxcodemonkey merged pull request #659: GEODE-8548 Avoid hostname resolution in TcpConn
Posted by GitBox <gi...@apache.org>.
pdxcodemonkey merged pull request #659:
URL: https://github.com/apache/geode-native/pull/659
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org