You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2021/01/19 10:15:44 UTC

[GitHub] [sling-org-apache-sling-servlets-post] kwin commented on a change in pull request #10: SLING-10030 - Addin PostOperation ranking

kwin commented on a change in pull request #10:
URL: https://github.com/apache/sling-org-apache-sling-servlets-post/pull/10#discussion_r560063474



##########
File path: src/main/java/org/apache/sling/servlets/post/impl/helper/SortedByRankingList.java
##########
@@ -0,0 +1,106 @@
+/*

Review comment:
       Please rather use DS field injection which orders automatically by ranking
   
   > For a reference with multiple cardinality, a field must be a collection of one of the following types:
   Collection
   List
   A subtype of Collection - This type can only be used for dynamic references using the update reference field option. The component instance must initialize the field to a collection object in its constructor.
   (https://docs.osgi.org/specification/osgi.cmpn/7.0.0/service.component.html#service.component-field.injection)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org