You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Thejas Nair <th...@hortonworks.com> on 2014/08/01 00:45:59 UTC

Review Request 24167: HIVE-7533 : sql std auth - set authorization privileges for tables when created from hive cli

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24167/
-----------------------------------------------------------

Review request for hive and Jason Dere.


Bugs: HIVE-7533
    https://issues.apache.org/jira/browse/HIVE-7533


Repository: hive-git


Description
-------

See jira https://issues.apache.org/jira/browse/HIVE-7533


Diffs
-----

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 15bc0a3 
  itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/authorization/plugin/TestHiveAuthorizerCheckInvocation.java c91b15c 
  itests/hive-unit/src/test/java/org/apache/hive/jdbc/authorization/TestCLIAuthzSessionContext.java PRE-CREATION 
  itests/hive-unit/src/test/java/org/apache/hive/jdbc/authorization/TestHS2AuthzContext.java f42390c 
  itests/hive-unit/src/test/java/org/apache/hive/jdbc/authorization/TestHS2AuthzSessionContext.java PRE-CREATION 
  itests/util/src/main/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessControllerForTest.java bdbe8a7 
  itests/util/src/main/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizerFactoryForTest.java 3395513 
  ql/src/java/org/apache/hadoop/hive/ql/Driver.java cba5cfa 
  ql/src/java/org/apache/hadoop/hive/ql/processors/CommandUtil.java 87c8fbb 
  ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizerFactory.java 876527a 
  ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthzContext.java bb71a7e 
  ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthzSessionContext.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessController.java fa77c0c 
  ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizerFactory.java c2d50b1 
  ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java fcfcf42 
  ql/src/test/org/apache/hadoop/hive/ql/parse/authorization/TestSessionUserName.java 273c4b9 
  ql/src/test/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/TestSQLStdHiveAccessController.java 226b16e 
  ql/src/test/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/TestSQLStdHiveAccessControllerCLI.java PRE-CREATION 
  ql/src/test/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/TestSQLStdHiveAccessControllerHS2.java PRE-CREATION 
  ql/src/test/queries/clientnegative/authorization_addjar.q aad703c 
  ql/src/test/queries/clientnegative/authorization_addpartition.q 8abdd2b 
  ql/src/test/queries/clientnegative/authorization_alter_db_owner.q f716262 
  ql/src/test/queries/clientnegative/authorization_alter_db_owner_default.q f904935 
  ql/src/test/queries/clientnegative/authorization_cannot_create_all_role.q 9bbd655 
  ql/src/test/queries/clientnegative/authorization_cannot_create_default_role.q 32045e4 
  ql/src/test/queries/clientnegative/authorization_cannot_create_none_role.q 42369d8 
  ql/src/test/queries/clientnegative/authorization_caseinsensitivity.q 7b47b65 
  ql/src/test/queries/clientnegative/authorization_cli_auth_enable.q PRE-CREATION 
  ql/src/test/queries/clientnegative/authorization_compile.q 857306b 
  ql/src/test/queries/clientnegative/authorization_create_func1.q 02bbe09 
  ql/src/test/queries/clientnegative/authorization_create_func2.q 8760fa8 
  ql/src/test/queries/clientnegative/authorization_create_macro1.q c904a10 
  ql/src/test/queries/clientnegative/authorization_create_role_no_admin.q a84fe64 
  ql/src/test/queries/clientnegative/authorization_createview.q 9b1f2ea 
  ql/src/test/queries/clientnegative/authorization_ctas.q 1cf74a3 
  ql/src/test/queries/clientnegative/authorization_deletejar.q f2e95d2 
  ql/src/test/queries/clientnegative/authorization_desc_table_nosel.q 47663c9 
  ql/src/test/queries/clientnegative/authorization_dfs.q 9dc8a64 
  ql/src/test/queries/clientnegative/authorization_disallow_transform.q 64b300c 
  ql/src/test/queries/clientnegative/authorization_drop_db_cascade.q 78ec078 
  ql/src/test/queries/clientnegative/authorization_drop_db_empty.q 993a2a3 
  ql/src/test/queries/clientnegative/authorization_drop_role_no_admin.q 2593e9e 
  ql/src/test/queries/clientnegative/authorization_droppartition.q f05e945 
  ql/src/test/queries/clientnegative/authorization_fail_8.q 37213a2 
  ql/src/test/queries/clientnegative/authorization_grant_table_allpriv.q f3c86b9 
  ql/src/test/queries/clientnegative/authorization_grant_table_dup.q 7808cb3 
  ql/src/test/queries/clientnegative/authorization_grant_table_fail1.q 8dc8e45 
  ql/src/test/queries/clientnegative/authorization_grant_table_fail_nogrant.q d51c1c3 
  ql/src/test/queries/clientnegative/authorization_insert_noinspriv.q 2fa3cb2 
  ql/src/test/queries/clientnegative/authorization_insert_noselectpriv.q b9bee4e 
  ql/src/test/queries/clientnegative/authorization_insertoverwrite_nodel.q 73cfe82 
  ql/src/test/queries/clientnegative/authorization_invalid_priv_v2.q 9c72408 
  ql/src/test/queries/clientnegative/authorization_not_owner_alter_tab_rename.q 8a3300c 
  ql/src/test/queries/clientnegative/authorization_not_owner_alter_tab_serdeprop.q 0172c4c 
  ql/src/test/queries/clientnegative/authorization_not_owner_drop_tab.q 2d0e52d 
  ql/src/test/queries/clientnegative/authorization_not_owner_drop_view.q 76bbab4 
  ql/src/test/queries/clientnegative/authorization_priv_current_role_neg.q 29a06a8 
  ql/src/test/queries/clientnegative/authorization_revoke_table_fail1.q e19bf37 
  ql/src/test/queries/clientnegative/authorization_revoke_table_fail2.q 4b0cf32 
  ql/src/test/queries/clientnegative/authorization_role_cycles1.q fa3fc19 
  ql/src/test/queries/clientnegative/authorization_role_cycles2.q 069a663 
  ql/src/test/queries/clientnegative/authorization_role_grant.q 3f1a7b8 
  ql/src/test/queries/clientnegative/authorization_role_grant2.q 7d439cb 
  ql/src/test/queries/clientnegative/authorization_role_grant_nosuchrole.q 51ca345 
  ql/src/test/queries/clientnegative/authorization_role_grant_otherrole.q 9440c45 
  ql/src/test/queries/clientnegative/authorization_role_grant_otheruser.q 1db2806 
  ql/src/test/queries/clientnegative/authorization_rolehierarchy_privs.q 8bb776e 
  ql/src/test/queries/clientnegative/authorization_select.q 3987179 
  ql/src/test/queries/clientnegative/authorization_select_view.q a4071cd 
  ql/src/test/queries/clientnegative/authorization_set_role_neg1.q 9ba3a82 
  ql/src/test/queries/clientnegative/authorization_set_role_neg2.q a810f1a 
  ql/src/test/queries/clientnegative/authorization_show_grant_otherrole.q e131766 
  ql/src/test/queries/clientnegative/authorization_show_grant_otheruser_all.q 4ef501d 
  ql/src/test/queries/clientnegative/authorization_show_grant_otheruser_alltabs.q 8cfc790 
  ql/src/test/queries/clientnegative/authorization_show_grant_otheruser_wtab.q 4c3892c 
  ql/src/test/queries/clientnegative/authorization_show_parts_nosel.q d8190de 
  ql/src/test/queries/clientnegative/authorization_show_role_principals_no_admin.q 2afe87f 
  ql/src/test/queries/clientnegative/authorization_show_roles_no_admin.q 0fc9fca 
  ql/src/test/queries/clientnegative/authorization_table_grant_nosuchrole.q 2065093 
  ql/src/test/queries/clientnegative/authorization_truncate.q 285600b 
  ql/src/test/queries/clientnegative/authorization_uri_add_partition.q d82ac71 
  ql/src/test/queries/clientnegative/authorization_uri_alterpart_loc.q d38ba74 
  ql/src/test/queries/clientnegative/authorization_uri_altertab_setloc.q c446b86 
  ql/src/test/queries/clientnegative/authorization_uri_create_table1.q c8e1fb4 
  ql/src/test/queries/clientnegative/authorization_uri_create_table_ext.q c8549b4 
  ql/src/test/queries/clientnegative/authorization_uri_createdb.q edfdf5a 
  ql/src/test/queries/clientnegative/authorization_uri_index.q 1a8f9cb 
  ql/src/test/queries/clientnegative/authorization_uri_insert.q 81b6e52 
  ql/src/test/queries/clientnegative/authorization_uri_insert_local.q 0a2fd89 
  ql/src/test/queries/clientnegative/authorization_uri_load_data.q 6af41f0 
  ql/src/test/queries/clientnegative/authorize_create_tbl.q d8beac3 
  ql/src/test/queries/clientnegative/temp_table_authorize_create_tbl.q bb75777 
  ql/src/test/queries/clientpositive/authorization_1_sql_std.q 34a9b68 
  ql/src/test/queries/clientpositive/authorization_admin_almighty1.q 380f506 
  ql/src/test/queries/clientpositive/authorization_admin_almighty2.q ba43e40 
  ql/src/test/queries/clientpositive/authorization_cli_createtab.q PRE-CREATION 
  ql/src/test/queries/clientpositive/authorization_create_func1.q 1f48deb 
  ql/src/test/queries/clientpositive/authorization_create_macro1.q 741fa92 
  ql/src/test/queries/clientpositive/authorization_create_table_owner_privs.q 17f4861 
  ql/src/test/queries/clientpositive/authorization_create_temp_table.q d49dbb4 
  ql/src/test/queries/clientpositive/authorization_grant_public_role.q 9da33dc 
  ql/src/test/queries/clientpositive/authorization_grant_table_priv.q 9c7a999 
  ql/src/test/queries/clientpositive/authorization_index.q 1f177ff 
  ql/src/test/queries/clientpositive/authorization_insert.q c1e4c1f 
  ql/src/test/queries/clientpositive/authorization_owner_actions.q 85d8b11 
  ql/src/test/queries/clientpositive/authorization_owner_actions_db.q 14a8d7c 
  ql/src/test/queries/clientpositive/authorization_parts.q bee091b 
  ql/src/test/queries/clientpositive/authorization_reset.q aa2c1fb 
  ql/src/test/queries/clientpositive/authorization_revoke_table_priv.q 1cd445b 
  ql/src/test/queries/clientpositive/authorization_role_grant1.q 1e8a6af 
  ql/src/test/queries/clientpositive/authorization_role_grant2.q d87d96f 
  ql/src/test/queries/clientpositive/authorization_set_show_current_role.q 4132370 
  ql/src/test/queries/clientpositive/authorization_show_grant.q bad1f07 
  ql/src/test/queries/clientpositive/authorization_view_sqlstd.q 91acd39 
  ql/src/test/results/clientnegative/authorization_cli_auth_enable.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/authorization_cli_createtab.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/24167/diff/


Testing
-------

New tests included.


Thanks,

Thejas Nair


Re: Review Request 24167: HIVE-7533 : sql std auth - set authorization privileges for tables when created from hive cli

Posted by Jason Dere <jd...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24167/#review49366
-----------------------------------------------------------



common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
<https://reviews.apache.org/r/24167/#comment86364>

    Formatting issue - looks like there are 2 HiveConf vars on the same line.


- Jason Dere


On July 31, 2014, 10:45 p.m., Thejas Nair wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24167/
> -----------------------------------------------------------
> 
> (Updated July 31, 2014, 10:45 p.m.)
> 
> 
> Review request for hive and Jason Dere.
> 
> 
> Bugs: HIVE-7533
>     https://issues.apache.org/jira/browse/HIVE-7533
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> See jira https://issues.apache.org/jira/browse/HIVE-7533
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 15bc0a3 
>   itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/authorization/plugin/TestHiveAuthorizerCheckInvocation.java c91b15c 
>   itests/hive-unit/src/test/java/org/apache/hive/jdbc/authorization/TestCLIAuthzSessionContext.java PRE-CREATION 
>   itests/hive-unit/src/test/java/org/apache/hive/jdbc/authorization/TestHS2AuthzContext.java f42390c 
>   itests/hive-unit/src/test/java/org/apache/hive/jdbc/authorization/TestHS2AuthzSessionContext.java PRE-CREATION 
>   itests/util/src/main/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessControllerForTest.java bdbe8a7 
>   itests/util/src/main/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizerFactoryForTest.java 3395513 
>   ql/src/java/org/apache/hadoop/hive/ql/Driver.java cba5cfa 
>   ql/src/java/org/apache/hadoop/hive/ql/processors/CommandUtil.java 87c8fbb 
>   ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizerFactory.java 876527a 
>   ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthzContext.java bb71a7e 
>   ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthzSessionContext.java PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessController.java fa77c0c 
>   ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizerFactory.java c2d50b1 
>   ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java fcfcf42 
>   ql/src/test/org/apache/hadoop/hive/ql/parse/authorization/TestSessionUserName.java 273c4b9 
>   ql/src/test/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/TestSQLStdHiveAccessController.java 226b16e 
>   ql/src/test/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/TestSQLStdHiveAccessControllerCLI.java PRE-CREATION 
>   ql/src/test/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/TestSQLStdHiveAccessControllerHS2.java PRE-CREATION 
>   ql/src/test/queries/clientnegative/authorization_addjar.q aad703c 
>   ql/src/test/queries/clientnegative/authorization_addpartition.q 8abdd2b 
>   ql/src/test/queries/clientnegative/authorization_alter_db_owner.q f716262 
>   ql/src/test/queries/clientnegative/authorization_alter_db_owner_default.q f904935 
>   ql/src/test/queries/clientnegative/authorization_cannot_create_all_role.q 9bbd655 
>   ql/src/test/queries/clientnegative/authorization_cannot_create_default_role.q 32045e4 
>   ql/src/test/queries/clientnegative/authorization_cannot_create_none_role.q 42369d8 
>   ql/src/test/queries/clientnegative/authorization_caseinsensitivity.q 7b47b65 
>   ql/src/test/queries/clientnegative/authorization_cli_auth_enable.q PRE-CREATION 
>   ql/src/test/queries/clientnegative/authorization_compile.q 857306b 
>   ql/src/test/queries/clientnegative/authorization_create_func1.q 02bbe09 
>   ql/src/test/queries/clientnegative/authorization_create_func2.q 8760fa8 
>   ql/src/test/queries/clientnegative/authorization_create_macro1.q c904a10 
>   ql/src/test/queries/clientnegative/authorization_create_role_no_admin.q a84fe64 
>   ql/src/test/queries/clientnegative/authorization_createview.q 9b1f2ea 
>   ql/src/test/queries/clientnegative/authorization_ctas.q 1cf74a3 
>   ql/src/test/queries/clientnegative/authorization_deletejar.q f2e95d2 
>   ql/src/test/queries/clientnegative/authorization_desc_table_nosel.q 47663c9 
>   ql/src/test/queries/clientnegative/authorization_dfs.q 9dc8a64 
>   ql/src/test/queries/clientnegative/authorization_disallow_transform.q 64b300c 
>   ql/src/test/queries/clientnegative/authorization_drop_db_cascade.q 78ec078 
>   ql/src/test/queries/clientnegative/authorization_drop_db_empty.q 993a2a3 
>   ql/src/test/queries/clientnegative/authorization_drop_role_no_admin.q 2593e9e 
>   ql/src/test/queries/clientnegative/authorization_droppartition.q f05e945 
>   ql/src/test/queries/clientnegative/authorization_fail_8.q 37213a2 
>   ql/src/test/queries/clientnegative/authorization_grant_table_allpriv.q f3c86b9 
>   ql/src/test/queries/clientnegative/authorization_grant_table_dup.q 7808cb3 
>   ql/src/test/queries/clientnegative/authorization_grant_table_fail1.q 8dc8e45 
>   ql/src/test/queries/clientnegative/authorization_grant_table_fail_nogrant.q d51c1c3 
>   ql/src/test/queries/clientnegative/authorization_insert_noinspriv.q 2fa3cb2 
>   ql/src/test/queries/clientnegative/authorization_insert_noselectpriv.q b9bee4e 
>   ql/src/test/queries/clientnegative/authorization_insertoverwrite_nodel.q 73cfe82 
>   ql/src/test/queries/clientnegative/authorization_invalid_priv_v2.q 9c72408 
>   ql/src/test/queries/clientnegative/authorization_not_owner_alter_tab_rename.q 8a3300c 
>   ql/src/test/queries/clientnegative/authorization_not_owner_alter_tab_serdeprop.q 0172c4c 
>   ql/src/test/queries/clientnegative/authorization_not_owner_drop_tab.q 2d0e52d 
>   ql/src/test/queries/clientnegative/authorization_not_owner_drop_view.q 76bbab4 
>   ql/src/test/queries/clientnegative/authorization_priv_current_role_neg.q 29a06a8 
>   ql/src/test/queries/clientnegative/authorization_revoke_table_fail1.q e19bf37 
>   ql/src/test/queries/clientnegative/authorization_revoke_table_fail2.q 4b0cf32 
>   ql/src/test/queries/clientnegative/authorization_role_cycles1.q fa3fc19 
>   ql/src/test/queries/clientnegative/authorization_role_cycles2.q 069a663 
>   ql/src/test/queries/clientnegative/authorization_role_grant.q 3f1a7b8 
>   ql/src/test/queries/clientnegative/authorization_role_grant2.q 7d439cb 
>   ql/src/test/queries/clientnegative/authorization_role_grant_nosuchrole.q 51ca345 
>   ql/src/test/queries/clientnegative/authorization_role_grant_otherrole.q 9440c45 
>   ql/src/test/queries/clientnegative/authorization_role_grant_otheruser.q 1db2806 
>   ql/src/test/queries/clientnegative/authorization_rolehierarchy_privs.q 8bb776e 
>   ql/src/test/queries/clientnegative/authorization_select.q 3987179 
>   ql/src/test/queries/clientnegative/authorization_select_view.q a4071cd 
>   ql/src/test/queries/clientnegative/authorization_set_role_neg1.q 9ba3a82 
>   ql/src/test/queries/clientnegative/authorization_set_role_neg2.q a810f1a 
>   ql/src/test/queries/clientnegative/authorization_show_grant_otherrole.q e131766 
>   ql/src/test/queries/clientnegative/authorization_show_grant_otheruser_all.q 4ef501d 
>   ql/src/test/queries/clientnegative/authorization_show_grant_otheruser_alltabs.q 8cfc790 
>   ql/src/test/queries/clientnegative/authorization_show_grant_otheruser_wtab.q 4c3892c 
>   ql/src/test/queries/clientnegative/authorization_show_parts_nosel.q d8190de 
>   ql/src/test/queries/clientnegative/authorization_show_role_principals_no_admin.q 2afe87f 
>   ql/src/test/queries/clientnegative/authorization_show_roles_no_admin.q 0fc9fca 
>   ql/src/test/queries/clientnegative/authorization_table_grant_nosuchrole.q 2065093 
>   ql/src/test/queries/clientnegative/authorization_truncate.q 285600b 
>   ql/src/test/queries/clientnegative/authorization_uri_add_partition.q d82ac71 
>   ql/src/test/queries/clientnegative/authorization_uri_alterpart_loc.q d38ba74 
>   ql/src/test/queries/clientnegative/authorization_uri_altertab_setloc.q c446b86 
>   ql/src/test/queries/clientnegative/authorization_uri_create_table1.q c8e1fb4 
>   ql/src/test/queries/clientnegative/authorization_uri_create_table_ext.q c8549b4 
>   ql/src/test/queries/clientnegative/authorization_uri_createdb.q edfdf5a 
>   ql/src/test/queries/clientnegative/authorization_uri_index.q 1a8f9cb 
>   ql/src/test/queries/clientnegative/authorization_uri_insert.q 81b6e52 
>   ql/src/test/queries/clientnegative/authorization_uri_insert_local.q 0a2fd89 
>   ql/src/test/queries/clientnegative/authorization_uri_load_data.q 6af41f0 
>   ql/src/test/queries/clientnegative/authorize_create_tbl.q d8beac3 
>   ql/src/test/queries/clientnegative/temp_table_authorize_create_tbl.q bb75777 
>   ql/src/test/queries/clientpositive/authorization_1_sql_std.q 34a9b68 
>   ql/src/test/queries/clientpositive/authorization_admin_almighty1.q 380f506 
>   ql/src/test/queries/clientpositive/authorization_admin_almighty2.q ba43e40 
>   ql/src/test/queries/clientpositive/authorization_cli_createtab.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/authorization_create_func1.q 1f48deb 
>   ql/src/test/queries/clientpositive/authorization_create_macro1.q 741fa92 
>   ql/src/test/queries/clientpositive/authorization_create_table_owner_privs.q 17f4861 
>   ql/src/test/queries/clientpositive/authorization_create_temp_table.q d49dbb4 
>   ql/src/test/queries/clientpositive/authorization_grant_public_role.q 9da33dc 
>   ql/src/test/queries/clientpositive/authorization_grant_table_priv.q 9c7a999 
>   ql/src/test/queries/clientpositive/authorization_index.q 1f177ff 
>   ql/src/test/queries/clientpositive/authorization_insert.q c1e4c1f 
>   ql/src/test/queries/clientpositive/authorization_owner_actions.q 85d8b11 
>   ql/src/test/queries/clientpositive/authorization_owner_actions_db.q 14a8d7c 
>   ql/src/test/queries/clientpositive/authorization_parts.q bee091b 
>   ql/src/test/queries/clientpositive/authorization_reset.q aa2c1fb 
>   ql/src/test/queries/clientpositive/authorization_revoke_table_priv.q 1cd445b 
>   ql/src/test/queries/clientpositive/authorization_role_grant1.q 1e8a6af 
>   ql/src/test/queries/clientpositive/authorization_role_grant2.q d87d96f 
>   ql/src/test/queries/clientpositive/authorization_set_show_current_role.q 4132370 
>   ql/src/test/queries/clientpositive/authorization_show_grant.q bad1f07 
>   ql/src/test/queries/clientpositive/authorization_view_sqlstd.q 91acd39 
>   ql/src/test/results/clientnegative/authorization_cli_auth_enable.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/authorization_cli_createtab.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/24167/diff/
> 
> 
> Testing
> -------
> 
> New tests included.
> 
> 
> Thanks,
> 
> Thejas Nair
> 
>


Re: Review Request 24167: HIVE-7533 : sql std auth - set authorization privileges for tables when created from hive cli

Posted by Thejas Nair <th...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24167/
-----------------------------------------------------------

(Updated Aug. 4, 2014, 7:32 a.m.)


Review request for hive and Jason Dere.


Changes
-------

fixing formatting issue in HIveConf


Bugs: HIVE-7533
    https://issues.apache.org/jira/browse/HIVE-7533


Repository: hive-git


Description
-------

See jira https://issues.apache.org/jira/browse/HIVE-7533


Diffs (updated)
-----

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 15bc0a3 
  itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/authorization/plugin/TestHiveAuthorizerCheckInvocation.java c91b15c 
  itests/hive-unit/src/test/java/org/apache/hive/jdbc/authorization/TestCLIAuthzSessionContext.java PRE-CREATION 
  itests/hive-unit/src/test/java/org/apache/hive/jdbc/authorization/TestHS2AuthzContext.java f42390c 
  itests/hive-unit/src/test/java/org/apache/hive/jdbc/authorization/TestHS2AuthzSessionContext.java PRE-CREATION 
  itests/util/src/main/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessControllerForTest.java bdbe8a7 
  itests/util/src/main/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizerFactoryForTest.java 3395513 
  ql/src/java/org/apache/hadoop/hive/ql/Driver.java 8f3f2b6 
  ql/src/java/org/apache/hadoop/hive/ql/processors/CommandUtil.java 87c8fbb 
  ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizerFactory.java 876527a 
  ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthzContext.java bb71a7e 
  ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthzSessionContext.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessController.java 140882d 
  ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizerFactory.java c2d50b1 
  ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java fcfcf42 
  ql/src/test/org/apache/hadoop/hive/ql/parse/authorization/TestSessionUserName.java 273c4b9 
  ql/src/test/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/TestSQLStdHiveAccessController.java 226b16e 
  ql/src/test/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/TestSQLStdHiveAccessControllerCLI.java PRE-CREATION 
  ql/src/test/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/TestSQLStdHiveAccessControllerHS2.java PRE-CREATION 
  ql/src/test/queries/clientnegative/authorization_addjar.q aad703c 
  ql/src/test/queries/clientnegative/authorization_addpartition.q 8abdd2b 
  ql/src/test/queries/clientnegative/authorization_alter_db_owner.q f716262 
  ql/src/test/queries/clientnegative/authorization_alter_db_owner_default.q f904935 
  ql/src/test/queries/clientnegative/authorization_cannot_create_all_role.q 9bbd655 
  ql/src/test/queries/clientnegative/authorization_cannot_create_default_role.q 32045e4 
  ql/src/test/queries/clientnegative/authorization_cannot_create_none_role.q 42369d8 
  ql/src/test/queries/clientnegative/authorization_caseinsensitivity.q 7b47b65 
  ql/src/test/queries/clientnegative/authorization_cli_auth_enable.q PRE-CREATION 
  ql/src/test/queries/clientnegative/authorization_compile.q 857306b 
  ql/src/test/queries/clientnegative/authorization_create_func1.q 02bbe09 
  ql/src/test/queries/clientnegative/authorization_create_func2.q 8760fa8 
  ql/src/test/queries/clientnegative/authorization_create_macro1.q c904a10 
  ql/src/test/queries/clientnegative/authorization_create_role_no_admin.q a84fe64 
  ql/src/test/queries/clientnegative/authorization_createview.q 9b1f2ea 
  ql/src/test/queries/clientnegative/authorization_ctas.q 1cf74a3 
  ql/src/test/queries/clientnegative/authorization_deletejar.q f2e95d2 
  ql/src/test/queries/clientnegative/authorization_desc_table_nosel.q 47663c9 
  ql/src/test/queries/clientnegative/authorization_dfs.q 9dc8a64 
  ql/src/test/queries/clientnegative/authorization_disallow_transform.q 64b300c 
  ql/src/test/queries/clientnegative/authorization_drop_db_cascade.q 78ec078 
  ql/src/test/queries/clientnegative/authorization_drop_db_empty.q 993a2a3 
  ql/src/test/queries/clientnegative/authorization_drop_role_no_admin.q 2593e9e 
  ql/src/test/queries/clientnegative/authorization_droppartition.q f05e945 
  ql/src/test/queries/clientnegative/authorization_fail_8.q 37213a2 
  ql/src/test/queries/clientnegative/authorization_grant_table_allpriv.q f3c86b9 
  ql/src/test/queries/clientnegative/authorization_grant_table_dup.q 7808cb3 
  ql/src/test/queries/clientnegative/authorization_grant_table_fail1.q 8dc8e45 
  ql/src/test/queries/clientnegative/authorization_grant_table_fail_nogrant.q d51c1c3 
  ql/src/test/queries/clientnegative/authorization_insert_noinspriv.q 2fa3cb2 
  ql/src/test/queries/clientnegative/authorization_insert_noselectpriv.q b9bee4e 
  ql/src/test/queries/clientnegative/authorization_insertoverwrite_nodel.q 73cfe82 
  ql/src/test/queries/clientnegative/authorization_invalid_priv_v2.q 9c72408 
  ql/src/test/queries/clientnegative/authorization_not_owner_alter_tab_rename.q 8a3300c 
  ql/src/test/queries/clientnegative/authorization_not_owner_alter_tab_serdeprop.q 0172c4c 
  ql/src/test/queries/clientnegative/authorization_not_owner_drop_tab.q 2d0e52d 
  ql/src/test/queries/clientnegative/authorization_not_owner_drop_view.q 76bbab4 
  ql/src/test/queries/clientnegative/authorization_priv_current_role_neg.q 29a06a8 
  ql/src/test/queries/clientnegative/authorization_revoke_table_fail1.q e19bf37 
  ql/src/test/queries/clientnegative/authorization_revoke_table_fail2.q 4b0cf32 
  ql/src/test/queries/clientnegative/authorization_role_cycles1.q fa3fc19 
  ql/src/test/queries/clientnegative/authorization_role_cycles2.q 069a663 
  ql/src/test/queries/clientnegative/authorization_role_grant.q 3f1a7b8 
  ql/src/test/queries/clientnegative/authorization_role_grant2.q 7d439cb 
  ql/src/test/queries/clientnegative/authorization_role_grant_nosuchrole.q 51ca345 
  ql/src/test/queries/clientnegative/authorization_role_grant_otherrole.q 9440c45 
  ql/src/test/queries/clientnegative/authorization_role_grant_otheruser.q 1db2806 
  ql/src/test/queries/clientnegative/authorization_rolehierarchy_privs.q 8bb776e 
  ql/src/test/queries/clientnegative/authorization_select.q 3987179 
  ql/src/test/queries/clientnegative/authorization_select_view.q a4071cd 
  ql/src/test/queries/clientnegative/authorization_set_role_neg1.q 9ba3a82 
  ql/src/test/queries/clientnegative/authorization_set_role_neg2.q a810f1a 
  ql/src/test/queries/clientnegative/authorization_show_grant_otherrole.q e131766 
  ql/src/test/queries/clientnegative/authorization_show_grant_otheruser_all.q 4ef501d 
  ql/src/test/queries/clientnegative/authorization_show_grant_otheruser_alltabs.q 8cfc790 
  ql/src/test/queries/clientnegative/authorization_show_grant_otheruser_wtab.q 4c3892c 
  ql/src/test/queries/clientnegative/authorization_show_parts_nosel.q d8190de 
  ql/src/test/queries/clientnegative/authorization_show_role_principals_no_admin.q 2afe87f 
  ql/src/test/queries/clientnegative/authorization_show_roles_no_admin.q 0fc9fca 
  ql/src/test/queries/clientnegative/authorization_table_grant_nosuchrole.q 2065093 
  ql/src/test/queries/clientnegative/authorization_truncate.q 285600b 
  ql/src/test/queries/clientnegative/authorization_uri_add_partition.q d82ac71 
  ql/src/test/queries/clientnegative/authorization_uri_alterpart_loc.q d38ba74 
  ql/src/test/queries/clientnegative/authorization_uri_altertab_setloc.q c446b86 
  ql/src/test/queries/clientnegative/authorization_uri_create_table1.q c8e1fb4 
  ql/src/test/queries/clientnegative/authorization_uri_create_table_ext.q c8549b4 
  ql/src/test/queries/clientnegative/authorization_uri_createdb.q edfdf5a 
  ql/src/test/queries/clientnegative/authorization_uri_index.q 1a8f9cb 
  ql/src/test/queries/clientnegative/authorization_uri_insert.q 81b6e52 
  ql/src/test/queries/clientnegative/authorization_uri_insert_local.q 0a2fd89 
  ql/src/test/queries/clientnegative/authorization_uri_load_data.q 6af41f0 
  ql/src/test/queries/clientnegative/authorize_create_tbl.q d8beac3 
  ql/src/test/queries/clientnegative/temp_table_authorize_create_tbl.q bb75777 
  ql/src/test/queries/clientpositive/authorization_1_sql_std.q 34a9b68 
  ql/src/test/queries/clientpositive/authorization_admin_almighty1.q 380f506 
  ql/src/test/queries/clientpositive/authorization_admin_almighty2.q ba43e40 
  ql/src/test/queries/clientpositive/authorization_cli_createtab.q PRE-CREATION 
  ql/src/test/queries/clientpositive/authorization_create_func1.q 1f48deb 
  ql/src/test/queries/clientpositive/authorization_create_macro1.q 741fa92 
  ql/src/test/queries/clientpositive/authorization_create_table_owner_privs.q 17f4861 
  ql/src/test/queries/clientpositive/authorization_create_temp_table.q d49dbb4 
  ql/src/test/queries/clientpositive/authorization_grant_public_role.q 9da33dc 
  ql/src/test/queries/clientpositive/authorization_grant_table_priv.q 9c7a999 
  ql/src/test/queries/clientpositive/authorization_index.q 1f177ff 
  ql/src/test/queries/clientpositive/authorization_insert.q c1e4c1f 
  ql/src/test/queries/clientpositive/authorization_owner_actions.q 85d8b11 
  ql/src/test/queries/clientpositive/authorization_owner_actions_db.q 14a8d7c 
  ql/src/test/queries/clientpositive/authorization_parts.q bee091b 
  ql/src/test/queries/clientpositive/authorization_reset.q aa2c1fb 
  ql/src/test/queries/clientpositive/authorization_revoke_table_priv.q 1cd445b 
  ql/src/test/queries/clientpositive/authorization_role_grant1.q 1e8a6af 
  ql/src/test/queries/clientpositive/authorization_role_grant2.q d87d96f 
  ql/src/test/queries/clientpositive/authorization_set_show_current_role.q 4132370 
  ql/src/test/queries/clientpositive/authorization_show_grant.q bad1f07 
  ql/src/test/queries/clientpositive/authorization_view_sqlstd.q 91acd39 
  ql/src/test/results/clientnegative/authorization_cli_auth_enable.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/authorization_cli_createtab.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/24167/diff/


Testing
-------

New tests included.


Thanks,

Thejas Nair