You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/07/06 02:37:11 UTC

[GitHub] [calcite] danny0405 commented on a change in pull request #2056: [CALCITE-4106] Consider "listCoerced" when TypeCoercionImpl#inOperationCoercion returns

danny0405 commented on a change in pull request #2056:
URL: https://github.com/apache/calcite/pull/2056#discussion_r449956914



##########
File path: core/src/main/java/org/apache/calcite/sql/validate/implicit/TypeCoercionImpl.java
##########
@@ -535,7 +535,7 @@ public int size() {
           coerced = rowTypeCoercion(scope1, node2, i, desired) || coerced;
         }

Review comment:
       Add this `coerced = coerced || listCoerced;` code in line 530 is enough, can we try to give a test case here ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org