[GitHub] [spark] mundaym commented on pull request #29407: [SPARK-32588][CORE][TEST] Fix SizeEstimator initialization in tests

[GitBox <gi...@apache.org>]

mundaym commented on pull request #29407:
URL: https://github.com/apache/spark/pull/29407#issuecomment-673453911


   > One related question outside the scope of this PR: since some system properties affect the behavior of the SizeEstimator, should the test suites that re-initialize SizeEstimator be responsible to restoring those properties back to the default (whatever state that came in before the suite) so that other suites are less likely to be affected?
   
   I did wonder that myself. I don't know enough about how much of the environment is reset (new JVM instance?) between runs of each test suite to say either way really. Most probably the individual tests should reset everything to avoid accidental dependencies between them (e.g. a situation where one test sets a property and another test accidentally relies on it being set).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org