You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by sharkdtu <gi...@git.apache.org> on 2017/01/20 02:30:03 UTC
[GitHub] spark pull request #16651: [SPARK-19298][Core] History server can't match Ma...
GitHub user sharkdtu opened a pull request:
https://github.com/apache/spark/pull/16651
[SPARK-19298][Core] History server can't match MalformedInputException and prompt the detail logs while repalying eventlog
History server can't match MalformedInputException and prompt the detail logs while repalying eventlog, because MalformedInputException is a subclass of IOException.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sharkdtu/spark master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/16651.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #16651
----
commit 07f59016d6175d5aac0242f7432ce09bb3f984b0
Author: sharkdtu <sh...@tencent.com>
Date: 2017-01-20T02:06:55Z
fix MalformedInputException match
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #16651: [SPARK-19298][Core] History server can't match Malformed...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/16651
Let's close this if there is no follow-up
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #16651: [SPARK-19298][Core] History server can't match Ma...
Posted by jerryshao <gi...@git.apache.org>.
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/16651#discussion_r97040793
--- Diff: core/src/main/scala/org/apache/spark/scheduler/ReplayListenerBus.scala ---
@@ -107,11 +107,11 @@ private[spark] class ReplayListenerBus extends SparkListenerBus with Logging {
}
}
} catch {
- case ioe: IOException =>
- throw ioe
- case e: Exception =>
- logError(s"Exception parsing Spark event log: $sourceName", e)
+ case ex: MalformedInputException =>
--- End diff --
I see, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #16651: [SPARK-19298][Core] History server can't match Malformed...
Posted by sharkdtu <gi...@git.apache.org>.
Github user sharkdtu commented on the issue:
https://github.com/apache/spark/pull/16651
@srowen
i think the logs were just for `MalformedInputException`, it does't matter that non-IOExceptions will be rethrown, because they will be catched by upper callers.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #16651: [SPARK-19298][Core] History server can't match Malformed...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16651
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #16651: [SPARK-19298][Core] History server can't match Ma...
Posted by jerryshao <gi...@git.apache.org>.
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/16651#discussion_r97035706
--- Diff: core/src/main/scala/org/apache/spark/scheduler/ReplayListenerBus.scala ---
@@ -107,11 +107,11 @@ private[spark] class ReplayListenerBus extends SparkListenerBus with Logging {
}
}
} catch {
- case ioe: IOException =>
- throw ioe
- case e: Exception =>
- logError(s"Exception parsing Spark event log: $sourceName", e)
+ case ex: MalformedInputException =>
--- End diff --
@sharkdtu Can you please point out which code will throw this `MalformedInputException `?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #16651: [SPARK-19298][Core] History server can't match Malformed...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/16651
Isn't this changing the default behavior for non-IOExceptions? now they're rethrown.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #16651: [SPARK-19298][Core] History server can't match Ma...
Posted by jerryshao <gi...@git.apache.org>.
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/16651#discussion_r97029808
--- Diff: core/src/main/scala/org/apache/spark/scheduler/ReplayListenerBus.scala ---
@@ -107,11 +107,11 @@ private[spark] class ReplayListenerBus extends SparkListenerBus with Logging {
}
}
} catch {
- case ioe: IOException =>
- throw ioe
- case e: Exception =>
- logError(s"Exception parsing Spark event log: $sourceName", e)
+ case ex: MalformedInputException =>
--- End diff --
Should we import this `MalformedInputException` class? I manually applied your changes, seems it failed to compile...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #16651: [SPARK-19298][Core] History server can't match Malformed...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/16651
I'm not clear why you believe the exception handling should be changed. If IOExceptions are fatal, and this is a form of I/O exception (corrupted input), why change it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #16651: [SPARK-19298][Core] History server can't match Malformed...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/16651
Ping @sharkdtu
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #16651: [SPARK-19298][Core] History server can't match Ma...
Posted by sharkdtu <gi...@git.apache.org>.
Github user sharkdtu commented on a diff in the pull request:
https://github.com/apache/spark/pull/16651#discussion_r97034201
--- Diff: core/src/main/scala/org/apache/spark/scheduler/ReplayListenerBus.scala ---
@@ -107,11 +107,11 @@ private[spark] class ReplayListenerBus extends SparkListenerBus with Logging {
}
}
} catch {
- case ioe: IOException =>
- throw ioe
- case e: Exception =>
- logError(s"Exception parsing Spark event log: $sourceName", e)
+ case ex: MalformedInputException =>
--- End diff --
thx, forgot to import MalformedInputException
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #16651: [SPARK-19298][Core] History server can't match Ma...
Posted by sharkdtu <gi...@git.apache.org>.
Github user sharkdtu commented on a diff in the pull request:
https://github.com/apache/spark/pull/16651#discussion_r97037524
--- Diff: core/src/main/scala/org/apache/spark/scheduler/ReplayListenerBus.scala ---
@@ -107,11 +107,11 @@ private[spark] class ReplayListenerBus extends SparkListenerBus with Logging {
}
}
} catch {
- case ioe: IOException =>
- throw ioe
- case e: Exception =>
- logError(s"Exception parsing Spark event log: $sourceName", e)
+ case ex: MalformedInputException =>
--- End diff --
please check: https://issues.apache.org/jira/browse/SPARK-19298
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #16651: [SPARK-19298][Core] History server can't match Ma...
Posted by sharkdtu <gi...@git.apache.org>.
Github user sharkdtu closed the pull request at:
https://github.com/apache/spark/pull/16651
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org