You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2021/02/22 11:26:07 UTC

[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on pull request #919: [WIP] controller: optimize code size based on roles

apache-mynewt-bot removed a comment on pull request #919:
URL: https://github.com/apache/mynewt-nimble/pull/919#issuecomment-782066488


   
   <!-- style-bot -->
   
   ## Style check summary
   
   ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
   #### nimble/controller/src/ble_ll.c
   <details>
   
   ```diff
   @@ -577,7 +576,7 @@
         */
    #if NIMBLE_BLE_ADVERTISE
        if (g_ble_ll_conn_create_sm || ble_ll_scan_enabled() ||
   -                                (!hci_adv_ext && ble_ll_adv_enabled())) {
   +        (!hci_adv_ext && ble_ll_adv_enabled())) {
            return BLE_ERR_CMD_DISALLOWED;
        }
    #endif
   ```
   
   </details>
   
   #### nimble/controller/src/ble_ll_adv.c
   <details>
   
   ```diff
   @@ -5009,7 +5009,7 @@
    #if NIMBLE_BLE_ADVERTISE
        if (advsm->own_addr_type > BLE_HCI_ADV_OWN_ADDR_RANDOM) {
            if ((advsm->flags & BLE_LL_ADV_SM_FLAG_TX_ADD) &&
   -                                    ble_ll_is_rpa(advsm->adva, 1)) {
   +            ble_ll_is_rpa(advsm->adva, 1)) {
                rpa = advsm->adva;
            }
        }
   ```
   
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org