You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/03/14 17:55:37 UTC
[GitHub] [trafficcontrol] rob05c opened a new pull request #5641: Fix atscfg header rewrite injection
rob05c opened a new pull request #5641:
URL: https://github.com/apache/trafficcontrol/pull/5641
Fixes header rewrite injection for:
- max origin connections to not [L], which can break custom rewrites
- max origin connections for new ATS 9 param
- service category to always include hook
- service category to sanitize user input
- fix header rewrite code duplication
- fix to ignore hdr_rw_ location params for Topology DSes
- [x] This PR is not related to any other Issue
## Which Traffic Control components are affected by this PR?
- Traffic Ops ORT
## What is the best way to verify this PR?
Run ORT unit tests. Run ORT integration tests. Run ORT manually, verify config generates correctly, particularly header rewrites.
## If this is a bug fix, what versions of Traffic Control are affected?
<!-- If this PR fixes a bug, please list here all of the affected versions - to
the best of your knowledge. It's also pretty helpful to include a commit hash
of where 'master' is at the time this PR is opened (if it affects master),
because what 'master' means will change over time. For example, if this PR
fixes a bug that's present in master (at commit hash '1df853c8'), in v4.0.0,
and in the current 4.0.1 Release candidate (e.g. RC1), then this list would
look like:
- master (1df853c8)
- 4.0.0
- 4.0.1 (RC1)
If you don't know what other versions might have this bug, AND don't know how
to find the commit hash of 'master', then feel free to leave this section
blank (or, preferably, delete it entirely).
-->
## The following criteria are ALL met by this PR
<!-- Check the boxes to signify that the associated statement is true. To
"check a box", replace the space inside of the square brackets with an 'x'.
e.g.
- [ x] <- Wrong
- [x ] <- Wrong
- [] <- Wrong
- [*] <- Wrong
- [x] <- Correct!
-->
- [ ] This PR includes tests OR I have explained why tests are unnecessary
- [ ] This PR includes documentation OR I have explained why documentation is unnecessary
- [ ] This PR includes an update to CHANGELOG.md OR such an update is not necessary
- [ ] This PR includes any and all required license headers
- [ ] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details)
## Additional Information
<!-- If you would like to include any additional information on the PR for
potential reviewers please put it here.
Some examples of this would be:
- Before and after screenshots/gifs of the Traffic Portal if it is affected
- Links to other dependent Pull Requests
- References to relevant context (e.g. new/updates to dependent libraries,
mailing list records, blueprints)
Feel free to leave this section blank (or, preferably, delete it entirely).
-->
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] dneuman64 merged pull request #5641: Fix atscfg header rewrite injection
Posted by GitBox <gi...@apache.org>.
dneuman64 merged pull request #5641:
URL: https://github.com/apache/trafficcontrol/pull/5641
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rob05c commented on a change in pull request #5641: Fix atscfg header rewrite injection
Posted by GitBox <gi...@apache.org>.
rob05c commented on a change in pull request #5641:
URL: https://github.com/apache/trafficcontrol/pull/5641#discussion_r597775289
##########
File path: lib/go-atscfg/headerrewritedotconfig.go
##########
@@ -23,74 +23,300 @@ import (
"errors"
"fmt"
"math"
+ "net/url"
"regexp"
"strconv"
"strings"
"github.com/apache/trafficcontrol/lib/go-tc"
- "github.com/apache/trafficcontrol/lib/go-util"
)
const HeaderRewritePrefix = "hdr_rw_"
+const HeaderRewriteMidPrefix = "hdr_rw_mid_"
const ContentTypeHeaderRewriteDotConfig = ContentTypeTextASCII
const LineCommentHeaderRewriteDotConfig = LineCommentHash
const ServiceCategoryHeader = "CDN-SVC"
const MaxOriginConnectionsNoMax = 0 // 0 indicates no limit on origin connections
+const HeaderRewriteFirstPrefix = HeaderRewritePrefix + "first_"
+const HeaderRewriteInnerPrefix = HeaderRewritePrefix + "inner_"
+const HeaderRewriteLastPrefix = HeaderRewritePrefix + "last_"
+
+func FirstHeaderRewriteConfigFileName(dsName string) string {
+ return HeaderRewriteFirstPrefix + dsName + ConfigSuffix
+}
+
+func InnerHeaderRewriteConfigFileName(dsName string) string {
+ return HeaderRewriteInnerPrefix + dsName + ConfigSuffix
+}
+
+func LastHeaderRewriteConfigFileName(dsName string) string {
+ return HeaderRewriteLastPrefix + dsName + ConfigSuffix
+}
+
+// MakeHeaderRewriteDotConfig makes the header rewrite file for
+// an Edge hdr_rw_ or Mid hdr_rw_mid_ or Topology hdr_rw_{first,inner,last} file,
+// as generated by MakeMetaConfigFilesList.
func MakeHeaderRewriteDotConfig(
fileName string,
deliveryServices []DeliveryService,
deliveryServiceServers []tc.DeliveryServiceServer,
server *Server,
servers []Server,
+ cacheGroupsArr []tc.CacheGroupNullable,
+ tcServerParams []tc.Parameter,
+ serverCapabilities map[int]map[ServerCapability]struct{},
+ requiredCapabilities map[int]map[ServerCapability]struct{},
+ topologiesArr []tc.Topology,
hdrComment string,
) (Cfg, error) {
warnings := []string{}
+ if server.CDNName == nil {
+ return Cfg{}, makeErr(warnings, "this server missing CDNName")
+ } else if tc.CacheType(server.Type) == tc.CacheTypeInvalid {
+ return Cfg{}, makeErr(warnings, "this server missing Type")
+ } else if server.HostName == nil {
+ return Cfg{}, makeErr(warnings, "server missing HostName")
+ } else if server.Cachegroup == nil {
+ return Cfg{}, makeErr(warnings, "server missing Cachegroup")
+ }
- dsName := strings.TrimSuffix(strings.TrimPrefix(fileName, HeaderRewritePrefix), ConfigSuffix) // TODO verify prefix and suffix? Perl doesn't
+ cacheGroups, err := makeCGMap(cacheGroupsArr)
+ if err != nil {
+ return Cfg{}, makeErr(warnings, "making CacheGroup map: "+err.Error())
+ }
+ topologies := makeTopologyNameMap(topologiesArr)
+
+ // TODO verify prefix and suffix? Perl doesn't
+ dsName := fileName
+ dsName = strings.TrimSuffix(dsName, ConfigSuffix)
+ dsName = strings.TrimPrefix(dsName, HeaderRewriteFirstPrefix)
+ dsName = strings.TrimPrefix(dsName, HeaderRewriteInnerPrefix)
+ dsName = strings.TrimPrefix(dsName, HeaderRewriteLastPrefix)
+ dsName = strings.TrimPrefix(dsName, HeaderRewriteMidPrefix)
+ dsName = strings.TrimPrefix(dsName, HeaderRewritePrefix)
Review comment:
> Looks like underscores in the DS name will cause all sorts of other issues and just need to be removed entirely. This issue isn't unique to this, so we can merge.
Yep. I made https://github.com/apache/trafficcontrol/issues/5658 to add that validation to Traffic Ops
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] alficles commented on a change in pull request #5641: Fix atscfg header rewrite injection
Posted by GitBox <gi...@apache.org>.
alficles commented on a change in pull request #5641:
URL: https://github.com/apache/trafficcontrol/pull/5641#discussion_r597755914
##########
File path: lib/go-atscfg/headerrewritedotconfig.go
##########
@@ -23,74 +23,300 @@ import (
"errors"
"fmt"
"math"
+ "net/url"
"regexp"
"strconv"
"strings"
"github.com/apache/trafficcontrol/lib/go-tc"
- "github.com/apache/trafficcontrol/lib/go-util"
)
const HeaderRewritePrefix = "hdr_rw_"
+const HeaderRewriteMidPrefix = "hdr_rw_mid_"
const ContentTypeHeaderRewriteDotConfig = ContentTypeTextASCII
const LineCommentHeaderRewriteDotConfig = LineCommentHash
const ServiceCategoryHeader = "CDN-SVC"
const MaxOriginConnectionsNoMax = 0 // 0 indicates no limit on origin connections
+const HeaderRewriteFirstPrefix = HeaderRewritePrefix + "first_"
+const HeaderRewriteInnerPrefix = HeaderRewritePrefix + "inner_"
+const HeaderRewriteLastPrefix = HeaderRewritePrefix + "last_"
+
+func FirstHeaderRewriteConfigFileName(dsName string) string {
+ return HeaderRewriteFirstPrefix + dsName + ConfigSuffix
+}
+
+func InnerHeaderRewriteConfigFileName(dsName string) string {
+ return HeaderRewriteInnerPrefix + dsName + ConfigSuffix
+}
+
+func LastHeaderRewriteConfigFileName(dsName string) string {
+ return HeaderRewriteLastPrefix + dsName + ConfigSuffix
+}
+
+// MakeHeaderRewriteDotConfig makes the header rewrite file for
+// an Edge hdr_rw_ or Mid hdr_rw_mid_ or Topology hdr_rw_{first,inner,last} file,
+// as generated by MakeMetaConfigFilesList.
func MakeHeaderRewriteDotConfig(
fileName string,
deliveryServices []DeliveryService,
deliveryServiceServers []tc.DeliveryServiceServer,
server *Server,
servers []Server,
+ cacheGroupsArr []tc.CacheGroupNullable,
+ tcServerParams []tc.Parameter,
+ serverCapabilities map[int]map[ServerCapability]struct{},
+ requiredCapabilities map[int]map[ServerCapability]struct{},
+ topologiesArr []tc.Topology,
hdrComment string,
) (Cfg, error) {
warnings := []string{}
+ if server.CDNName == nil {
+ return Cfg{}, makeErr(warnings, "this server missing CDNName")
+ } else if tc.CacheType(server.Type) == tc.CacheTypeInvalid {
+ return Cfg{}, makeErr(warnings, "this server missing Type")
+ } else if server.HostName == nil {
+ return Cfg{}, makeErr(warnings, "server missing HostName")
+ } else if server.Cachegroup == nil {
+ return Cfg{}, makeErr(warnings, "server missing Cachegroup")
+ }
- dsName := strings.TrimSuffix(strings.TrimPrefix(fileName, HeaderRewritePrefix), ConfigSuffix) // TODO verify prefix and suffix? Perl doesn't
+ cacheGroups, err := makeCGMap(cacheGroupsArr)
+ if err != nil {
+ return Cfg{}, makeErr(warnings, "making CacheGroup map: "+err.Error())
+ }
+ topologies := makeTopologyNameMap(topologiesArr)
+
+ // TODO verify prefix and suffix? Perl doesn't
+ dsName := fileName
+ dsName = strings.TrimSuffix(dsName, ConfigSuffix)
+ dsName = strings.TrimPrefix(dsName, HeaderRewriteFirstPrefix)
+ dsName = strings.TrimPrefix(dsName, HeaderRewriteInnerPrefix)
+ dsName = strings.TrimPrefix(dsName, HeaderRewriteLastPrefix)
+ dsName = strings.TrimPrefix(dsName, HeaderRewriteMidPrefix)
+ dsName = strings.TrimPrefix(dsName, HeaderRewritePrefix)
Review comment:
This code means that someone who can create or modify a DS, possibly with scope limited by tenancy can alter the config for a different DS by manipulating the name of the DS. This feels like a potential security issue in the making.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rob05c commented on a change in pull request #5641: Fix atscfg header rewrite injection
Posted by GitBox <gi...@apache.org>.
rob05c commented on a change in pull request #5641:
URL: https://github.com/apache/trafficcontrol/pull/5641#discussion_r597775289
##########
File path: lib/go-atscfg/headerrewritedotconfig.go
##########
@@ -23,74 +23,300 @@ import (
"errors"
"fmt"
"math"
+ "net/url"
"regexp"
"strconv"
"strings"
"github.com/apache/trafficcontrol/lib/go-tc"
- "github.com/apache/trafficcontrol/lib/go-util"
)
const HeaderRewritePrefix = "hdr_rw_"
+const HeaderRewriteMidPrefix = "hdr_rw_mid_"
const ContentTypeHeaderRewriteDotConfig = ContentTypeTextASCII
const LineCommentHeaderRewriteDotConfig = LineCommentHash
const ServiceCategoryHeader = "CDN-SVC"
const MaxOriginConnectionsNoMax = 0 // 0 indicates no limit on origin connections
+const HeaderRewriteFirstPrefix = HeaderRewritePrefix + "first_"
+const HeaderRewriteInnerPrefix = HeaderRewritePrefix + "inner_"
+const HeaderRewriteLastPrefix = HeaderRewritePrefix + "last_"
+
+func FirstHeaderRewriteConfigFileName(dsName string) string {
+ return HeaderRewriteFirstPrefix + dsName + ConfigSuffix
+}
+
+func InnerHeaderRewriteConfigFileName(dsName string) string {
+ return HeaderRewriteInnerPrefix + dsName + ConfigSuffix
+}
+
+func LastHeaderRewriteConfigFileName(dsName string) string {
+ return HeaderRewriteLastPrefix + dsName + ConfigSuffix
+}
+
+// MakeHeaderRewriteDotConfig makes the header rewrite file for
+// an Edge hdr_rw_ or Mid hdr_rw_mid_ or Topology hdr_rw_{first,inner,last} file,
+// as generated by MakeMetaConfigFilesList.
func MakeHeaderRewriteDotConfig(
fileName string,
deliveryServices []DeliveryService,
deliveryServiceServers []tc.DeliveryServiceServer,
server *Server,
servers []Server,
+ cacheGroupsArr []tc.CacheGroupNullable,
+ tcServerParams []tc.Parameter,
+ serverCapabilities map[int]map[ServerCapability]struct{},
+ requiredCapabilities map[int]map[ServerCapability]struct{},
+ topologiesArr []tc.Topology,
hdrComment string,
) (Cfg, error) {
warnings := []string{}
+ if server.CDNName == nil {
+ return Cfg{}, makeErr(warnings, "this server missing CDNName")
+ } else if tc.CacheType(server.Type) == tc.CacheTypeInvalid {
+ return Cfg{}, makeErr(warnings, "this server missing Type")
+ } else if server.HostName == nil {
+ return Cfg{}, makeErr(warnings, "server missing HostName")
+ } else if server.Cachegroup == nil {
+ return Cfg{}, makeErr(warnings, "server missing Cachegroup")
+ }
- dsName := strings.TrimSuffix(strings.TrimPrefix(fileName, HeaderRewritePrefix), ConfigSuffix) // TODO verify prefix and suffix? Perl doesn't
+ cacheGroups, err := makeCGMap(cacheGroupsArr)
+ if err != nil {
+ return Cfg{}, makeErr(warnings, "making CacheGroup map: "+err.Error())
+ }
+ topologies := makeTopologyNameMap(topologiesArr)
+
+ // TODO verify prefix and suffix? Perl doesn't
+ dsName := fileName
+ dsName = strings.TrimSuffix(dsName, ConfigSuffix)
+ dsName = strings.TrimPrefix(dsName, HeaderRewriteFirstPrefix)
+ dsName = strings.TrimPrefix(dsName, HeaderRewriteInnerPrefix)
+ dsName = strings.TrimPrefix(dsName, HeaderRewriteLastPrefix)
+ dsName = strings.TrimPrefix(dsName, HeaderRewriteMidPrefix)
+ dsName = strings.TrimPrefix(dsName, HeaderRewritePrefix)
Review comment:
> Looks like underscores in the DS name will cause all sorts of other issues and just need to be removed entirely. This issue isn't unique to this, so we can merge.
Yep. I made https://github.com/apache/trafficcontrol/issues/5658 to add that validation to Traffic Ops (It's already in Traffic Portal).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] alficles commented on a change in pull request #5641: Fix atscfg header rewrite injection
Posted by GitBox <gi...@apache.org>.
alficles commented on a change in pull request #5641:
URL: https://github.com/apache/trafficcontrol/pull/5641#discussion_r595986900
##########
File path: lib/go-atscfg/headerrewritedotconfig.go
##########
@@ -23,74 +23,300 @@ import (
"errors"
"fmt"
"math"
+ "net/url"
"regexp"
"strconv"
"strings"
"github.com/apache/trafficcontrol/lib/go-tc"
- "github.com/apache/trafficcontrol/lib/go-util"
)
const HeaderRewritePrefix = "hdr_rw_"
+const HeaderRewriteMidPrefix = "hdr_rw_mid_"
const ContentTypeHeaderRewriteDotConfig = ContentTypeTextASCII
const LineCommentHeaderRewriteDotConfig = LineCommentHash
const ServiceCategoryHeader = "CDN-SVC"
const MaxOriginConnectionsNoMax = 0 // 0 indicates no limit on origin connections
+const HeaderRewriteFirstPrefix = HeaderRewritePrefix + "first_"
+const HeaderRewriteInnerPrefix = HeaderRewritePrefix + "inner_"
+const HeaderRewriteLastPrefix = HeaderRewritePrefix + "last_"
+
+func FirstHeaderRewriteConfigFileName(dsName string) string {
+ return HeaderRewriteFirstPrefix + dsName + ConfigSuffix
+}
+
+func InnerHeaderRewriteConfigFileName(dsName string) string {
+ return HeaderRewriteInnerPrefix + dsName + ConfigSuffix
+}
+
+func LastHeaderRewriteConfigFileName(dsName string) string {
+ return HeaderRewriteLastPrefix + dsName + ConfigSuffix
+}
+
+// MakeHeaderRewriteDotConfig makes the header rewrite file for
+// an Edge hdr_rw_ or Mid hdr_rw_mid_ or Topology hdr_rw_{first,inner,last} file,
Review comment:
Is this comment correct? It looks like it should be `{first,inner,last}_hdr_rw_`, right? The order presented here suggests a potential conflict with a ds named `inner_`, for example.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rawlinp commented on pull request #5641: Fix atscfg header rewrite injection
Posted by GitBox <gi...@apache.org>.
rawlinp commented on pull request #5641:
URL: https://github.com/apache/trafficcontrol/pull/5641#issuecomment-801446082
Question: does this supersede https://github.com/apache/trafficcontrol/pull/5537?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rob05c commented on pull request #5641: Fix atscfg header rewrite injection
Posted by GitBox <gi...@apache.org>.
rob05c commented on pull request #5641:
URL: https://github.com/apache/trafficcontrol/pull/5641#issuecomment-802193551
> Question: does this supersede #5537?
Yes, this included that fix. I should have actually included that changeset to give @jehunte credit, I was just being lazy.
I went ahead and merged #5537 and rebased this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rawlinp commented on pull request #5641: Fix atscfg header rewrite injection
Posted by GitBox <gi...@apache.org>.
rawlinp commented on pull request #5641:
URL: https://github.com/apache/trafficcontrol/pull/5641#issuecomment-801449011
Also, please add this to the 5.1.1 milestone if you think it should go into the 5.1.1 release.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on pull request #5641: Fix atscfg header rewrite injection
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on pull request #5641:
URL: https://github.com/apache/trafficcontrol/pull/5641#issuecomment-803011996
This seems based on some larger bodies of work not slated for inclusion in 5.1.1. If a backport PR can be made and you wanna do that, let me know and I'll make sure an RC0 includes it, but the commit resulting from this PR cannot be cherry-picked in as-is due to conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rob05c commented on a change in pull request #5641: Fix atscfg header rewrite injection
Posted by GitBox <gi...@apache.org>.
rob05c commented on a change in pull request #5641:
URL: https://github.com/apache/trafficcontrol/pull/5641#discussion_r596080852
##########
File path: lib/go-atscfg/headerrewritedotconfig.go
##########
@@ -23,74 +23,300 @@ import (
"errors"
"fmt"
"math"
+ "net/url"
"regexp"
"strconv"
"strings"
"github.com/apache/trafficcontrol/lib/go-tc"
- "github.com/apache/trafficcontrol/lib/go-util"
)
const HeaderRewritePrefix = "hdr_rw_"
+const HeaderRewriteMidPrefix = "hdr_rw_mid_"
const ContentTypeHeaderRewriteDotConfig = ContentTypeTextASCII
const LineCommentHeaderRewriteDotConfig = LineCommentHash
const ServiceCategoryHeader = "CDN-SVC"
const MaxOriginConnectionsNoMax = 0 // 0 indicates no limit on origin connections
+const HeaderRewriteFirstPrefix = HeaderRewritePrefix + "first_"
+const HeaderRewriteInnerPrefix = HeaderRewritePrefix + "inner_"
+const HeaderRewriteLastPrefix = HeaderRewritePrefix + "last_"
+
+func FirstHeaderRewriteConfigFileName(dsName string) string {
+ return HeaderRewriteFirstPrefix + dsName + ConfigSuffix
+}
+
+func InnerHeaderRewriteConfigFileName(dsName string) string {
+ return HeaderRewriteInnerPrefix + dsName + ConfigSuffix
+}
+
+func LastHeaderRewriteConfigFileName(dsName string) string {
+ return HeaderRewriteLastPrefix + dsName + ConfigSuffix
+}
+
+// MakeHeaderRewriteDotConfig makes the header rewrite file for
+// an Edge hdr_rw_ or Mid hdr_rw_mid_ or Topology hdr_rw_{first,inner,last} file,
Review comment:
Yes, the comment is correct: https://github.com/apache/trafficcontrol/blob/0170bba93b4e8c3e9079b1d7f930d2c878de29e1/lib/go-atscfg/topologyheaderrewritedotconfig.go#L38
It matches the existing pattern. Yes, a DS named `inner` could cause problems, but that's true today for a DS named `mid` or `hdr_rw`.
For what it's worth, it won't cause problems once DeliveryServiceServers go away, and all DSes are using Topologies.
The only real way to fix it before that, would be to refactor and rename the DSS Edge file to be `hdr_rw_edge_*`, which would incur a non-change on every single Edge server when people upgrade.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org