You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/02/25 10:58:40 UTC
[GitHub] [skywalking-infra-e2e] ethan256 opened a new pull request #71: update trigger docs
ethan256 opened a new pull request #71:
URL: https://github.com/apache/skywalking-infra-e2e/pull/71
update trigger docs [#8589](https://github.com/apache/skywalking/issues/8589)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] wu-sheng commented on a change in pull request #71: Make `times` parameter doc more clear.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #71:
URL: https://github.com/apache/skywalking-infra-e2e/pull/71#discussion_r814717774
##########
File path: docs/en/concepts-and-designs/module-design.md
##########
@@ -66,7 +66,7 @@ Generate traffic by trigger the action, It could access `HTTP API` or execute `c
It could have these settings:
1. **interval**: How frequency to trigger the action.
-1. **times**: How many times to trigger the action, `0=infinite`.
+1. **times**: how many times the operation is triggered before aborting on the condition that trigger had failed always. `0=infinite`.
Review comment:
```suggestion
1. **times**: How many times the operation is triggered before aborting on the condition that the trigger had failed always. `0=infinite`.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] wu-sheng merged pull request #71: Make `times` parameter doc more clear.
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #71:
URL: https://github.com/apache/skywalking-infra-e2e/pull/71
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] wu-sheng commented on a change in pull request #71: update trigger docs
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #71:
URL: https://github.com/apache/skywalking-infra-e2e/pull/71#discussion_r814710480
##########
File path: internal/components/trigger/http.go
##########
@@ -79,7 +79,8 @@ func (h *httpAction) Do() chan error {
case <-t.C:
err := h.execute()
- // `h.times == h.executedCount` makes sure to only send the first error
+ // `send == false && h.times == h.executedCount` makes sure to only send firstly the error and
Review comment:
What is the `send firstly the error`? Is this?
```suggestion
// `send == false && h.times == h.executedCount` makes sure to only send the error firstly and
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] kezhenxu94 commented on a change in pull request #71: update trigger docs
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #71:
URL: https://github.com/apache/skywalking-infra-e2e/pull/71#discussion_r814714789
##########
File path: internal/components/trigger/http.go
##########
@@ -79,7 +79,8 @@ func (h *httpAction) Do() chan error {
case <-t.C:
err := h.execute()
- // `h.times == h.executedCount` makes sure to only send the first error
+ // `send == false && h.times == h.executedCount` makes sure to only send firstly the error and
+ // ignore errors before.
Review comment:
```suggestion
// `err == nil`: if no error occurs, everything is OK and send `nil` to the channel to continue.
// `h.times == h.executedCount`: reach to the maximum retry count and send the `err`, no matter it's `nil` or not.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] kezhenxu94 commented on pull request #71: update trigger docs
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #71:
URL: https://github.com/apache/skywalking-infra-e2e/pull/71#issuecomment-1050796619
@ethan256 updated the comment, hope it's more clear for you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org