You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2015/08/20 02:35:25 UTC
svn commit: r1696692 - in /commons/proper/bcel/trunk/src:
main/java/org/apache/commons/bcel6/generic/
test/java/org/apache/commons/bcel6/verifier/tests/
Author: ggregory
Date: Thu Aug 20 00:35:25 2015
New Revision: 1696692
URL: http://svn.apache.org/r1696692
Log:
Add final modifier to private fields.
Modified:
commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/FieldGenOrMethodGen.java
commons/proper/bcel/trunk/src/test/java/org/apache/commons/bcel6/verifier/tests/TestArrayAccess02Creator.java
commons/proper/bcel/trunk/src/test/java/org/apache/commons/bcel6/verifier/tests/TestArrayAccess03Creator.java
commons/proper/bcel/trunk/src/test/java/org/apache/commons/bcel6/verifier/tests/TestArrayAccess04Creator.java
commons/proper/bcel/trunk/src/test/java/org/apache/commons/bcel6/verifier/tests/TestReturn01Creator.java
commons/proper/bcel/trunk/src/test/java/org/apache/commons/bcel6/verifier/tests/TestReturn03Creator.java
Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/FieldGenOrMethodGen.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/FieldGenOrMethodGen.java?rev=1696692&r1=1696691&r2=1696692&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/FieldGenOrMethodGen.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/FieldGenOrMethodGen.java Thu Aug 20 00:35:25 2015
@@ -37,7 +37,7 @@ public abstract class FieldGenOrMethodGe
protected ConstantPoolGen cp;
private final List<Attribute> attribute_vec = new ArrayList<>();
// @since 6.0
- private List<AnnotationEntryGen> annotation_vec= new ArrayList<>();
+ private final List<AnnotationEntryGen> annotation_vec= new ArrayList<>();
protected FieldGenOrMethodGen() {
Modified: commons/proper/bcel/trunk/src/test/java/org/apache/commons/bcel6/verifier/tests/TestArrayAccess02Creator.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/test/java/org/apache/commons/bcel6/verifier/tests/TestArrayAccess02Creator.java?rev=1696692&r1=1696691&r2=1696692&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/test/java/org/apache/commons/bcel6/verifier/tests/TestArrayAccess02Creator.java (original)
+++ commons/proper/bcel/trunk/src/test/java/org/apache/commons/bcel6/verifier/tests/TestArrayAccess02Creator.java Thu Aug 20 00:35:25 2015
@@ -34,9 +34,9 @@ import org.apache.commons.bcel6.generic.
import org.junit.Assert;
public class TestArrayAccess02Creator extends TestCreator {
- private InstructionFactory _factory;
- private ConstantPoolGen _cp;
- private ClassGen _cg;
+ private final InstructionFactory _factory;
+ private final ConstantPoolGen _cp;
+ private final ClassGen _cg;
public TestArrayAccess02Creator() {
_cg = new ClassGen(TEST_PACKAGE+".TestArrayAccess02", "java.lang.Object", "TestArrayAccess02.java", Constants.ACC_PUBLIC | Constants.ACC_SUPER, new String[] { });
Modified: commons/proper/bcel/trunk/src/test/java/org/apache/commons/bcel6/verifier/tests/TestArrayAccess03Creator.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/test/java/org/apache/commons/bcel6/verifier/tests/TestArrayAccess03Creator.java?rev=1696692&r1=1696691&r2=1696692&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/test/java/org/apache/commons/bcel6/verifier/tests/TestArrayAccess03Creator.java (original)
+++ commons/proper/bcel/trunk/src/test/java/org/apache/commons/bcel6/verifier/tests/TestArrayAccess03Creator.java Thu Aug 20 00:35:25 2015
@@ -34,9 +34,9 @@ import org.apache.commons.bcel6.generic.
import org.junit.Assert;
public class TestArrayAccess03Creator extends TestCreator {
- private InstructionFactory _factory;
- private ConstantPoolGen _cp;
- private ClassGen _cg;
+ private final InstructionFactory _factory;
+ private final ConstantPoolGen _cp;
+ private final ClassGen _cg;
public TestArrayAccess03Creator() {
_cg = new ClassGen(TEST_PACKAGE+".TestArrayAccess03", "java.lang.Object", "TestArrayAccess03.java", Constants.ACC_PUBLIC | Constants.ACC_SUPER, new String[] { });
Modified: commons/proper/bcel/trunk/src/test/java/org/apache/commons/bcel6/verifier/tests/TestArrayAccess04Creator.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/test/java/org/apache/commons/bcel6/verifier/tests/TestArrayAccess04Creator.java?rev=1696692&r1=1696691&r2=1696692&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/test/java/org/apache/commons/bcel6/verifier/tests/TestArrayAccess04Creator.java (original)
+++ commons/proper/bcel/trunk/src/test/java/org/apache/commons/bcel6/verifier/tests/TestArrayAccess04Creator.java Thu Aug 20 00:35:25 2015
@@ -34,9 +34,9 @@ import org.apache.commons.bcel6.generic.
import org.junit.Assert;
public class TestArrayAccess04Creator extends TestCreator {
- private InstructionFactory _factory;
- private ConstantPoolGen _cp;
- private ClassGen _cg;
+ private final InstructionFactory _factory;
+ private final ConstantPoolGen _cp;
+ private final ClassGen _cg;
public TestArrayAccess04Creator() {
_cg = new ClassGen(TEST_PACKAGE+".TestArrayAccess04", "java.lang.Object", "TestArrayAccess04.java", Constants.ACC_PUBLIC | Constants.ACC_SUPER, new String[] { });
Modified: commons/proper/bcel/trunk/src/test/java/org/apache/commons/bcel6/verifier/tests/TestReturn01Creator.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/test/java/org/apache/commons/bcel6/verifier/tests/TestReturn01Creator.java?rev=1696692&r1=1696691&r2=1696692&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/test/java/org/apache/commons/bcel6/verifier/tests/TestReturn01Creator.java (original)
+++ commons/proper/bcel/trunk/src/test/java/org/apache/commons/bcel6/verifier/tests/TestReturn01Creator.java Thu Aug 20 00:35:25 2015
@@ -32,9 +32,9 @@ import org.apache.commons.bcel6.generic.
import org.junit.Assert;
public class TestReturn01Creator extends TestCreator {
- private InstructionFactory _factory;
- private ConstantPoolGen _cp;
- private ClassGen _cg;
+ private final InstructionFactory _factory;
+ private final ConstantPoolGen _cp;
+ private final ClassGen _cg;
public TestReturn01Creator() {
_cg = new ClassGen(TEST_PACKAGE+".TestReturn01", "java.lang.Object", "TestReturn01.java", Constants.ACC_PUBLIC | Constants.ACC_SUPER, new String[] { });
Modified: commons/proper/bcel/trunk/src/test/java/org/apache/commons/bcel6/verifier/tests/TestReturn03Creator.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/test/java/org/apache/commons/bcel6/verifier/tests/TestReturn03Creator.java?rev=1696692&r1=1696691&r2=1696692&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/test/java/org/apache/commons/bcel6/verifier/tests/TestReturn03Creator.java (original)
+++ commons/proper/bcel/trunk/src/test/java/org/apache/commons/bcel6/verifier/tests/TestReturn03Creator.java Thu Aug 20 00:35:25 2015
@@ -32,9 +32,9 @@ import org.apache.commons.bcel6.generic.
import org.junit.Assert;
public class TestReturn03Creator extends TestCreator {
- private InstructionFactory _factory;
- private ConstantPoolGen _cp;
- private ClassGen _cg;
+ private final InstructionFactory _factory;
+ private final ConstantPoolGen _cp;
+ private final ClassGen _cg;
public TestReturn03Creator() {
_cg = new ClassGen(TEST_PACKAGE+".TestReturn03", "java.lang.Object", "TestReturn03.java", Constants.ACC_PUBLIC | Constants.ACC_SUPER, new String[] { });