You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by GitBox <gi...@apache.org> on 2019/03/30 09:34:21 UTC

[GitHub] [storm] srdo commented on a change in pull request #2984: [STORM-3365] Configuration to disable Topology Lag Monitoring

srdo commented on a change in pull request #2984: [STORM-3365] Configuration to disable Topology Lag Monitoring
URL: https://github.com/apache/storm/pull/2984#discussion_r270619328
 
 

 ##########
 File path: storm-server/src/main/java/org/apache/storm/DaemonConfig.java
 ##########
 @@ -316,6 +316,12 @@
     @isBoolean
     public static final String UI_DISABLE_HTTP_BINDING = "ui.disable.http.binding";
 
+    /**
+     * This controls whether Storm UI would not monitor Spout lag.
 
 Review comment:
   Nit: If I didn't already know about storm-kafka-monitor, this would be unclear to me. I would also be confused why this doesn't do anything for non-Kafka spouts. How about "This controls whether Storm UI displays spout lag for the Kafka spout"

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services