You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by GitBox <gi...@apache.org> on 2021/06/14 07:55:37 UTC
[GitHub] [httpcomponents-client] arturobernalg opened a new pull request #308: Simplify conditions and avoid extra checks.
arturobernalg opened a new pull request #308:
URL: https://github.com/apache/httpcomponents-client/pull/308
Inline return variables.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] ok2c merged pull request #308: Simplify conditions and avoid extra checks.
Posted by GitBox <gi...@apache.org>.
ok2c merged pull request #308:
URL: https://github.com/apache/httpcomponents-client/pull/308
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] arturobernalg commented on a change in pull request #308: Simplify conditions and avoid extra checks.
Posted by GitBox <gi...@apache.org>.
arturobernalg commented on a change in pull request #308:
URL: https://github.com/apache/httpcomponents-client/pull/308#discussion_r650561858
##########
File path: httpclient5-cache/src/test/java/org/apache/hc/client5/http/impl/cache/HttpTestUtils.java
##########
@@ -260,7 +260,7 @@ public static HttpCacheEntry makeCacheEntry(final Date requestDate,
final Date responseDate, final Header[] headers, final byte[] bytes) {
final Map<String,String> variantMap = null;
Review comment:
Agree. Deleted. Thank you @michael-o
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] michael-o commented on a change in pull request #308: Simplify conditions and avoid extra checks.
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #308:
URL: https://github.com/apache/httpcomponents-client/pull/308#discussion_r650558441
##########
File path: httpclient5-win/src/main/java/org/apache/hc/client5/http/impl/win/WinHttpClients.java
##########
@@ -54,14 +52,7 @@ private WinHttpClients() {
public static boolean isWinAuthAvailable() {
String os = System.getProperty("os.name");
os = os != null ? os.toLowerCase(Locale.ROOT) : null;
- if (os != null && os.contains("windows")) {
- try {
- return Sspi.MAX_TOKEN_SIZE > 0;
Review comment:
This is a good change bacause
* SSPI is always available on Windows
* This Windows module relies on JNA
##########
File path: httpclient5-cache/src/test/java/org/apache/hc/client5/http/impl/cache/HttpTestUtils.java
##########
@@ -260,7 +260,7 @@ public static HttpCacheEntry makeCacheEntry(final Date requestDate,
final Date responseDate, final Header[] headers, final byte[] bytes) {
final Map<String,String> variantMap = null;
Review comment:
Maybe you should delete this line then?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org