You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/09/25 13:57:24 UTC
[GitHub] [maven-ear-plugin] elharo opened a new pull request #15: [MEAR-285] check return value from mkdirs
elharo opened a new pull request #15:
URL: https://github.com/apache/maven-ear-plugin/pull/15
@hboutemy
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-ear-plugin] elharo commented on pull request #15: [MEAR-285] check return value from mkdirs
Posted by GitBox <gi...@apache.org>.
elharo commented on pull request #15:
URL: https://github.com/apache/maven-ear-plugin/pull/15#issuecomment-702116699
Yes, please since that issue is already closed and shipped. I haven't been
able to reproduce this myself yet.
On Thu, Oct 1, 2020 at 8:36 AM Mikhail Gavrilov <no...@github.com>
wrote:
> I have raised a PR <https://github.com/apache/maven-ear-plugin/pull/17>
> associated with the original issue.
> Should I open a new one for it?
>
> —
> You are receiving this because you modified the open/close state.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/maven-ear-plugin/pull/15#issuecomment-702104453>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAHVP2A2MDWZKD45ZTGIKADSIRZVHANCNFSM4RZSOHKA>
> .
>
--
Elliotte Rusty Harold
elharo@macfaq.com
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-ear-plugin] zzzLobster commented on a change in pull request #15: [MEAR-285] check return value from mkdirs
Posted by GitBox <gi...@apache.org>.
zzzLobster commented on a change in pull request #15:
URL: https://github.com/apache/maven-ear-plugin/pull/15#discussion_r498309733
##########
File path: src/main/java/org/apache/maven/plugins/ear/EarMojo.java
##########
@@ -453,7 +453,10 @@ private void copyModules( final JavaEEVersion javaEEVersion,
{
getLog().info( "Copying artifact [" + module + "] to [" + module.getUri() + "] (unpacked)" );
// Make sure that the destination is a directory to avoid plexus nasty stuff :)
- destinationFile.mkdirs();
+ if ( !destinationFile.mkdirs() )
Review comment:
My bad. That's not the right place.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-ear-plugin] zzzLobster commented on pull request #15: [MEAR-285] check return value from mkdirs
Posted by GitBox <gi...@apache.org>.
zzzLobster commented on pull request #15:
URL: https://github.com/apache/maven-ear-plugin/pull/15#issuecomment-702104453
I have raised a [PR](https://github.com/apache/maven-ear-plugin/pull/17) associated with the original issue.
Should I open a new one for it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-ear-plugin] mabrarov edited a comment on pull request #15: [MEAR-285] check return value from mkdirs
Posted by GitBox <gi...@apache.org>.
mabrarov edited a comment on pull request #15:
URL: https://github.com/apache/maven-ear-plugin/pull/15#issuecomment-702158521
@elharo, I discussed this issue with @zzzLobster and we decided that I'll take care of openning new bug.
At the moment I'm able to reproduce this issue on Windows 10 x64 with https://github.com/mabrarov/dockerfile-test:
```
$ git clone --branch develop https://github.com/mabrarov/dockerfile-test.git && \
mvn -f dockerfile-test/pom.xml package -Dmaven-ear-plugin.version=3.1.0 -Ddocker.skip && \
mvn -f dockerfile-test/pom.xml package -Dmaven-ear-plugin.version=3.1.0 -Ddocker.skip
...
[INFO] --- maven-ear-plugin:3.1.0:ear (default-ear) @ ear ---
[INFO] Copying artifact [war:org.mabrarov.dockerfile-test:war:1.1.7-SNAPSHOT] to [org.mabrarov.dockerfile-test-war-1.1.7-SNAPSHOT.war]
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for dockerfile-test 1.1.7-SNAPSHOT:
[INFO]
[INFO] dockerfile-test .................................... SUCCESS [ 1.728 s]
[INFO] war ................................................ SUCCESS [ 3.652 s]
[INFO] ear ................................................ FAILURE [ 0.371 s]
[INFO] base-image ......................................... SUCCESS [ 2.297 s]
[INFO] hollow-image ....................................... SUCCESS [ 1.152 s]
[INFO] app-image .......................................... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 6.011 s (Wall Clock)
[INFO] Finished at: 2020-10-01T14:34:15+03:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-ear-plugin:3.1.0:ear (default-ear) on project ear: Failed to create directory XXX...\dockerfile-test\ear\target\temp\org.mabrarov.dockerfile-test-war-1.1.7-SNAPSHOT.war -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR] mvn <goals> -rf :ear
```
I'm in the process of creation of integration test in maven-ear-plugin repository to reproduce this issue and to validate fix of @zzzLobster.
I believe I'll complete my actions within next 12-24 hrs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-ear-plugin] mabrarov edited a comment on pull request #15: [MEAR-285] check return value from mkdirs
Posted by GitBox <gi...@apache.org>.
mabrarov edited a comment on pull request #15:
URL: https://github.com/apache/maven-ear-plugin/pull/15#issuecomment-702158521
@elharo, I discussed this issue with @zzzLobster and we decided that I'll take care of openning new bug.
At the moment I'm able to reproduce this issue on Windows 10 x64 and CentOS 7 x64 with https://github.com/mabrarov/dockerfile-test:
```
$ git clone --branch develop https://github.com/mabrarov/dockerfile-test.git && \
mvn -f dockerfile-test/pom.xml package -Dmaven-ear-plugin.version=3.1.0 -Ddocker.skip && \
mvn -f dockerfile-test/pom.xml package -Dmaven-ear-plugin.version=3.1.0 -Ddocker.skip
...
[INFO] --- maven-ear-plugin:3.1.0:ear (default-ear) @ ear ---
[INFO] Copying artifact [war:org.mabrarov.dockerfile-test:war:1.1.7-SNAPSHOT] to [org.mabrarov.dockerfile-test-war-1.1.7-SNAPSHOT.war]
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for dockerfile-test 1.1.7-SNAPSHOT:
[INFO]
[INFO] dockerfile-test .................................... SUCCESS [ 1.728 s]
[INFO] war ................................................ SUCCESS [ 3.652 s]
[INFO] ear ................................................ FAILURE [ 0.371 s]
[INFO] base-image ......................................... SUCCESS [ 2.297 s]
[INFO] hollow-image ....................................... SUCCESS [ 1.152 s]
[INFO] app-image .......................................... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 6.011 s (Wall Clock)
[INFO] Finished at: 2020-10-01T14:34:15+03:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-ear-plugin:3.1.0:ear (default-ear) on project ear: Failed to create directory XXX...\dockerfile-test\ear\target\temp\org.mabrarov.dockerfile-test-war-1.1.7-SNAPSHOT.war -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR] mvn <goals> -rf :ear
```
I'm in the process of creation of integration test in maven-ear-plugin repository to reproduce this issue and to validate fix of @zzzLobster.
I believe I'll complete my actions within next 12-24 hrs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-ear-plugin] zzzLobster commented on a change in pull request #15: [MEAR-285] check return value from mkdirs
Posted by GitBox <gi...@apache.org>.
zzzLobster commented on a change in pull request #15:
URL: https://github.com/apache/maven-ear-plugin/pull/15#discussion_r498312562
##########
File path: src/main/java/org/apache/maven/plugins/ear/EarMojo.java
##########
@@ -453,7 +453,10 @@ private void copyModules( final JavaEEVersion javaEEVersion,
{
getLog().info( "Copying artifact [" + module + "] to [" + module.getUri() + "] (unpacked)" );
// Make sure that the destination is a directory to avoid plexus nasty stuff :)
- destinationFile.mkdirs();
+ if ( !destinationFile.mkdirs() )
Review comment:
Here is the one
https://github.com/apache/maven-ear-plugin/commit/ce76c3ea43137f4efedafdb1ee57a69f6954b179#diff-0520547103a4a317e72df7f8c27e3d61R757
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-ear-plugin] mabrarov edited a comment on pull request #15: [MEAR-285] check return value from mkdirs
Posted by GitBox <gi...@apache.org>.
mabrarov edited a comment on pull request #15:
URL: https://github.com/apache/maven-ear-plugin/pull/15#issuecomment-702158521
@elharo, I discussed this issue with @zzzLobster and we decided that I'll take care of openning new bug.
At the moment I'm able to reproduce this issue on Windows 10 x64 with https://github.com/mabrarov/dockerfile-test:
```
$ git clone --branch develop https://github.com/mabrarov/dockerfile-test.git && \
mvn -f dockerfile-test/pom.xml package -Dmaven-ear-plugin.version=3.1.0 -Ddocker.skip && \
mvn -f dockerfile-test/pom.xml package -Dmaven-ear-plugin.version=3.1.0 -Ddocker.skip
...
[INFO] --- maven-ear-plugin:3.1.0:ear (default-ear) @ ear ---
[INFO] Copying artifact [war:org.mabrarov.dockerfile-test:war:1.1.7-SNAPSHOT] to [org.mabrarov.dockerfile-test-war-1.1.7-SNAPSHOT.war]
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for dockerfile-test 1.1.7-SNAPSHOT:
[INFO]
[INFO] dockerfile-test .................................... SUCCESS [ 1.728 s]
[INFO] war ................................................ SUCCESS [ 3.652 s]
[INFO] ear ................................................ FAILURE [ 0.371 s]
[INFO] base-image ......................................... SUCCESS [ 2.297 s]
[INFO] hollow-image ....................................... SUCCESS [ 1.152 s]
[INFO] app-image .......................................... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 6.011 s (Wall Clock)
[INFO] Finished at: 2020-10-01T14:34:15+03:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-ear-plugin:3.1.0:ear (default-ear) on project ear: Failed to create directory D:\Users\Marat\Documents\work\java\dockerfile-test\ear\target\temp\org.mabrarov.dockerfile-test-war-1.1.7-SNAPSHOT.war -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR] mvn <goals> -rf :ear
```
I'm in the process of creation of integration test in maven-ear-plugin repository to reproduce this issue and to validate fix of @zzzLobster.
I believe I'll complete my actions within next 12-24 hrs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-ear-plugin] zzzLobster commented on pull request #15: [MEAR-285] check return value from mkdirs
Posted by GitBox <gi...@apache.org>.
zzzLobster commented on pull request #15:
URL: https://github.com/apache/maven-ear-plugin/pull/15#issuecomment-702196921
@mabrarov , I have created the issue, just to push a new commit with the correct issue number in description.
Feel free to add any details.
https://issues.apache.org/jira/browse/MEAR-287
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-ear-plugin] zzzLobster commented on a change in pull request #15: [MEAR-285] check return value from mkdirs
Posted by GitBox <gi...@apache.org>.
zzzLobster commented on a change in pull request #15:
URL: https://github.com/apache/maven-ear-plugin/pull/15#discussion_r498081406
##########
File path: src/main/java/org/apache/maven/plugins/ear/EarMojo.java
##########
@@ -453,7 +453,10 @@ private void copyModules( final JavaEEVersion javaEEVersion,
{
getLog().info( "Copying artifact [" + module + "] to [" + module.getUri() + "] (unpacked)" );
// Make sure that the destination is a directory to avoid plexus nasty stuff :)
- destinationFile.mkdirs();
+ if ( !destinationFile.mkdirs() )
Review comment:
This change seems to be causing an issue when build is run without "clean".
`[INFO] Copying artifact [ejb:com.aaa.bbb:bbb-ejb:1.0.0.0-SNAPSHOT] to [bbb-ejb.jar]`
`[ERROR] Failed to execute goal org.apache.maven.plugins:maven-ear-plugin:3.1.0:ear (default-ear) on project bbb-ear: Failed to create directory /Checkout/project/bbb/bbb-ear/target/temp/bbb-ejb.jar -> [Help 1]`
Probably it should be wrapped with something like:
```java
if ( !destinationFile.isDirectory() )
{
if ( !destinationFile.mkdirs() )
{
throw new MojoExecutionException( "Error creating " + destinationFile );
}
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-ear-plugin] elharo merged pull request #15: [MEAR-285] check return value from mkdirs
Posted by GitBox <gi...@apache.org>.
elharo merged pull request #15:
URL: https://github.com/apache/maven-ear-plugin/pull/15
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-ear-plugin] mabrarov edited a comment on pull request #15: [MEAR-285] check return value from mkdirs
Posted by GitBox <gi...@apache.org>.
mabrarov edited a comment on pull request #15:
URL: https://github.com/apache/maven-ear-plugin/pull/15#issuecomment-702158521
@elharo, I discussed this issue with @zzzLobster and we decided that I'll take care of openning new bug.
At the moment I'm able to reproduce this issue on Windows 10 x64 with https://github.com/mabrarov/dockerfile-test:
```
$ git clone --branch develop https://github.com/mabrarov/dockerfile-test.git && \
mvn -f dockerfile-test/pom.xml clean package -Dmaven-ear-plugin.version=3.1.0 -Ddocker.skip && \
mvn -f dockerfile-test/pom.xml package -Dmaven-ear-plugin.version=3.1.0 -Ddocker.skip
...
[INFO] --- maven-ear-plugin:3.1.0:ear (default-ear) @ ear ---
[INFO] Copying artifact [war:org.mabrarov.dockerfile-test:war:1.1.7-SNAPSHOT] to [org.mabrarov.dockerfile-test-war-1.1.7-SNAPSHOT.war]
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for dockerfile-test 1.1.7-SNAPSHOT:
[INFO]
[INFO] dockerfile-test .................................... SUCCESS [ 1.728 s]
[INFO] war ................................................ SUCCESS [ 3.652 s]
[INFO] ear ................................................ FAILURE [ 0.371 s]
[INFO] base-image ......................................... SUCCESS [ 2.297 s]
[INFO] hollow-image ....................................... SUCCESS [ 1.152 s]
[INFO] app-image .......................................... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 6.011 s (Wall Clock)
[INFO] Finished at: 2020-10-01T14:34:15+03:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-ear-plugin:3.1.0:ear (default-ear) on project ear: Failed to create directory D:\Users\Marat\Documents\work\java\dockerfile-test\ear\target\temp\org.mabrarov.dockerfile-test-war-1.1.7-SNAPSHOT.war -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR] mvn <goals> -rf :ear
```
I'm in the process of creation of integration test in maven-ear-plugin repository to reproduce this issue and to validate fix of @zzzLobster.
I believe I'll complete my actions within next 12-24 hrs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-ear-plugin] mabrarov edited a comment on pull request #15: [MEAR-285] check return value from mkdirs
Posted by GitBox <gi...@apache.org>.
mabrarov edited a comment on pull request #15:
URL: https://github.com/apache/maven-ear-plugin/pull/15#issuecomment-702158521
@elharo, I discussed this issue with @zzzLobster and we decided that I'll take care of openning new bug.
At the moment I'm able to reproduce this issue on Windows 10 x64 with https://github.com/mabrarov/dockerfile-test:
```
$ git clone https://github.com/mabrarov/dockerfile-test.git && \
mvn -f dockerfile-test/pom.xml clean package -Ddocker.skip && \
mvn -f dockerfile-test/pom.xml package -Ddocker.skip
...
[INFO] --- maven-ear-plugin:3.1.0:ear (default-ear) @ ear ---
[INFO] Copying artifact [war:org.mabrarov.dockerfile-test:war:1.1.7-SNAPSHOT] to [org.mabrarov.dockerfile-test-war-1.1.7-SNAPSHOT.war]
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for dockerfile-test 1.1.7-SNAPSHOT:
[INFO]
[INFO] dockerfile-test .................................... SUCCESS [ 1.728 s]
[INFO] war ................................................ SUCCESS [ 3.652 s]
[INFO] ear ................................................ FAILURE [ 0.371 s]
[INFO] base-image ......................................... SUCCESS [ 2.297 s]
[INFO] hollow-image ....................................... SUCCESS [ 1.152 s]
[INFO] app-image .......................................... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 6.011 s (Wall Clock)
[INFO] Finished at: 2020-10-01T14:34:15+03:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-ear-plugin:3.1.0:ear (default-ear) on project ear: Failed to create directory D:\Users\Marat\Documents\work\java\dockerfile-test\ear\target\temp\org.mabrarov.dockerfile-test-war-1.1.7-SNAPSHOT.war -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR] mvn <goals> -rf :ear
```
I'm in the process of creation of integration test in maven-ear-plugin repository to reproduce this issue and to validate fix of @zzzLobster.
I believe I'll complete my actions within next 12-24 hrs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-ear-plugin] elharo commented on pull request #15: [MEAR-285] check return value from mkdirs
Posted by GitBox <gi...@apache.org>.
elharo commented on pull request #15:
URL: https://github.com/apache/maven-ear-plugin/pull/15#issuecomment-702025531
Sounds plausible. Can you open an issue in the Jira and assign to me?
On Thu, Oct 1, 2020 at 8:45 AM Mikhail Gavrilov <no...@github.com>
wrote:
> *@zzzLobster* commented on this pull request.
> ------------------------------
>
> In src/main/java/org/apache/maven/plugins/ear/EarMojo.java
> <https://github.com/apache/maven-ear-plugin/pull/15#discussion_r498081406>
> :
>
> > @@ -453,7 +453,10 @@ private void copyModules( final JavaEEVersion javaEEVersion,
> {
> getLog().info( "Copying artifact [" + module + "] to [" + module.getUri() + "] (unpacked)" );
> // Make sure that the destination is a directory to avoid plexus nasty stuff :)
> - destinationFile.mkdirs();
> + if ( !destinationFile.mkdirs() )
>
> This change seems to be causing an issue when build is run without "clean".
> [INFO] Copying artifact [ejb:com.aaa.bbb:bbb-ejb:1.0.0.0-SNAPSHOT] to
> [bbb-ejb.jar]
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-ear-plugin:3.1.0:ear (default-ear) on
> project bbb-ear: Failed to create directory
> /Checkout/project/bbb/bbb-ear/target/temp/bbb-ejb.jar -> [Help 1]
>
> Probably it should be wrapped with something like:
>
> if ( !destinationFile.isDirectory() )
> {
> if ( !destinationFile.mkdirs() )
> {
> throw new MojoExecutionException( "Error creating " + destinationFile );
> }
> }
>
> —
> You are receiving this because you modified the open/close state.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/maven-ear-plugin/pull/15#pullrequestreview-500131735>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAHVP2BRCHY6LCADKNCI4BTSIQ6RLANCNFSM4RZSOHKA>
> .
>
--
Elliotte Rusty Harold
elharo@macfaq.com
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-ear-plugin] mabrarov commented on pull request #15: [MEAR-285] check return value from mkdirs
Posted by GitBox <gi...@apache.org>.
mabrarov commented on pull request #15:
URL: https://github.com/apache/maven-ear-plugin/pull/15#issuecomment-702158521
@elharo, I discussed this issue with @zzzLobster and we decided that I'll take care of openning new bug.
At the moment I'm able to reproduce this issue on Windows 10 x64 with https://github.com/mabrarov/dockerfile-test:
```
$ git clone https://github.com/mabrarov/dockerfile-test.git && \
mvn -f dockerfile-test/pom.xml clean package -Ddocker.skip && \
mvn -f dockerfile-test/pom.xml package -Ddocker.skip
...
[INFO] --- maven-ear-plugin:3.1.0:ear (default-ear) @ ear ---
[INFO] Copying artifact [war:org.mabrarov.dockerfile-test:war:1.1.7-SNAPSHOT] to [org.mabrarov.dockerfile-test-war-1.1.7-SNAPSHOT.war]
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for dockerfile-test 1.1.7-SNAPSHOT:
[INFO]
[INFO] dockerfile-test .................................... SUCCESS [ 1.728 s]
[INFO] war ................................................ SUCCESS [ 3.652 s]
[INFO] ear ................................................ FAILURE [ 0.371 s]
[INFO] base-image ......................................... SUCCESS [ 2.297 s]
[INFO] hollow-image ....................................... SUCCESS [ 1.152 s]
[INFO] app-image .......................................... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 6.011 s (Wall Clock)
[INFO] Finished at: 2020-10-01T14:34:15+03:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-ear-plugin:3.1.0:ear (default-ear) on project ear: Failed to create directory D:\Users\Marat\Documents\work\java\dockerfile-test\ear\target\temp\org.mabrarov.dockerfile-test-war-1.1.7-SNAPSHOT.war -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR] mvn <goals> -rf :ear
```
I'm in the process of creation of integration test in maven-ear-plugin repository to reproduce this issue and to checked fix of @zzzLobster.
I believe I'll complete my actions within next 12-24 hrs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org