You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/12/11 12:41:16 UTC
[GitHub] [spark] StefanXiepj opened a new pull request #30734: SPARK-33755: Allow creating orc table when row format separator is defined
StefanXiepj opened a new pull request #30734:
URL: https://github.com/apache/spark/pull/30734
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
When creating table like this:
`create table test_orc(c1 string) row format delimited fields terminated by '002' stored as orcfile;`
spark throws exception like :
`Operation
not allowed: ROW FORMAT DELIMITED is only compatible with 'textfile', not
'orcfile'(line 2, pos 0)`
Maybe we don’t need such strict rules, we can support it.
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
UTs to be added
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] StefanXiepj commented on a change in pull request #30734: SPARK-33755: Allow creating orc table when row format separator is defined
Posted by GitBox <gi...@apache.org>.
StefanXiepj commented on a change in pull request #30734:
URL: https://github.com/apache/spark/pull/30734#discussion_r543429928
##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/HiveOrcSourceSuite.scala
##########
@@ -327,4 +327,18 @@ class HiveOrcSourceSuite extends OrcSuite with TestHiveSingleton {
val df = readResourceOrcFile("test-data/TestStringDictionary.testRowIndex.orc")
assert(df.where("str < 'row 001000'").count() === 1000)
}
+
+ test("SPARK-33755: Allow creating orc table when row format separator is defined") {
+ withTable("row_format_orc") {
+ sql(
+ s"""CREATE TABLE row_format_orc(
+ | intField INT,
+ | stringField STRING
+ |)
+ |ROW FORMAT DELIMITED FIELDS TERMINATED BY '002'
Review comment:
Sorry for my late reply. I found this problem when migrating hive's task to spark. Hive is supported (It's not good, but it's not a problem, we can ignore it). So I fixed it in version Spark 2.4. Although Orc doesn't need this delimiter, but I don't think we need to be so strict in syntax. It is more convenient to migrate tasks from hive to spark.
I will close this PR and re submit a new PR based on Spark 2.4 https://github.com/apache/spark/pull/30785
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #30734: SPARK-33755: Allow creating orc table when row format separator is defined
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #30734:
URL: https://github.com/apache/spark/pull/30734#issuecomment-743175354
Thanks for your PR. Btw, could you check the contribution guide first (the `Pull Request` section in https://spark.apache.org/contributing.html)? At least, you need to update the title and the PR description for following our format.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] StefanXiepj closed pull request #30734: SPARK-33755: Allow creating orc table when row format separator is defined
Posted by GitBox <gi...@apache.org>.
StefanXiepj closed pull request #30734:
URL: https://github.com/apache/spark/pull/30734
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] StefanXiepj commented on a change in pull request #30734: SPARK-33755: Allow creating orc table when row format separator is defined
Posted by GitBox <gi...@apache.org>.
StefanXiepj commented on a change in pull request #30734:
URL: https://github.com/apache/spark/pull/30734#discussion_r543429928
##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/HiveOrcSourceSuite.scala
##########
@@ -327,4 +327,18 @@ class HiveOrcSourceSuite extends OrcSuite with TestHiveSingleton {
val df = readResourceOrcFile("test-data/TestStringDictionary.testRowIndex.orc")
assert(df.where("str < 'row 001000'").count() === 1000)
}
+
+ test("SPARK-33755: Allow creating orc table when row format separator is defined") {
+ withTable("row_format_orc") {
+ sql(
+ s"""CREATE TABLE row_format_orc(
+ | intField INT,
+ | stringField STRING
+ |)
+ |ROW FORMAT DELIMITED FIELDS TERMINATED BY '002'
Review comment:
Sorry for my late reply. I found this problem when migrating task from hive to spark. Hive is supported (It's not good, but it's not a problem, we can ignore it). So I fixed it in version Spark 2.4. Although Orc doesn't need this delimiter, but I don't think we need to be so strict in syntax. It is more convenient to migrate tasks from hive to spark.
I will close this PR and re submit a new PR based on Spark 2.4 https://github.com/apache/spark/pull/30785
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30734: SPARK-33755: Allow creating orc table when row format separator is defined
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30734:
URL: https://github.com/apache/spark/pull/30734#issuecomment-743174488
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #30734: SPARK-33755: Allow creating orc table when row format separator is defined
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #30734:
URL: https://github.com/apache/spark/pull/30734#discussion_r543217815
##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/HiveOrcSourceSuite.scala
##########
@@ -327,4 +327,18 @@ class HiveOrcSourceSuite extends OrcSuite with TestHiveSingleton {
val df = readResourceOrcFile("test-data/TestStringDictionary.testRowIndex.orc")
assert(df.where("str < 'row 001000'").count() === 1000)
}
+
+ test("SPARK-33755: Allow creating orc table when row format separator is defined") {
+ withTable("row_format_orc") {
+ sql(
+ s"""CREATE TABLE row_format_orc(
+ | intField INT,
+ | stringField STRING
+ |)
+ |ROW FORMAT DELIMITED FIELDS TERMINATED BY '002'
Review comment:
How does the ORC table wotk with the delimiter?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] StefanXiepj commented on a change in pull request #30734: SPARK-33755: Allow creating orc table when row format separator is defined
Posted by GitBox <gi...@apache.org>.
StefanXiepj commented on a change in pull request #30734:
URL: https://github.com/apache/spark/pull/30734#discussion_r543429928
##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/HiveOrcSourceSuite.scala
##########
@@ -327,4 +327,18 @@ class HiveOrcSourceSuite extends OrcSuite with TestHiveSingleton {
val df = readResourceOrcFile("test-data/TestStringDictionary.testRowIndex.orc")
assert(df.where("str < 'row 001000'").count() === 1000)
}
+
+ test("SPARK-33755: Allow creating orc table when row format separator is defined") {
+ withTable("row_format_orc") {
+ sql(
+ s"""CREATE TABLE row_format_orc(
+ | intField INT,
+ | stringField STRING
+ |)
+ |ROW FORMAT DELIMITED FIELDS TERMINATED BY '002'
Review comment:
Sorry for my late reply. I found this problem when migrating hive's task to spark. Hive is supported (It's not good, but it's not a problem, we can ignore it). So I fixed it in version Spark 2.4. Although Orc doesn't need this delimiter, but I don't think we need to be so strict in syntax. It is more convenient to migrate tasks from hive to spark.
I will close this PR and re submit a new PR based on Spark 2.4
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org