[GitHub] [superset] pkdotson commented on a diff in pull request #20281: feat: Visualize SqlLab.Query model data in Explore 📈

[GitBox <gi...@apache.org>]

pkdotson commented on code in PR #20281:
URL: https://github.com/apache/superset/pull/20281#discussion_r922549070


##########
superset-frontend/src/explore/components/ExploreChartPanel.jsx:
##########
@@ -145,9 +149,17 @@ const ExploreChartPanel = ({
     getItem(LocalStorageKeys.chart_split_sizes, INITIAL_SIZES),
   );
 
+  const [showDatasetModal, setShowDatasetModal] = useState(false);
+
+  const metaDataRegistry = getChartMetadataRegistry();
+  const { useLegacyApi } = metaDataRegistry.get(vizType);
+  const vizTypeNeedsDataset = useLegacyApi && datasource.type !== 'dataset';
+
+  // added boolean column to below show boolean so that the errors aren't overlapping

Review Comment:
   liking all the comments!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org