You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Maxim Khutornenko <ma...@apache.org> on 2014/01/16 02:02:40 UTC

Review Request 16931: Fixing admin scheduler_print_recovery_tasks.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16931/
-----------------------------------------------------------

Review request for Aurora and Kevin Sweeney.


Bugs: AURORA-40
    https://issues.apache.org/jira/browse/AURORA-40


Repository: aurora


Description
-------

Fixing admin scheduler_print_recovery_tasks.


Diffs
-----

  src/main/python/apache/aurora/client/commands/admin.py 8abb983084933f9320e782dc94f465139d559ebf 

Diff: https://reviews.apache.org/r/16931/diff/


Testing
-------

Before:
$ aurora_admin scheduler_print_recovery_tasks example
 INFO] Response from scheduler: OK (message: None)
 INFO] Role	Job	Shard	Status	Task ID
Traceback (most recent call last):
  File "/local/lib/python2.7/dist-packages/twitter/common/app/application.py", line 738, in _wrap_method
    return_code = method()
  File "/local/lib/python2.7/dist-packages/twitter/common/app/application.py", line 760, in <lambda>
    main = lambda: main_method(*args, **kwargs)
  File "apache/aurora/client/base.py", line 56, in wrapped_function
    return fn(*args)
  File "apache/aurora/client/commands/admin.py", line 333, in scheduler_print_recovery_tasks
    for task in resp.tasks:
AttributeError: 'Response' object has no attribute 'tasks'

After:
$ aurora_admin scheduler_print_recovery_tasks example
 INFO] Response from scheduler: OK (message: None)
 INFO] Role	Job	Shard	Status	Task ID
 INFO] www-data	hello	0	RUNNING	1389653898736-www-data-prod-hello-0-3b147157-31d1-4d5b-9a70-0e508efe15ee


Thanks,

Maxim Khutornenko


Re: Review Request 16931: Fixing admin scheduler_print_recovery_tasks.

Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16931/#review31979
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Sweeney


On Jan. 15, 2014, 5:02 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16931/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2014, 5:02 p.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Bugs: AURORA-40
>     https://issues.apache.org/jira/browse/AURORA-40
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Fixing admin scheduler_print_recovery_tasks.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/commands/admin.py 8abb983084933f9320e782dc94f465139d559ebf 
> 
> Diff: https://reviews.apache.org/r/16931/diff/
> 
> 
> Testing
> -------
> 
> Before:
> $ aurora_admin scheduler_print_recovery_tasks example
>  INFO] Response from scheduler: OK (message: None)
>  INFO] Role	Job	Shard	Status	Task ID
> Traceback (most recent call last):
>   File "/local/lib/python2.7/dist-packages/twitter/common/app/application.py", line 738, in _wrap_method
>     return_code = method()
>   File "/local/lib/python2.7/dist-packages/twitter/common/app/application.py", line 760, in <lambda>
>     main = lambda: main_method(*args, **kwargs)
>   File "apache/aurora/client/base.py", line 56, in wrapped_function
>     return fn(*args)
>   File "apache/aurora/client/commands/admin.py", line 333, in scheduler_print_recovery_tasks
>     for task in resp.tasks:
> AttributeError: 'Response' object has no attribute 'tasks'
> 
> After:
> $ aurora_admin scheduler_print_recovery_tasks example
>  INFO] Response from scheduler: OK (message: None)
>  INFO] Role	Job	Shard	Status	Task ID
>  INFO] www-data	hello	0	RUNNING	1389653898736-www-data-prod-hello-0-3b147157-31d1-4d5b-9a70-0e508efe15ee
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Re: Review Request 16931: Fixing admin scheduler_print_recovery_tasks.

Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16931/#review31982
-----------------------------------------------------------


Thanks. Pushed.

- Maxim Khutornenko


On Jan. 16, 2014, 1:02 a.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16931/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2014, 1:02 a.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Bugs: AURORA-40
>     https://issues.apache.org/jira/browse/AURORA-40
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Fixing admin scheduler_print_recovery_tasks.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/commands/admin.py 8abb983084933f9320e782dc94f465139d559ebf 
> 
> Diff: https://reviews.apache.org/r/16931/diff/
> 
> 
> Testing
> -------
> 
> Before:
> $ aurora_admin scheduler_print_recovery_tasks example
>  INFO] Response from scheduler: OK (message: None)
>  INFO] Role	Job	Shard	Status	Task ID
> Traceback (most recent call last):
>   File "/local/lib/python2.7/dist-packages/twitter/common/app/application.py", line 738, in _wrap_method
>     return_code = method()
>   File "/local/lib/python2.7/dist-packages/twitter/common/app/application.py", line 760, in <lambda>
>     main = lambda: main_method(*args, **kwargs)
>   File "apache/aurora/client/base.py", line 56, in wrapped_function
>     return fn(*args)
>   File "apache/aurora/client/commands/admin.py", line 333, in scheduler_print_recovery_tasks
>     for task in resp.tasks:
> AttributeError: 'Response' object has no attribute 'tasks'
> 
> After:
> $ aurora_admin scheduler_print_recovery_tasks example
>  INFO] Response from scheduler: OK (message: None)
>  INFO] Role	Job	Shard	Status	Task ID
>  INFO] www-data	hello	0	RUNNING	1389653898736-www-data-prod-hello-0-3b147157-31d1-4d5b-9a70-0e508efe15ee
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>