You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by Enrique Rodriguez <en...@gmail.com> on 2005/06/09 05:58:53 UTC

Re: svn commit: r189676 - in /directory/network: branches/0.7/src/java/org/apache/mina/registry/SimpleServiceRegistry.java branches/dirmina-39/src/java/org/apache/mina/registry/SimpleServiceRegistry.java trunk/src/java/org/apache/mina/registry/SimpleServiceRegistry.java

Hi, Trustin and other committers,

I would find it very useful if the SVN commit messages, when they are 
related to a JIRA issue, contained both the JIRA id and short 
description, such that:

Fixed: DIRMINA-59

becomes:

Fixed: DIRMINA-59 SimpleServiceRegistry doesn't need to throw IOException

Without the short description, I find it takes longer to get on top of 
the volumous amount of commit and JIRA posts.

WDYT?

-enrique



trustin@apache.org wrote:
> Author: trustin
> Date: Wed Jun  8 17:58:39 2005
> New Revision: 189676
> 
> URL: http://svn.apache.org/viewcvs?rev=189676&view=rev
> Log:
> Fixed: DIRMINA-59
> 
> 
> Modified:
>     directory/network/branches/0.7/src/java/org/apache/mina/registry/SimpleServiceRegistry.java
>     directory/network/branches/dirmina-39/src/java/org/apache/mina/registry/SimpleServiceRegistry.java
>     directory/network/trunk/src/java/org/apache/mina/registry/SimpleServiceRegistry.java
> 
> Modified: directory/network/branches/0.7/src/java/org/apache/mina/registry/SimpleServiceRegistry.java
> URL: http://svn.apache.org/viewcvs/directory/network/branches/0.7/src/java/org/apache/mina/registry/SimpleServiceRegistry.java?rev=189676&r1=189675&r2=189676&view=diff
> ==============================================================================
> --- directory/network/branches/0.7/src/java/org/apache/mina/registry/SimpleServiceRegistry.java (original)
> +++ directory/network/branches/0.7/src/java/org/apache/mina/registry/SimpleServiceRegistry.java Wed Jun  8 17:58:39 2005
> @@ -52,7 +52,7 @@
>  
>      private final Set services = new HashSet();
>  
> -    public SimpleServiceRegistry() throws IOException
> +    public SimpleServiceRegistry()
>      {
>          socketIoAcceptor.getFilterChain().addFirst( "threadPool", ioThreadPoolFilter );
>          datagramIoAcceptor.getFilterChain().addFirst( "threadPool", ioThreadPoolFilter );
> 
> Modified: directory/network/branches/dirmina-39/src/java/org/apache/mina/registry/SimpleServiceRegistry.java
> URL: http://svn.apache.org/viewcvs/directory/network/branches/dirmina-39/src/java/org/apache/mina/registry/SimpleServiceRegistry.java?rev=189676&r1=189675&r2=189676&view=diff
> ==============================================================================
> --- directory/network/branches/dirmina-39/src/java/org/apache/mina/registry/SimpleServiceRegistry.java (original)
> +++ directory/network/branches/dirmina-39/src/java/org/apache/mina/registry/SimpleServiceRegistry.java Wed Jun  8 17:58:39 2005
> @@ -40,7 +40,7 @@
>  
>      private final Set services = new HashSet();
>  
> -    public SimpleServiceRegistry() throws IOException
> +    public SimpleServiceRegistry()
>      {
>          socketIoAcceptor.getFilterChain().addFirst( "threadPool", threadPoolFilter );
>          datagramIoAcceptor.getFilterChain().addFirst( "threadPool", threadPoolFilter );
> 
> Modified: directory/network/trunk/src/java/org/apache/mina/registry/SimpleServiceRegistry.java
> URL: http://svn.apache.org/viewcvs/directory/network/trunk/src/java/org/apache/mina/registry/SimpleServiceRegistry.java?rev=189676&r1=189675&r2=189676&view=diff
> ==============================================================================
> --- directory/network/trunk/src/java/org/apache/mina/registry/SimpleServiceRegistry.java (original)
> +++ directory/network/trunk/src/java/org/apache/mina/registry/SimpleServiceRegistry.java Wed Jun  8 17:58:39 2005
> @@ -40,7 +40,7 @@
>  
>      private final Set services = new HashSet();
>  
> -    public SimpleServiceRegistry() throws IOException
> +    public SimpleServiceRegistry()
>      {
>          socketIoAcceptor.getFilterChain().addFirst( "threadPool", threadPoolFilter );
>          datagramIoAcceptor.getFilterChain().addFirst( "threadPool", threadPoolFilter );
> 
> 
> 


Re: svn commit: r189676 - in /directory/network: branches/0.7/src/java/org/apache/mina/registry/SimpleServiceRegistry.java branches/dirmina-39/src/java/org/apache/mina/registry/SimpleServiceRegistry.java trunk/src/java/org/apache/mina/registry/Simple

Posted by Alex Karasulu <ao...@bellsouth.net>.
Trustin Lee wrote:

> Hi Enrique and others,
>  
> Can't we modify SVN hook script to insert link to JIRA if we meet some 
> DIRXXX-NN strings?  It will save our time really much to copying and 
> pasting issue titles between editor and web browser.
>  

THat would be sweet and a question for infra@.a.o.  If anybody knows 
they will.

Alex


Re: svn commit: r189676 - in /directory/network: branches/0.7/src/java/org/apache/mina/registry/SimpleServiceRegistry.java branches/dirmina-39/src/java/org/apache/mina/registry/SimpleServiceRegistry.java trunk/src/java/org/apache/mina/registry/Simple

Posted by Trustin Lee <tr...@gmail.com>.
Hi Enrique and others,
 Can't we modify SVN hook script to insert link to JIRA if we meet some 
DIRXXX-NN strings? It will save our time really much to copying and pasting 
issue titles between editor and web browser.
 Trustin
 2005/6/9, Enrique Rodriguez <en...@gmail.com>: 
> 
> Hi, Trustin and other committers,
> 
> I would find it very useful if the SVN commit messages, when they are
> related to a JIRA issue, contained both the JIRA id and short
> description, such that:
> 
> Fixed: DIRMINA-59
> 
> becomes:
> 
> Fixed: DIRMINA-59 SimpleServiceRegistry doesn't need to throw IOException
> 
> Without the short description, I find it takes longer to get on top of
> the volumous amount of commit and JIRA posts.
> 
> WDYT?
> 
> -enrique
> 
> trustin@apache.org wrote:
> > Author: trustin
> > Date: Wed Jun 8 17:58:39 2005
> > New Revision: 189676
> >
> > URL: http://svn.apache.org/viewcvs?rev=189676&view=rev
> > Log:
> > Fixed: DIRMINA-59
> >
> >
> > Modified:
> > 
> directory/network/branches/0.7/src/java/org/apache/mina/registry/SimpleServiceRegistry.java
> > 
> directory/network/branches/dirmina-39/src/java/org/apache/mina/registry/SimpleServiceRegistry.java
> > 
> directory/network/trunk/src/java/org/apache/mina/registry/SimpleServiceRegistry.java
> >
> > Modified: 
> directory/network/branches/0.7/src/java/org/apache/mina/registry/SimpleServiceRegistry.java
> > URL: 
> http://svn.apache.org/viewcvs/directory/network/branches/0.7/src/java/org/apache/mina/registry/SimpleServiceRegistry.java?rev=189676&r1=189675&r2=189676&view=diff
> > 
> ==============================================================================
> > --- 
> directory/network/branches/0.7/src/java/org/apache/mina/registry/SimpleServiceRegistry.java 
> (original)
> > +++ 
> directory/network/branches/0.7/src/java/org/apache/mina/registry/SimpleServiceRegistry.java 
> Wed Jun 8 17:58:39 2005
> > @@ -52,7 +52,7 @@
> >
> > private final Set services = new HashSet();
> >
> > - public SimpleServiceRegistry() throws IOException
> > + public SimpleServiceRegistry()
> > {
> > socketIoAcceptor.getFilterChain().addFirst( "threadPool", 
> ioThreadPoolFilter );
> > datagramIoAcceptor.getFilterChain().addFirst( "threadPool", 
> ioThreadPoolFilter );
> >
> > Modified: 
> directory/network/branches/dirmina-39/src/java/org/apache/mina/registry/SimpleServiceRegistry.java
> > URL: 
> http://svn.apache.org/viewcvs/directory/network/branches/dirmina-39/src/java/org/apache/mina/registry/SimpleServiceRegistry.java?rev=189676&r1=189675&r2=189676&view=diff
> > 
> ==============================================================================
> > --- 
> directory/network/branches/dirmina-39/src/java/org/apache/mina/registry/SimpleServiceRegistry.java 
> (original)
> > +++ 
> directory/network/branches/dirmina-39/src/java/org/apache/mina/registry/SimpleServiceRegistry.java 
> Wed Jun 8 17:58:39 2005
> > @@ -40,7 +40,7 @@
> >
> > private final Set services = new HashSet();
> >
> > - public SimpleServiceRegistry() throws IOException
> > + public SimpleServiceRegistry()
> > {
> > socketIoAcceptor.getFilterChain().addFirst( "threadPool", 
> threadPoolFilter );
> > datagramIoAcceptor.getFilterChain().addFirst( "threadPool", 
> threadPoolFilter );
> >
> > Modified: 
> directory/network/trunk/src/java/org/apache/mina/registry/SimpleServiceRegistry.java
> > URL: 
> http://svn.apache.org/viewcvs/directory/network/trunk/src/java/org/apache/mina/registry/SimpleServiceRegistry.java?rev=189676&r1=189675&r2=189676&view=diff
> > 
> ==============================================================================
> > --- 
> directory/network/trunk/src/java/org/apache/mina/registry/SimpleServiceRegistry.java 
> (original)
> > +++ 
> directory/network/trunk/src/java/org/apache/mina/registry/SimpleServiceRegistry.java 
> Wed Jun 8 17:58:39 2005
> > @@ -40,7 +40,7 @@
> >
> > private final Set services = new HashSet();
> >
> > - public SimpleServiceRegistry() throws IOException
> > + public SimpleServiceRegistry()
> > {
> > socketIoAcceptor.getFilterChain().addFirst( "threadPool", 
> threadPoolFilter );
> > datagramIoAcceptor.getFilterChain().addFirst( "threadPool", 
> threadPoolFilter );
> >
> >
> >
> 
> 


-- 
what we call human nature is actually human habit
--
http://gleamynode.net/