You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/09/10 03:36:43 UTC

[GitHub] [druid] FrankChen021 commented on a diff in pull request #13064: Cleaner JSON for various input sources and formats.

FrankChen021 commented on code in PR #13064:
URL: https://github.com/apache/druid/pull/13064#discussion_r967575315


##########
core/src/main/java/org/apache/druid/data/input/impl/CloudObjectInputSource.java:
##########
@@ -83,26 +84,30 @@ public CloudObjectInputSource(
   }
 
   @JsonProperty
+  @JsonInclude(JsonInclude.Include.NON_NULL)

Review Comment:
   I'm wondering if we can configure the `DefaultObjectMapper` to exclude all null value in global so that we don't need to add such annotation for every get method?
   
   ```java
   mapper.setSerializationInclusion(JsonInclude.Include.NON_NULL);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org