You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/03/27 06:18:24 UTC

[GitHub] jai1 opened a new pull request #1454: Check if request is HTTPs before redirecting to TLS URL

jai1 opened a new pull request #1454: Check if request is HTTPs before redirecting to TLS URL
URL: https://github.com/apache/incubator-pulsar/pull/1454
 
 
   Code review bug: While deciding whether to return the `serviceUrl` or `serviceUrlTls` of a replication cluster we should check whether the request is HTTPS and since `getServiceUrlTls` can be null we should use `StringUtils.isNotBlank` instead of `isEmpty`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services