You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2015/11/24 21:59:30 UTC
Review Request 40672: Fixed flakey test:
MasterMaintenanceTest.InverseOffersFilters.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40672/
-----------------------------------------------------------
Review request for mesos, Joris Van Remoortere and Joseph Wu.
Bugs: MESOS-3916
https://issues.apache.org/jira/browse/MESOS-3916
Repository: mesos
Description
-------
MESOS-3916.
Diffs
-----
src/tests/master_maintenance_tests.cpp ade05f932020013ced19c1573be756a029396fac
Diff: https://reviews.apache.org/r/40672/diff/
Testing
-------
(1) mesos-tests --gtest_repeat=2000 on OSX
(2) My Ubuntu VM seems to be in a weird state: this fixes the observed flakiness, but there seem to be other weird networking issues that cause messaging timeouts that seem to be unrelated.
Thanks,
Neil Conway
Re: Review Request 40672: Fixed flakey test:
MasterMaintenanceTest.InverseOffersFilters.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40672/#review107944
-----------------------------------------------------------
Patch looks great!
Reviews applied: [40672]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Nov. 24, 2015, 9:07 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40672/
> -----------------------------------------------------------
>
> (Updated Nov. 24, 2015, 9:07 p.m.)
>
>
> Review request for mesos, Joris Van Remoortere, Joseph Wu, Jan Schlicht, and Till Toenshoff.
>
>
> Bugs: MESOS-3916
> https://issues.apache.org/jira/browse/MESOS-3916
>
>
> Repository: mesos
>
>
> Description
> -------
>
> MESOS-3916.
>
>
> Diffs
> -----
>
> src/tests/master_maintenance_tests.cpp ade05f932020013ced19c1573be756a029396fac
>
> Diff: https://reviews.apache.org/r/40672/diff/
>
>
> Testing
> -------
>
> (1) mesos-tests --gtest_repeat=2000 on OSX
> (2) My Ubuntu VM seems to be in a weird state: this fixes the observed flakiness, but there seem to be other weird networking issues that cause messaging timeouts that seem to be unrelated. Till, Jan: would you guys mind repro'ing that this fixes the flakiness for you?
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 40672: Fixed flakey test:
MasterMaintenanceTest.InverseOffersFilters.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40672/#review108046
-----------------------------------------------------------
Ship it!
* Solves observed flakiness (Check!)
* Test runs 10+ times faster (Check!)
- Joseph Wu
On Nov. 24, 2015, 1:07 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40672/
> -----------------------------------------------------------
>
> (Updated Nov. 24, 2015, 1:07 p.m.)
>
>
> Review request for mesos, Joris Van Remoortere, Joseph Wu, Jan Schlicht, and Till Toenshoff.
>
>
> Bugs: MESOS-3916
> https://issues.apache.org/jira/browse/MESOS-3916
>
>
> Repository: mesos
>
>
> Description
> -------
>
> MESOS-3916.
>
>
> Diffs
> -----
>
> src/tests/master_maintenance_tests.cpp ade05f932020013ced19c1573be756a029396fac
>
> Diff: https://reviews.apache.org/r/40672/diff/
>
>
> Testing
> -------
>
> (1) mesos-tests --gtest_repeat=2000 on OSX
> (2) My Ubuntu VM seems to be in a weird state: this fixes the observed flakiness, but there seem to be other weird networking issues that cause messaging timeouts that seem to be unrelated. Till, Jan: would you guys mind repro'ing that this fixes the flakiness for you?
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 40672: Fixed flakey test:
MasterMaintenanceTest.InverseOffersFilters.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40672/#review108840
-----------------------------------------------------------
Ship it!
Ship It!
- Joris Van Remoortere
On Nov. 24, 2015, 9:07 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40672/
> -----------------------------------------------------------
>
> (Updated Nov. 24, 2015, 9:07 p.m.)
>
>
> Review request for mesos, Joris Van Remoortere, Joseph Wu, Jan Schlicht, and Till Toenshoff.
>
>
> Bugs: MESOS-3916
> https://issues.apache.org/jira/browse/MESOS-3916
>
>
> Repository: mesos
>
>
> Description
> -------
>
> MESOS-3916.
>
>
> Diffs
> -----
>
> src/tests/master_maintenance_tests.cpp ade05f932020013ced19c1573be756a029396fac
>
> Diff: https://reviews.apache.org/r/40672/diff/
>
>
> Testing
> -------
>
> (1) mesos-tests --gtest_repeat=2000 on OSX
> (2) My Ubuntu VM seems to be in a weird state: this fixes the observed flakiness, but there seem to be other weird networking issues that cause messaging timeouts that seem to be unrelated. Till, Jan: would you guys mind repro'ing that this fixes the flakiness for you?
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 40672: Fixed flakey test:
MasterMaintenanceTest.InverseOffersFilters.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40672/
-----------------------------------------------------------
(Updated Nov. 24, 2015, 9:07 p.m.)
Review request for mesos, Joris Van Remoortere, Joseph Wu, Jan Schlicht, and Till Toenshoff.
Changes
-------
Whitespace fix.
Bugs: MESOS-3916
https://issues.apache.org/jira/browse/MESOS-3916
Repository: mesos
Description
-------
MESOS-3916.
Diffs (updated)
-----
src/tests/master_maintenance_tests.cpp ade05f932020013ced19c1573be756a029396fac
Diff: https://reviews.apache.org/r/40672/diff/
Testing
-------
(1) mesos-tests --gtest_repeat=2000 on OSX
(2) My Ubuntu VM seems to be in a weird state: this fixes the observed flakiness, but there seem to be other weird networking issues that cause messaging timeouts that seem to be unrelated. Till, Jan: would you guys mind repro'ing that this fixes the flakiness for you?
Thanks,
Neil Conway
Re: Review Request 40672: Fixed flakey test:
MasterMaintenanceTest.InverseOffersFilters.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40672/#review107844
-----------------------------------------------------------
src/tests/master_maintenance_tests.cpp
<https://reviews.apache.org/r/40672/#comment167169>
This was removed because, as far as I can tell, it is unnecessary.
src/tests/master_maintenance_tests.cpp
<https://reviews.apache.org/r/40672/#comment167170>
This was removed because, as far as I can tell, it is unnecessary.
- Neil Conway
On Nov. 24, 2015, 9:04 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40672/
> -----------------------------------------------------------
>
> (Updated Nov. 24, 2015, 9:04 p.m.)
>
>
> Review request for mesos, Joris Van Remoortere, Joseph Wu, Jan Schlicht, and Till Toenshoff.
>
>
> Bugs: MESOS-3916
> https://issues.apache.org/jira/browse/MESOS-3916
>
>
> Repository: mesos
>
>
> Description
> -------
>
> MESOS-3916.
>
>
> Diffs
> -----
>
> src/tests/master_maintenance_tests.cpp ade05f932020013ced19c1573be756a029396fac
>
> Diff: https://reviews.apache.org/r/40672/diff/
>
>
> Testing
> -------
>
> (1) mesos-tests --gtest_repeat=2000 on OSX
> (2) My Ubuntu VM seems to be in a weird state: this fixes the observed flakiness, but there seem to be other weird networking issues that cause messaging timeouts that seem to be unrelated. Till, Jan: would you guys mind repro'ing that this fixes the flakiness for you?
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 40672: Fixed flakey test:
MasterMaintenanceTest.InverseOffersFilters.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40672/
-----------------------------------------------------------
(Updated Nov. 24, 2015, 9:04 p.m.)
Review request for mesos, Joris Van Remoortere, Joseph Wu, Jan Schlicht, and Till Toenshoff.
Bugs: MESOS-3916
https://issues.apache.org/jira/browse/MESOS-3916
Repository: mesos
Description
-------
MESOS-3916.
Diffs
-----
src/tests/master_maintenance_tests.cpp ade05f932020013ced19c1573be756a029396fac
Diff: https://reviews.apache.org/r/40672/diff/
Testing (updated)
-------
(1) mesos-tests --gtest_repeat=2000 on OSX
(2) My Ubuntu VM seems to be in a weird state: this fixes the observed flakiness, but there seem to be other weird networking issues that cause messaging timeouts that seem to be unrelated. Till, Jan: would you guys mind repro'ing that this fixes the flakiness for you?
Thanks,
Neil Conway