You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Robbie Gemmell (JIRA)" <ji...@apache.org> on 2012/11/25 15:34:58 UTC

[jira] [Created] (QPID-4468) [Java client] restore ability to enable SSL using a connection level option rather than as a sub-option of each brokerlist entry

Robbie Gemmell created QPID-4468:
------------------------------------

             Summary: [Java client] restore ability to enable SSL using a connection level option rather than as a sub-option of each brokerlist entry
                 Key: QPID-4468
                 URL: https://issues.apache.org/jira/browse/QPID-4468
             Project: Qpid
          Issue Type: Improvement
          Components: Java Client
    Affects Versions: 0.18, 0.16, 0.14, 0.12, 0.10, 0.8, 0.6
            Reporter: Robbie Gemmell
            Assignee: Robbie Gemmell
             Fix For: 0.21


On old client versions it was possible to specify that SSL should be used at the connection level options. It is now only possible to specify this as part of the brokerlist sub-options (in addition to much finer-grained control over the keystores/truststores and certificates etc to be used). If you are just using the SSL system properties to define they keystore/truststore etc and have multiple brokers in the brokerlist it is actually more convenient to specify ssl=true at the connection level.

Restoring this will maintain compatibility for drop-in replacement of old clients and also help prevent user confiusion resulting from the URL parsers inability to alert them to the previous ssl configuration going unused.

It will be restored as an ovveride of ssl option in the brokerlist entries.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[jira] [Updated] (QPID-4468) [Java client] restore ability to enable SSL using a connection level option rather than as a sub-option of each brokerlist entry

Posted by "Robbie Gemmell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-4468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robbie Gemmell updated QPID-4468:
---------------------------------

    Status: Ready To Review  (was: In Progress)
    
> [Java client] restore ability to enable SSL using a connection level option rather than as a sub-option of each brokerlist entry
> --------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: QPID-4468
>                 URL: https://issues.apache.org/jira/browse/QPID-4468
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Client
>    Affects Versions: 0.6, 0.8, 0.10, 0.12, 0.14, 0.16, 0.18
>            Reporter: Robbie Gemmell
>            Assignee: Robbie Gemmell
>             Fix For: 0.21
>
>
> On old client versions it was possible to specify that SSL should be used at the connection level options. It is now only possible to specify this as part of the brokerlist sub-options (in addition to much finer-grained control over the keystores/truststores and certificates etc to be used). If you are just using the SSL system properties to define they keystore/truststore etc and have multiple brokers in the brokerlist it is actually more convenient to specify ssl=true at the connection level.
> Restoring this will maintain compatibility for drop-in replacement of old clients and also help prevent user confiusion resulting from the URL parsers inability to alert them to the previous ssl configuration going unused.
> It will be restored as an ovveride of ssl option in the brokerlist entries.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[jira] [Commented] (QPID-4468) [Java client] restore ability to enable SSL using a connection level option rather than as a sub-option of each brokerlist entry

Posted by "Robbie Gemmell (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/QPID-4468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13503512#comment-13503512 ] 

Robbie Gemmell commented on QPID-4468:
--------------------------------------

I did consider doing it that way, but it was looking a little messy (the ConnectionSettings cant convey a lack of SSL option, so you then need to start looking at the BrokerDetails object as well, or switch ConnectionSettings to a Boolean to allow conveying null and add a Boolean getter instead of the boolean isUseSSL) and as you say it smacks of misconfiguration a little (I also considered throwing an Exception because of that). As its not really intended to be used together with the brokerlist option, but rather instead of it, in the end I decided just to document the overriding nature and leave it at that.
                
> [Java client] restore ability to enable SSL using a connection level option rather than as a sub-option of each brokerlist entry
> --------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: QPID-4468
>                 URL: https://issues.apache.org/jira/browse/QPID-4468
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Client
>    Affects Versions: 0.6, 0.8, 0.10, 0.12, 0.14, 0.16, 0.18
>            Reporter: Robbie Gemmell
>            Assignee: Robbie Gemmell
>             Fix For: 0.21
>
>
> On old client versions it was possible to specify that SSL should be used at the connection level options. It is now only possible to specify this as part of the brokerlist sub-options (in addition to much finer-grained control over the keystores/truststores and certificates etc to be used). If you are just using the SSL system properties to define they keystore/truststore etc and have multiple brokers in the brokerlist it is actually more convenient to specify ssl=true at the connection level.
> Restoring this will maintain compatibility for drop-in replacement of old clients and also help prevent user confiusion resulting from the URL parsers inability to alert them to the previous ssl configuration going unused.
> It will be restored as an ovveride of ssl option in the brokerlist entries.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[jira] [Commented] (QPID-4468) [Java client] restore ability to enable SSL using a connection level option rather than as a sub-option of each brokerlist entry

Posted by "Robbie Gemmell (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/QPID-4468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13503503#comment-13503503 ] 

Robbie Gemmell commented on QPID-4468:
--------------------------------------

Change made in http://svn.apache.org/viewvc?rev=1413364&view=rev
                
> [Java client] restore ability to enable SSL using a connection level option rather than as a sub-option of each brokerlist entry
> --------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: QPID-4468
>                 URL: https://issues.apache.org/jira/browse/QPID-4468
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Client
>    Affects Versions: 0.6, 0.8, 0.10, 0.12, 0.14, 0.16, 0.18
>            Reporter: Robbie Gemmell
>            Assignee: Robbie Gemmell
>             Fix For: 0.21
>
>
> On old client versions it was possible to specify that SSL should be used at the connection level options. It is now only possible to specify this as part of the brokerlist sub-options (in addition to much finer-grained control over the keystores/truststores and certificates etc to be used). If you are just using the SSL system properties to define they keystore/truststore etc and have multiple brokers in the brokerlist it is actually more convenient to specify ssl=true at the connection level.
> Restoring this will maintain compatibility for drop-in replacement of old clients and also help prevent user confiusion resulting from the URL parsers inability to alert them to the previous ssl configuration going unused.
> It will be restored as an ovveride of ssl option in the brokerlist entries.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[jira] [Updated] (QPID-4468) [Java client] restore ability to enable SSL using a connection level option rather than as a sub-option of each brokerlist entry

Posted by "Justin Ross (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-4468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Justin Ross updated QPID-4468:
------------------------------

    Fix Version/s: 0.20
    
> [Java client] restore ability to enable SSL using a connection level option rather than as a sub-option of each brokerlist entry
> --------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: QPID-4468
>                 URL: https://issues.apache.org/jira/browse/QPID-4468
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Client
>    Affects Versions: 0.6, 0.8, 0.10, 0.12, 0.14, 0.16, 0.18
>            Reporter: Robbie Gemmell
>            Assignee: Robbie Gemmell
>             Fix For: 0.20, 0.21
>
>
> On old client versions it was possible to specify that SSL should be used at the connection level options. It is now only possible to specify this as part of the brokerlist sub-options (in addition to much finer-grained control over the keystores/truststores and certificates etc to be used). If you are just using the SSL system properties to define they keystore/truststore etc and have multiple brokers in the brokerlist it is actually more convenient to specify ssl=true at the connection level.
> Restoring this will maintain compatibility for drop-in replacement of old clients and also help prevent user confiusion resulting from the URL parsers inability to alert them to the previous ssl configuration going unused.
> It will be restored as an ovveride of ssl option in the brokerlist entries.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[jira] [Commented] (QPID-4468) [Java client] restore ability to enable SSL using a connection level option rather than as a sub-option of each brokerlist entry

Posted by "Robbie Gemmell (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/QPID-4468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505796#comment-13505796 ] 

Robbie Gemmell commented on QPID-4468:
--------------------------------------

Now merged to the 0.20 release branch.
                
> [Java client] restore ability to enable SSL using a connection level option rather than as a sub-option of each brokerlist entry
> --------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: QPID-4468
>                 URL: https://issues.apache.org/jira/browse/QPID-4468
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Client
>    Affects Versions: 0.6, 0.8, 0.10, 0.12, 0.14, 0.16, 0.18
>            Reporter: Robbie Gemmell
>            Assignee: Robbie Gemmell
>             Fix For: 0.20, 0.21
>
>
> On old client versions it was possible to specify that SSL should be used at the connection level options. It is now only possible to specify this as part of the brokerlist sub-options (in addition to much finer-grained control over the keystores/truststores and certificates etc to be used). If you are just using the SSL system properties to define they keystore/truststore etc and have multiple brokers in the brokerlist it is actually more convenient to specify ssl=true at the connection level.
> Restoring this will maintain compatibility for drop-in replacement of old clients and also help prevent user confiusion resulting from the URL parsers inability to alert them to the previous ssl configuration going unused.
> It will be restored as an ovveride of ssl option in the brokerlist entries.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[jira] [Resolved] (QPID-4468) [Java client] restore ability to enable SSL using a connection level option rather than as a sub-option of each brokerlist entry

Posted by "Rob Godfrey (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-4468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rob Godfrey resolved QPID-4468.
-------------------------------

    Resolution: Fixed

The changes look good, though I wonder a little about the override policy, I would think that you would only want to override where the broker list SSL had not been set at all... having ssl turned on for a broker detail where it was explicitly false (or vice versa) seems weird (though really I think any such URL is just a misconfiguration in itself)
                
> [Java client] restore ability to enable SSL using a connection level option rather than as a sub-option of each brokerlist entry
> --------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: QPID-4468
>                 URL: https://issues.apache.org/jira/browse/QPID-4468
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Client
>    Affects Versions: 0.6, 0.8, 0.10, 0.12, 0.14, 0.16, 0.18
>            Reporter: Robbie Gemmell
>            Assignee: Robbie Gemmell
>             Fix For: 0.21
>
>
> On old client versions it was possible to specify that SSL should be used at the connection level options. It is now only possible to specify this as part of the brokerlist sub-options (in addition to much finer-grained control over the keystores/truststores and certificates etc to be used). If you are just using the SSL system properties to define they keystore/truststore etc and have multiple brokers in the brokerlist it is actually more convenient to specify ssl=true at the connection level.
> Restoring this will maintain compatibility for drop-in replacement of old clients and also help prevent user confiusion resulting from the URL parsers inability to alert them to the previous ssl configuration going unused.
> It will be restored as an ovveride of ssl option in the brokerlist entries.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[jira] [Commented] (QPID-4468) [Java client] restore ability to enable SSL using a connection level option rather than as a sub-option of each brokerlist entry

Posted by "Justin Ross (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/QPID-4468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505400#comment-13505400 ] 

Justin Ross commented on QPID-4468:
-----------------------------------

Reviewed by Rob.  Approve for 0.20.
                
> [Java client] restore ability to enable SSL using a connection level option rather than as a sub-option of each brokerlist entry
> --------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: QPID-4468
>                 URL: https://issues.apache.org/jira/browse/QPID-4468
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Client
>    Affects Versions: 0.6, 0.8, 0.10, 0.12, 0.14, 0.16, 0.18
>            Reporter: Robbie Gemmell
>            Assignee: Robbie Gemmell
>             Fix For: 0.20, 0.21
>
>
> On old client versions it was possible to specify that SSL should be used at the connection level options. It is now only possible to specify this as part of the brokerlist sub-options (in addition to much finer-grained control over the keystores/truststores and certificates etc to be used). If you are just using the SSL system properties to define they keystore/truststore etc and have multiple brokers in the brokerlist it is actually more convenient to specify ssl=true at the connection level.
> Restoring this will maintain compatibility for drop-in replacement of old clients and also help prevent user confiusion resulting from the URL parsers inability to alert them to the previous ssl configuration going unused.
> It will be restored as an ovveride of ssl option in the brokerlist entries.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org