You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brpc.apache.org by GitBox <gi...@apache.org> on 2021/09/03 00:46:03 UTC

[GitHub] [incubator-brpc] tanzhongyi003 opened a new pull request #1547: Update README.md

tanzhongyi003 opened a new pull request #1547:
URL: https://github.com/apache/incubator-brpc/pull/1547


   add link to brpc's website


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org


[GitHub] [incubator-brpc] tanzhongyi003 commented on pull request #1547: Update README.md

Posted by GitBox <gi...@apache.org>.
tanzhongyi003 commented on pull request #1547:
URL: https://github.com/apache/incubator-brpc/pull/1547#issuecomment-916138125


   I will make another one to include zh and eng also。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org


[GitHub] [incubator-brpc] tanzhongyi003 closed pull request #1547: Update README.md

Posted by GitBox <gi...@apache.org>.
tanzhongyi003 closed pull request #1547:
URL: https://github.com/apache/incubator-brpc/pull/1547


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org


[GitHub] [incubator-brpc] lorinlee commented on a change in pull request #1547: Update README.md

Posted by GitBox <gi...@apache.org>.
lorinlee commented on a change in pull request #1547:
URL: https://github.com/apache/incubator-brpc/pull/1547#discussion_r701517327



##########
File path: README.md
##########
@@ -104,3 +104,5 @@ Please refer to [here](CONTRIBUTING.md).
 # Feedback and Getting involved
 * Report bugs, ask questions or give suggestions by [Github Issues](https://github.com/apache/incubator-brpc/issues)
 * Subscribe mailing list(dev-subscribe@brpc.apache.org) to get updated with the project
+
+# official website[here](https://brpc.apache.org)

Review comment:
       Thx! It would be better if adding a space after 'website', otherwise, we will see 'websitehere'




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org