[jira] [Commented] (SCB-1056) Put provider QPS flow control in front

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SCB-1056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16703066#comment-16703066 ] 

ASF GitHub Bot commented on SCB-1056:
-------------------------------------

yhs0092 opened a new pull request #1017: [SCB-1056] put provider flow control logic in front
URL: https://github.com/apache/servicecomb-java-chassis/pull/1017
 
 
   Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
    - [x] Each commit in the pull request should have a meaningful subject line and body.
    - [x] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
    - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [x] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
    - [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   See details in [SCB-1056](https://issues.apache.org/jira/browse/SCB-1056)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Put provider QPS flow control in front
> --------------------------------------
>
>                 Key: SCB-1056
>                 URL: https://issues.apache.org/jira/browse/SCB-1056
>             Project: Apache ServiceComb
>          Issue Type: Improvement
>          Components: Java-Chassis
>            Reporter: YaoHaishi
>            Assignee: YaoHaishi
>            Priority: Major
>
> Currently provider QPS flow control is in ProviderQpsFlowControlHandler which works in provider handler chain. As a result, the flow control logic takes effect too late and much CPU resource is wasted on processing those requests that should be rejected earlier.
> Put the provider QPS flow control logic in front can save the resource.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)