You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/12/13 08:11:58 UTC
[GitHub] [ozone] JacksonYao287 opened a new pull request #2918: use FileUtils.moveDirectory instead of Files.move when installing snapshot
JacksonYao287 opened a new pull request #2918:
URL: https://github.com/apache/ozone/pull/2918
## What changes were proposed in this pull request?
in our cluster , we put scm db and ratis in different directories which in different disk partitions. but when bootstraping this cluster , we found the ozone cluster does not work well because the follower scm fail to install snapshot. after investigating, we found the db checkpoint will be downloaded to the directory the same as the ratis log by default. when replacing the old db, scm will use `files.move` to move the checkpoint to the db directory. but according to the description of `files.move`, When moving a directory requires that its entries be moved then this method fails (by throwing an IOException). so we should use fileutils.moveDirectory here as om does
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-6101
## How was this patch tested?
current UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ChenSammi commented on pull request #2918: HDDS-6101. use FileUtils.moveDirectory instead of Files.move when installing snapshot
Posted by GitBox <gi...@apache.org>.
ChenSammi commented on pull request #2918:
URL: https://github.com/apache/ozone/pull/2918#issuecomment-999520828
LGTM, +1.
Thanks @JacksonYao287 for the contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ChenSammi commented on a change in pull request #2918: HDDS-6101. use FileUtils.moveDirectory instead of Files.move when installing snapshot
Posted by GitBox <gi...@apache.org>.
ChenSammi commented on a change in pull request #2918:
URL: https://github.com/apache/ozone/pull/2918#discussion_r773575050
##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMDatanodeProtocolServer.java
##########
@@ -180,7 +180,7 @@ public SCMDatanodeProtocolServer(final OzoneConfiguration conf,
public void start() {
LOG.info(
StorageContainerManager.buildRpcServerStartMessage(
- "RPC server for DataNodes", datanodeRpcAddress));
+ "ScmDatanodeProtocl RPC server for DataNodes", datanodeRpcAddress));
Review comment:
Protocl 拼写
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] JacksonYao287 commented on pull request #2918: HDDS-6101. use FileUtils.moveDirectory instead of Files.move when installing snapshot
Posted by GitBox <gi...@apache.org>.
JacksonYao287 commented on pull request #2918:
URL: https://github.com/apache/ozone/pull/2918#issuecomment-992363515
@guihecheng @ChenSammi please take a look ,thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] JacksonYao287 commented on pull request #2918: HDDS-6101. use FileUtils.moveDirectory instead of Files.move when installing snapshot
Posted by GitBox <gi...@apache.org>.
JacksonYao287 commented on pull request #2918:
URL: https://github.com/apache/ozone/pull/2918#issuecomment-999490304
@ChenSammi thanks for the review! i have fixed the typo error , PTAL!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ChenSammi merged pull request #2918: HDDS-6101. use FileUtils.moveDirectory instead of Files.move when installing snapshot
Posted by GitBox <gi...@apache.org>.
ChenSammi merged pull request #2918:
URL: https://github.com/apache/ozone/pull/2918
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] JacksonYao287 commented on a change in pull request #2918: HDDS-6101. use FileUtils.moveDirectory instead of Files.move when installing snapshot
Posted by GitBox <gi...@apache.org>.
JacksonYao287 commented on a change in pull request #2918:
URL: https://github.com/apache/ozone/pull/2918#discussion_r773577650
##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMDatanodeProtocolServer.java
##########
@@ -180,7 +180,7 @@ public SCMDatanodeProtocolServer(final OzoneConfiguration conf,
public void start() {
LOG.info(
StorageContainerManager.buildRpcServerStartMessage(
- "RPC server for DataNodes", datanodeRpcAddress));
+ "ScmDatanodeProtocl RPC server for DataNodes", datanodeRpcAddress));
Review comment:
thanks, will fix this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org